From: Philippe Schenker <philippe.schenker@toradex.com> To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "a.fatoum@pengutronix.de" <a.fatoum@pengutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org> Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-imx@nxp.com" <linux-imx@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org> Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Date: Mon, 13 Jul 2020 11:53:56 +0000 [thread overview] Message-ID: <c76c0fd056512a3f8e24bf06e7bb7e1650090609.camel@toradex.com> (raw) In-Reply-To: <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de> On Mon, 2020-07-13 at 11:46 +0200, Ahmad Fatoum wrote: > Hello Philippe, > > On 7/10/20 3:24 PM, Philippe Schenker wrote: > > Since the runtime-pm wakeup bug was fixed in > > drivers/usb/chipidea/core.c usb dual-role host/device switching is > > working. So make use of it. > > > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > > > > --- > > > > arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 9 +++++++++ > > arch/arm/boot/dts/imx7-colibri.dtsi | 4 ++-- > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > index 97601375f264..db56a532a34a 100644 > > --- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > @@ -20,6 +20,14 @@ clk16m: clk16m { > > clock-frequency = <16000000>; > > }; > > > > + extcon_usbc_det: usbc_det { > > + compatible = "linux,extcon-usb-gpio"; > > According to 4602f3bff266 ("usb: common: add USB GPIO based connection > detection driver"): > "the old way using extcon to support USB Dual-Role switch is now > deprecated > when use Type-B connector." > > Have you considered using a compatible = "gpio-usb-b-connector" child > node instead? > > Cheers, > Ahmad Thanks for the Hint Ahmad, I already tried and just now tried again but it doesn't work on our hardware. Are you sure this works with chipidea driver? Should this new usb-connector stuff work in general with every old driver? Philippe > > > + id-gpio = <&gpio7 14 GPIO_ACTIVE_HIGH>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usbc_det>; > > + }; > > + > > + > > gpio-keys { > > compatible = "gpio-keys"; > > pinctrl-names = "default"; > > @@ -174,6 +182,7 @@ &uart3 { > > }; > > > > &usbotg1 { > > + extcon = <0>, <&extcon_usbc_det>; > > status = "okay"; > > }; > > > > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi > > b/arch/arm/boot/dts/imx7-colibri.dtsi > > index e18e89dec879..caea90d2421f 100644 > > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > > @@ -457,7 +457,7 @@ &uart3 { > > }; > > > > &usbotg1 { > > - dr_mode = "host"; > > + dr_mode = "otg"; > > }; > > > > &usdhc1 { > > @@ -486,7 +486,7 @@ &usdhc3 { > > &iomuxc { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_gpio1 &pinctrl_gpio2 &pinctrl_gpio3 > > &pinctrl_gpio4 > > - &pinctrl_gpio7 &pinctrl_usbc_det>; > > + &pinctrl_gpio7>; > > > > pinctrl_gpio1: gpio1-grp { > > fsl,pins = < > >
WARNING: multiple messages have this Message-ID (diff)
From: Philippe Schenker <philippe.schenker@toradex.com> To: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "a.fatoum@pengutronix.de" <a.fatoum@pengutronix.de>, "shawnguo@kernel.org" <shawnguo@kernel.org> Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "linux-imx@nxp.com" <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Date: Mon, 13 Jul 2020 11:53:56 +0000 [thread overview] Message-ID: <c76c0fd056512a3f8e24bf06e7bb7e1650090609.camel@toradex.com> (raw) In-Reply-To: <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de> On Mon, 2020-07-13 at 11:46 +0200, Ahmad Fatoum wrote: > Hello Philippe, > > On 7/10/20 3:24 PM, Philippe Schenker wrote: > > Since the runtime-pm wakeup bug was fixed in > > drivers/usb/chipidea/core.c usb dual-role host/device switching is > > working. So make use of it. > > > > Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com> > > > > --- > > > > arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi | 9 +++++++++ > > arch/arm/boot/dts/imx7-colibri.dtsi | 4 ++-- > > 2 files changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > index 97601375f264..db56a532a34a 100644 > > --- a/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri-eval-v3.dtsi > > @@ -20,6 +20,14 @@ clk16m: clk16m { > > clock-frequency = <16000000>; > > }; > > > > + extcon_usbc_det: usbc_det { > > + compatible = "linux,extcon-usb-gpio"; > > According to 4602f3bff266 ("usb: common: add USB GPIO based connection > detection driver"): > "the old way using extcon to support USB Dual-Role switch is now > deprecated > when use Type-B connector." > > Have you considered using a compatible = "gpio-usb-b-connector" child > node instead? > > Cheers, > Ahmad Thanks for the Hint Ahmad, I already tried and just now tried again but it doesn't work on our hardware. Are you sure this works with chipidea driver? Should this new usb-connector stuff work in general with every old driver? Philippe > > > + id-gpio = <&gpio7 14 GPIO_ACTIVE_HIGH>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_usbc_det>; > > + }; > > + > > + > > gpio-keys { > > compatible = "gpio-keys"; > > pinctrl-names = "default"; > > @@ -174,6 +182,7 @@ &uart3 { > > }; > > > > &usbotg1 { > > + extcon = <0>, <&extcon_usbc_det>; > > status = "okay"; > > }; > > > > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi > > b/arch/arm/boot/dts/imx7-colibri.dtsi > > index e18e89dec879..caea90d2421f 100644 > > --- a/arch/arm/boot/dts/imx7-colibri.dtsi > > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi > > @@ -457,7 +457,7 @@ &uart3 { > > }; > > > > &usbotg1 { > > - dr_mode = "host"; > > + dr_mode = "otg"; > > }; > > > > &usdhc1 { > > @@ -486,7 +486,7 @@ &usdhc3 { > > &iomuxc { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_gpio1 &pinctrl_gpio2 &pinctrl_gpio3 > > &pinctrl_gpio4 > > - &pinctrl_gpio7 &pinctrl_usbc_det>; > > + &pinctrl_gpio7>; > > > > pinctrl_gpio1: gpio1-grp { > > fsl,pins = < > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-13 11:54 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-10 13:24 [PATCH 1/3] ARM: dts: colibri-imx6: remove pinctrl-names orphan Philippe Schenker 2020-07-10 13:24 ` Philippe Schenker 2020-07-10 13:24 ` [PATCH 2/3] ARM: dts: colibri-imx6: add usb dual-role switch capability Philippe Schenker 2020-07-10 13:24 ` Philippe Schenker 2020-07-10 13:45 ` Oleksandr Suvorov 2020-07-10 13:45 ` Oleksandr Suvorov 2020-07-10 13:24 ` [PATCH 3/3] ARM: dts: colibri-imx7: " Philippe Schenker 2020-07-10 13:24 ` Philippe Schenker 2020-07-10 13:47 ` Oleksandr Suvorov 2020-07-10 13:47 ` Oleksandr Suvorov 2020-07-13 9:46 ` Ahmad Fatoum 2020-07-13 9:46 ` Ahmad Fatoum 2020-07-13 10:52 ` Shawn Guo 2020-07-13 10:52 ` Shawn Guo 2020-07-13 11:53 ` Philippe Schenker [this message] 2020-07-13 11:53 ` Philippe Schenker 2020-07-14 7:55 ` Ahmad Fatoum 2020-07-14 7:55 ` Ahmad Fatoum 2020-07-14 8:20 ` Philippe Schenker 2020-07-14 8:20 ` Philippe Schenker 2020-07-20 2:11 ` Shawn Guo 2020-07-20 2:11 ` Shawn Guo 2020-07-20 7:37 ` Philippe Schenker 2020-07-20 7:37 ` Philippe Schenker 2020-07-23 11:44 ` Philippe Schenker 2020-07-23 11:44 ` Philippe Schenker 2020-07-10 13:42 ` [PATCH 1/3] ARM: dts: colibri-imx6: remove pinctrl-names orphan Oleksandr Suvorov 2020-07-10 13:42 ` Oleksandr Suvorov 2020-07-13 9:01 ` Shawn Guo 2020-07-13 9:01 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c76c0fd056512a3f8e24bf06e7bb7e1650090609.camel@toradex.com \ --to=philippe.schenker@toradex.com \ --cc=a.fatoum@pengutronix.de \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.