From: <Claudiu.Beznea@microchip.com>
To: <arnd@kernel.org>, <linux@armlinux.org.uk>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <nathan@kernel.org>,
<ndesaulniers@google.com>
Cc: <soc@kernel.org>, <arnd@arndb.de>, <sboyd@kernel.org>,
<clang-built-linux@googlegroups.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
Date: Thu, 4 Feb 2021 18:18:14 +0000 [thread overview]
Message-ID: <c7e601ab-03c0-7b20-9678-3f9f4615836d@microchip.com> (raw)
In-Reply-To: <20210204160129.2249394-1-arnd@kernel.org>
On 04.02.2021 18:01, Arnd Bergmann wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> Remove the extra '#' character that is not used for the 'ldr'
> instruction when doing an indirect load of a constant.
>
> Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 909856c8a8c6..0d467cc40129 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
> str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
>
> /* step 2. */
> - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
> + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
> str tmp1, [pmc, #AT91_PMC_PLL_ACR]
>
> /* step 3. */
> --
> 2.29.2
>
WARNING: multiple messages have this Message-ID (diff)
From: <Claudiu.Beznea@microchip.com>
To: <arnd@kernel.org>, <linux@armlinux.org.uk>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <nathan@kernel.org>,
<ndesaulniers@google.com>
Cc: arnd@arndb.de, sboyd@kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com, soc@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: at91: use proper asm syntax in pm_suspend
Date: Thu, 4 Feb 2021 18:18:14 +0000 [thread overview]
Message-ID: <c7e601ab-03c0-7b20-9678-3f9f4615836d@microchip.com> (raw)
Message-ID: <20210204181814.R9Kni7FmQ68fLT-3kwMpCG61PVp3Z1mTpw9E2Gi8DwQ@z> (raw)
In-Reply-To: <20210204160129.2249394-1-arnd@kernel.org>
On 04.02.2021 18:01, Arnd Bergmann wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compiling with the clang integrated assembler warns about
> a recently added instruction:
>
> <instantiation>:14:13: error: unknown token in expression
> ldr tmp1, =#0x00020010UL
> arch/arm/mach-at91/pm_suspend.S:542:2: note: while in macro instantiation
> at91_plla_enable
>
> Remove the extra '#' character that is not used for the 'ldr'
> instruction when doing an indirect load of a constant.
>
> Fixes: 4fd36e458392 ("ARM: at91: pm: add plla disable/enable support for sam9x60")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index 909856c8a8c6..0d467cc40129 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -446,7 +446,7 @@ ENDPROC(at91_backup_mode)
> str tmp1, [pmc, #AT91_PMC_PLL_UPDT]
>
> /* step 2. */
> - ldr tmp1, =#AT91_PMC_PLL_ACR_DEFAULT_PLLA
> + ldr tmp1, =AT91_PMC_PLL_ACR_DEFAULT_PLLA
> str tmp1, [pmc, #AT91_PMC_PLL_ACR]
>
> /* step 3. */
> --
> 2.29.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-04 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 16:01 [PATCH] ARM: at91: use proper asm syntax in pm_suspend Arnd Bergmann
2021-02-04 16:01 ` Arnd Bergmann
2021-02-04 18:18 ` Claudiu.Beznea [this message]
2021-02-04 18:18 ` Claudiu.Beznea
2021-02-04 18:43 ` Nicolas Ferre
2021-02-04 18:43 ` Nicolas Ferre
2021-02-04 18:49 ` Nathan Chancellor
2021-02-04 18:49 ` Nathan Chancellor
2021-02-09 16:40 ` patchwork-bot+linux-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7e601ab-03c0-7b20-9678-3f9f4615836d@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.