Re: [PATCH V1 2/2] xen/device-tree: Add ability to handle nodes with interrupts-extended prop

From: Julien Grall <Julien.Grall@arm.com>
To: Oleksandr <olekstysh@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"sstabellini@kernel.org" <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>, nd <nd@arm.com>
Subject: Re: [PATCH V1 2/2] xen/device-tree: Add ability to handle nodes with interrupts-extended prop
Date: Wed, 29 May 2019 18:18:03 +0000	[thread overview]
Message-ID: <c84036fb-27c9-8fb1-ec3b-f43a8e66515f@arm.com> (raw)
In-Reply-To: <fbb40b64-c23b-be02-2c56-f0e0bf47324b@gmail.com>

On 29/05/2019 18:58, Oleksandr wrote:
> 
> On 29.05.19 20:44, Julien Grall wrote:
>> Hi Oleksandr,
> 
> Hi, Julien
> 
> 
>>
>> On 21/05/2019 18:37, Oleksandr Tyshchenko wrote:
>>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>>
>>> The "interrupts-extended" property is a special form for use when
>>> a node needs to reference multiple interrupt parents. >
>>> According to the:
>>
>> NIT: s/the//
>>
>>> Linux/Documentation/devicetree/bindings/interrupt-controller/interrupts.txt 
>>>
>>>
>>> But, there are cases when "interrupts-extended" property is used for
>>> "outside /soc node" with a single interrupt parent as an equivalent of
>>> pairs ("interrupt-parent" + "interrupts").
>>>
>>> The good example here is ARCH timer node for R-Car Gen3/Gen2 family,
>>
>> NIT: s/The/A/ I think
>>
>>> which is mandatory device for Xen usage on ARM. And without ability
>>> to handle such nodes, Xen fails to operate.
>>>
>>> So, this patch adds required support for Xen to be able to handle
>>> nodes with that property.
>>>
>>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> Thank you! I assume you meant Reviewed-by: Julien Grall 
> <julien.grall@arm.com> )

Yes sorry, I was adding is reviewed-by on some of my patches and 
mechanically copied here. Apologies for the inconvenience.

> 
> Shall I send new version with proposed changes?

No need, I can do the change while committing (assuming Stefano has no 
other comments).

Cheers,

-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel