From: Jens Axboe <axboe@kernel.dk>
To: Kaitao Cheng <pilgrimtao@gmail.com>,
hch@lst.de, sth@linux.ibm.com, viro@zeniv.linux.org.uk,
clm@fb.com, jaegeuk@kernel.org, hch@infradead.org,
mark@fasheh.com, dhowells@redhat.com, balbi@kernel.org
Cc: damien.lemoal@wdc.com, bvanassche@acm.org, ming.lei@redhat.com,
martin.petersen@oracle.com, satyat@google.com,
chaitanya.kulkarni@wdc.com, houtao1@huawei.com,
asml.silence@gmail.com, ajay.joshi@wdc.com,
linux-kernel@vger.kernel.org, songmuchun@bytedance.com,
hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, josef@toxicpanda.com,
dsterba@suse.com, linux-btrfs@vger.kernel.org, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net, darrick.wong@oracle.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
ocfs2-devel@oss.oracle.com, deepa.kernel@gmail.com
Subject: Re: [PATCH v2] blkdev: Replace blksize_bits() with ilog2()
Date: Fri, 29 May 2020 08:13:34 -0600 [thread overview]
Message-ID: <c8412d98-0328-0976-e5f9-5beddc148a35@kernel.dk> (raw)
In-Reply-To: <20200529141100.37519-1-pilgrimtao@gmail.com>
On 5/29/20 8:11 AM, Kaitao Cheng wrote:
> There is a function named ilog2() exist which can replace blksize.
> The generated code will be shorter and more efficient on some
> architecture, such as arm64. And ilog2() can be optimized according
> to different architecture.
When you posted this last time, I said:
"I like the simplification, but do you have any results to back up
that claim? Is the generated code shorter? Runs faster?"
which you handily ignored, yet sending out a new version. I'm not
going to apply this without justification, your commit message is
handwavy at best.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Kaitao Cheng <pilgrimtao@gmail.com>,
hch@lst.de, sth@linux.ibm.com, viro@zeniv.linux.org.uk,
clm@fb.com, jaegeuk@kernel.org, hch@infradead.org,
mark@fasheh.com, dhowells@redhat.com, balbi@kernel.org
Cc: hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
linux-nvme@lists.infradead.org, joseph.qi@linux.alibaba.com,
deepa.kernel@gmail.com, houtao1@huawei.com,
linux-s390@vger.kernel.org, bvanassche@acm.org,
darrick.wong@oracle.com, chaitanya.kulkarni@wdc.com,
satyat@google.com, borntraeger@de.ibm.com, ajay.joshi@wdc.com,
gor@linux.ibm.com, chao@kernel.org, josef@toxicpanda.com,
ming.lei@redhat.com, jlbec@evilplan.org,
songmuchun@bytedance.com, dsterba@suse.com, sagi@grimberg.me,
damien.lemoal@wdc.com, martin.petersen@oracle.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, asml.silence@gmail.com,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] blkdev: Replace blksize_bits() with ilog2()
Date: Fri, 29 May 2020 08:13:34 -0600 [thread overview]
Message-ID: <c8412d98-0328-0976-e5f9-5beddc148a35@kernel.dk> (raw)
In-Reply-To: <20200529141100.37519-1-pilgrimtao@gmail.com>
On 5/29/20 8:11 AM, Kaitao Cheng wrote:
> There is a function named ilog2() exist which can replace blksize.
> The generated code will be shorter and more efficient on some
> architecture, such as arm64. And ilog2() can be optimized according
> to different architecture.
When you posted this last time, I said:
"I like the simplification, but do you have any results to back up
that claim? Is the generated code shorter? Runs faster?"
which you handily ignored, yet sending out a new version. I'm not
going to apply this without justification, your commit message is
handwavy at best.
--
Jens Axboe
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Kaitao Cheng <pilgrimtao@gmail.com>,
hch@lst.de, sth@linux.ibm.com, viro@zeniv.linux.org.uk,
clm@fb.com, jaegeuk@kernel.org, hch@infradead.org,
mark@fasheh.com, dhowells@redhat.com, balbi@kernel.org
Cc: damien.lemoal@wdc.com, bvanassche@acm.org, ming.lei@redhat.com,
martin.petersen@oracle.com, satyat@google.com,
chaitanya.kulkarni@wdc.com, houtao1@huawei.com,
asml.silence@gmail.com, ajay.joshi@wdc.com,
linux-kernel@vger.kernel.org, songmuchun@bytedance.com,
hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, josef@toxicpanda.com,
dsterba@suse.com, linux-btrfs@vger.kernel.org, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net, darrick.wong@oracle.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
ocfs2-devel@oss.oracle.com, deepa.kernel@gmail.com
Subject: [Ocfs2-devel] [PATCH v2] blkdev: Replace blksize_bits() with ilog2()
Date: Fri, 29 May 2020 08:13:34 -0600 [thread overview]
Message-ID: <c8412d98-0328-0976-e5f9-5beddc148a35@kernel.dk> (raw)
In-Reply-To: <20200529141100.37519-1-pilgrimtao@gmail.com>
On 5/29/20 8:11 AM, Kaitao Cheng wrote:
> There is a function named ilog2() exist which can replace blksize.
> The generated code will be shorter and more efficient on some
> architecture, such as arm64. And ilog2() can be optimized according
> to different architecture.
When you posted this last time, I said:
"I like the simplification, but do you have any results to back up
that claim? Is the generated code shorter? Runs faster?"
which you handily ignored, yet sending out a new version. I'm not
going to apply this without justification, your commit message is
handwavy at best.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Kaitao Cheng <pilgrimtao@gmail.com>,
hch@lst.de, sth@linux.ibm.com, viro@zeniv.linux.org.uk,
clm@fb.com, jaegeuk@kernel.org, hch@infradead.org,
mark@fasheh.com, dhowells@redhat.com, balbi@kernel.org
Cc: hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
linux-nvme@lists.infradead.org, joseph.qi@linux.alibaba.com,
deepa.kernel@gmail.com, houtao1@huawei.com,
linux-s390@vger.kernel.org, bvanassche@acm.org,
darrick.wong@oracle.com, chaitanya.kulkarni@wdc.com,
satyat@google.com, borntraeger@de.ibm.com, gor@linux.ibm.com,
josef@toxicpanda.com, ming.lei@redhat.com, jlbec@evilplan.org,
songmuchun@bytedance.com, dsterba@suse.com, sagi@grimberg.me,
damien.lemoal@wdc.com, martin.petersen@oracle.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, asml.silence@gmail.com,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] blkdev: Replace blksize_bits() with ilog2()
Date: Fri, 29 May 2020 08:13:34 -0600 [thread overview]
Message-ID: <c8412d98-0328-0976-e5f9-5beddc148a35@kernel.dk> (raw)
In-Reply-To: <20200529141100.37519-1-pilgrimtao@gmail.com>
On 5/29/20 8:11 AM, Kaitao Cheng wrote:
> There is a function named ilog2() exist which can replace blksize.
> The generated code will be shorter and more efficient on some
> architecture, such as arm64. And ilog2() can be optimized according
> to different architecture.
When you posted this last time, I said:
"I like the simplification, but do you have any results to back up
that claim? Is the generated code shorter? Runs faster?"
which you handily ignored, yet sending out a new version. I'm not
going to apply this without justification, your commit message is
handwavy at best.
--
Jens Axboe
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-05-29 14:13 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 14:11 [PATCH v2] blkdev: Replace blksize_bits() with ilog2() Kaitao Cheng
2020-05-29 14:11 ` [f2fs-dev] " Kaitao Cheng
2020-05-29 14:11 ` [Ocfs2-devel] " Kaitao Cheng
2020-05-29 14:11 ` Kaitao Cheng
2020-05-29 14:13 ` Jens Axboe [this message]
2020-05-29 14:13 ` [f2fs-dev] " Jens Axboe
2020-05-29 14:13 ` [Ocfs2-devel] " Jens Axboe
2020-05-29 14:13 ` Jens Axboe
2020-06-01 7:22 ` Tao pilgrim
2020-06-01 7:22 ` [f2fs-dev] " Tao pilgrim
2020-06-01 7:22 ` [Ocfs2-devel] " Tao pilgrim
2020-06-01 7:22 ` Tao pilgrim
2020-06-01 8:44 ` Greg KH
2020-06-01 8:44 ` [f2fs-dev] " Greg KH
2020-06-01 8:44 ` [Ocfs2-devel] " Greg KH
2020-06-01 8:44 ` Greg KH
2020-06-02 5:51 ` Christoph Hellwig
2020-06-02 5:51 ` [f2fs-dev] " Christoph Hellwig
2020-06-02 5:51 ` [Ocfs2-devel] " Christoph Hellwig
2020-06-02 5:51 ` Christoph Hellwig
2020-06-02 6:13 ` Greg KH
2020-06-02 6:13 ` [f2fs-dev] " Greg KH
2020-06-02 6:13 ` [Ocfs2-devel] " Greg KH
2020-06-02 6:13 ` Greg KH
2020-05-29 14:15 ` Christoph Hellwig
2020-05-29 14:15 ` [f2fs-dev] " Christoph Hellwig
2020-05-29 14:15 ` [Ocfs2-devel] " Christoph Hellwig
2020-05-29 14:15 ` Christoph Hellwig
2020-05-29 20:27 ` Matthew Wilcox
2020-05-29 20:27 ` [f2fs-dev] " Matthew Wilcox
2020-05-29 20:27 ` [Ocfs2-devel] " Matthew Wilcox
2020-05-29 20:27 ` Matthew Wilcox
2020-05-29 22:27 ` Bart Van Assche
2020-05-29 22:27 ` [f2fs-dev] " Bart Van Assche
2020-05-29 22:27 ` [Ocfs2-devel] " Bart Van Assche
2020-05-29 22:27 ` Bart Van Assche
2020-05-29 22:39 ` Jens Axboe
2020-05-29 22:39 ` [f2fs-dev] " Jens Axboe
2020-05-29 22:39 ` [Ocfs2-devel] " Jens Axboe
2020-05-29 22:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8412d98-0328-0976-e5f9-5beddc148a35@kernel.dk \
--to=axboe@kernel.dk \
--cc=ajay.joshi@wdc.com \
--cc=asml.silence@gmail.com \
--cc=balbi@kernel.org \
--cc=borntraeger@de.ibm.com \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=deepa.kernel@gmail.com \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=houtao1@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=jlbec@evilplan.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=pilgrimtao@gmail.com \
--cc=sagi@grimberg.me \
--cc=satyat@google.com \
--cc=songmuchun@bytedance.com \
--cc=sth@linux.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.