From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Jonathan Cormier <jcormier@criticallink.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Jyri Sarha <jsarha@ti.com> Cc: devicetree@vger.kernel.org, Michael Williamson <michael.williamson@criticallink.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Bob Duke <bduke@criticallink.com> Subject: Re: [PATCH 2/4] DRM: BRIDGE: TFP410: Support basic I2C interface Date: Thu, 26 Jan 2023 16:41:47 +0100 [thread overview] Message-ID: <c851113d-c243-c883-f038-3e61a5b8b066@linaro.org> (raw) In-Reply-To: <20230125-tfp410_i2c-v1-2-66a4d4e390b7@criticallink.com> On 25/01/2023 22:09, Jonathan Cormier wrote: > From: Michael Williamson <michael.williamson@criticallink.com> > > The TFP410 driver does not support I2C. As such, the device remains in > Power Down if the I2C is enabled by the bootstrap pins. > > Add basic support for the I2C interface, and provide support to take > the device out of power down when enabled. Also read the bootstrap mode > pins via the CTL_1_MODE register when using the I2C bus. > > Signed-off-by: Michael Williamson <michael.williamson@criticallink.com> > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com> > --- > drivers/gpu/drm/bridge/ti-tfp410.c | 95 +++++++++++++++++++++++++++----------- > 1 file changed, 68 insertions(+), 27 deletions(-) Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). hint: it is entirely different. > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index b9635abbad16..323a6d9ed188 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -6,6 +6,7 @@ > > #include <linux/gpio/consumer.h> > #include <linux/i2c.h> > +#include <linux/regmap.h> > #include <linux/media-bus-format.h> > #include <linux/module.h> > #include <linux/of_graph.h> > @@ -21,6 +22,20 @@ (...) > > static void tfp410_i2c_remove(struct i2c_client *client) > @@ -408,7 +449,7 @@ MODULE_DEVICE_TABLE(i2c, tfp410_i2c_ids); > static struct i2c_driver tfp410_i2c_driver = { > .driver = { > .name = "tfp410", > - .of_match_table = of_match_ptr(tfp410_match), > + .of_match_table = tfp410_match, This does not look related to the patch. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Jonathan Cormier <jcormier@criticallink.com>, Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Jyri Sarha <jsarha@ti.com> Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Williamson <michael.williamson@criticallink.com>, Bob Duke <bduke@criticallink.com> Subject: Re: [PATCH 2/4] DRM: BRIDGE: TFP410: Support basic I2C interface Date: Thu, 26 Jan 2023 16:41:47 +0100 [thread overview] Message-ID: <c851113d-c243-c883-f038-3e61a5b8b066@linaro.org> (raw) In-Reply-To: <20230125-tfp410_i2c-v1-2-66a4d4e390b7@criticallink.com> On 25/01/2023 22:09, Jonathan Cormier wrote: > From: Michael Williamson <michael.williamson@criticallink.com> > > The TFP410 driver does not support I2C. As such, the device remains in > Power Down if the I2C is enabled by the bootstrap pins. > > Add basic support for the I2C interface, and provide support to take > the device out of power down when enabled. Also read the bootstrap mode > pins via the CTL_1_MODE register when using the I2C bus. > > Signed-off-by: Michael Williamson <michael.williamson@criticallink.com> > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com> > --- > drivers/gpu/drm/bridge/ti-tfp410.c | 95 +++++++++++++++++++++++++++----------- > 1 file changed, 68 insertions(+), 27 deletions(-) Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). hint: it is entirely different. > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index b9635abbad16..323a6d9ed188 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -6,6 +6,7 @@ > > #include <linux/gpio/consumer.h> > #include <linux/i2c.h> > +#include <linux/regmap.h> > #include <linux/media-bus-format.h> > #include <linux/module.h> > #include <linux/of_graph.h> > @@ -21,6 +22,20 @@ (...) > > static void tfp410_i2c_remove(struct i2c_client *client) > @@ -408,7 +449,7 @@ MODULE_DEVICE_TABLE(i2c, tfp410_i2c_ids); > static struct i2c_driver tfp410_i2c_driver = { > .driver = { > .name = "tfp410", > - .of_match_table = of_match_ptr(tfp410_match), > + .of_match_table = tfp410_match, This does not look related to the patch. Best regards, Krzysztof
next prev parent reply other threads:[~2023-01-26 15:41 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-25 21:09 [PATCH 0/4] DRM: BRIDGE: TFP410: Add i2c support Jonathan Cormier 2023-01-25 21:09 ` Jonathan Cormier 2023-01-25 21:09 ` [PATCH 1/4] dt-bindings: display: bridge: tfp410: Add tfp410 i2c example Jonathan Cormier 2023-01-25 21:09 ` Jonathan Cormier 2023-01-25 21:24 ` Laurent Pinchart 2023-01-25 21:24 ` Laurent Pinchart 2023-01-25 21:59 ` Jon Cormier 2023-01-25 21:59 ` Jon Cormier 2023-01-26 2:54 ` Rob Herring 2023-01-26 2:54 ` Rob Herring 2023-01-26 15:39 ` Krzysztof Kozlowski 2023-01-26 15:39 ` Krzysztof Kozlowski 2023-01-26 18:36 ` Jon Cormier 2023-01-27 8:30 ` Krzysztof Kozlowski 2023-01-27 8:30 ` Krzysztof Kozlowski 2023-01-25 21:09 ` [PATCH 2/4] DRM: BRIDGE: TFP410: Support basic I2C interface Jonathan Cormier 2023-01-25 21:09 ` Jonathan Cormier 2023-01-26 15:41 ` Krzysztof Kozlowski [this message] 2023-01-26 15:41 ` Krzysztof Kozlowski 2023-01-26 18:45 ` Jon Cormier 2023-01-25 21:09 ` [PATCH 3/4] DRM: BRIDGE: TFP410: Fix logic to configured polled HPD Jonathan Cormier 2023-01-25 21:09 ` Jonathan Cormier 2023-01-25 21:09 ` [PATCH 4/4] DRM: BRIDGE: TFP410: If connected, use I2C for polled HPD status Jonathan Cormier 2023-01-25 21:09 ` Jonathan Cormier 2023-01-28 18:57 ` kernel test robot 2023-01-28 18:57 ` kernel test robot 2023-01-29 0:46 ` kernel test robot 2023-01-29 0:46 ` kernel test robot 2023-01-30 16:24 ` Jon Cormier 2023-01-30 16:24 ` Jon Cormier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c851113d-c243-c883-f038-3e61a5b8b066@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=airlied@gmail.com \ --cc=andrzej.hajda@intel.com \ --cc=bduke@criticallink.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jcormier@criticallink.com \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=jsarha@ti.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michael.williamson@criticallink.com \ --cc=neil.armstrong@linaro.org \ --cc=robert.foss@linaro.org \ --cc=robh+dt@kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.