From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jesse T <mr.bossman075@gmail.com>, Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Vineet Gupta <vgupta@kernel.org>, Brian Cain <bcain@quicinc.com>,
"linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
Greg Ungerer <gerg@linux-m68k.org>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Dinh Nguyen <dinguyen@kernel.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
"linux-openrisc@vger.kernel.org" <linux-openrisc@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Date: Sat, 19 Aug 2023 08:53:25 +0000 [thread overview]
Message-ID: <c96756ed-8714-6e67-c6b1-0614f57d41d0@csgroup.eu> (raw)
In-Reply-To: <CAJFTR8T-Fdu_aKapP+Lb6pLYo_ykXwXw6rFZNGR5=WKU1QwUPQ@mail.gmail.com>
Hi,
Le 19/08/2023 à 05:33, Jesse T a écrit :
>>>
>>>> Should there be a warning here to update change it instead of removal?
>>>
>>> kconfig doesn't have a warning mechanism AFAIK.
>>> Do you have an idea of how this would work?
>
> No, unfortunately. As you said without a warning it would be overlooked so
> a change would not be necessary.
>
> A possible solution is to check in a header file with:
>
> #ifdef CONFIG_EMBEDDED
> #warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT"
> #endif
>
> Does anyone else have an opinion on this?
My opinion is that has happen several times in the past and will happen
again. It is not a big deal, whoever updates to a new kernel will make a
savedefconfig and compare with previous defconfig and see what has
changed. Once you see that CONFIG_EMBEDDED is disappearing you look at
kernel history to find out why CONFIG_EMBEDDED disappears, and you
understand from the commit message that you have to select CONFIG_EXPERT
instead.
A couple examples I have in mind from the past:
- CONFIG_FORCE_MAX_ZONEORDER became CONFIG_ARCH_FORCE_MAX_ORDER
- CONFIG_MTD_NAND became CONFIG_MTD_RAW_NAND
> Since kconfig doesn't have a warning mechanism the patch seems fine as is.
So yes the patch is fine as is IMHO.
Christophe
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jesse T <mr.bossman075@gmail.com>, Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Vineet Gupta <vgupta@kernel.org>, Brian Cain <bcain@quicinc.com>,
"linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
Greg Ungerer <gerg@linux-m68k.org>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Dinh Nguyen <dinguyen@kernel.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
"linux-openrisc@vger.kernel.org" <linux-openrisc@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Date: Sat, 19 Aug 2023 08:53:25 +0000 [thread overview]
Message-ID: <c96756ed-8714-6e67-c6b1-0614f57d41d0@csgroup.eu> (raw)
In-Reply-To: <CAJFTR8T-Fdu_aKapP+Lb6pLYo_ykXwXw6rFZNGR5=WKU1QwUPQ@mail.gmail.com>
Hi,
Le 19/08/2023 à 05:33, Jesse T a écrit :
>>>
>>>> Should there be a warning here to update change it instead of removal?
>>>
>>> kconfig doesn't have a warning mechanism AFAIK.
>>> Do you have an idea of how this would work?
>
> No, unfortunately. As you said without a warning it would be overlooked so
> a change would not be necessary.
>
> A possible solution is to check in a header file with:
>
> #ifdef CONFIG_EMBEDDED
> #warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT"
> #endif
>
> Does anyone else have an opinion on this?
My opinion is that has happen several times in the past and will happen
again. It is not a big deal, whoever updates to a new kernel will make a
savedefconfig and compare with previous defconfig and see what has
changed. Once you see that CONFIG_EMBEDDED is disappearing you look at
kernel history to find out why CONFIG_EMBEDDED disappears, and you
understand from the commit message that you have to select CONFIG_EXPERT
instead.
A couple examples I have in mind from the past:
- CONFIG_FORCE_MAX_ZONEORDER became CONFIG_ARCH_FORCE_MAX_ORDER
- CONFIG_MTD_NAND became CONFIG_MTD_RAW_NAND
> Since kconfig doesn't have a warning mechanism the patch seems fine as is.
So yes the patch is fine as is IMHO.
Christophe
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jesse T <mr.bossman075@gmail.com>, Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Vineet Gupta <vgupta@kernel.org>, Brian Cain <bcain@quicinc.com>,
"linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
Greg Ungerer <gerg@linux-m68k.org>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Dinh Nguyen <dinguyen@kernel.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
"linux-openrisc@vger.kernel.org" <linux-openrisc@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Date: Sat, 19 Aug 2023 08:53:25 +0000 [thread overview]
Message-ID: <c96756ed-8714-6e67-c6b1-0614f57d41d0@csgroup.eu> (raw)
In-Reply-To: <CAJFTR8T-Fdu_aKapP+Lb6pLYo_ykXwXw6rFZNGR5=WKU1QwUPQ@mail.gmail.com>
Hi,
Le 19/08/2023 à 05:33, Jesse T a écrit :
>>>
>>>> Should there be a warning here to update change it instead of removal?
>>>
>>> kconfig doesn't have a warning mechanism AFAIK.
>>> Do you have an idea of how this would work?
>
> No, unfortunately. As you said without a warning it would be overlooked so
> a change would not be necessary.
>
> A possible solution is to check in a header file with:
>
> #ifdef CONFIG_EMBEDDED
> #warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT"
> #endif
>
> Does anyone else have an opinion on this?
My opinion is that has happen several times in the past and will happen
again. It is not a big deal, whoever updates to a new kernel will make a
savedefconfig and compare with previous defconfig and see what has
changed. Once you see that CONFIG_EMBEDDED is disappearing you look at
kernel history to find out why CONFIG_EMBEDDED disappears, and you
understand from the commit message that you have to select CONFIG_EXPERT
instead.
A couple examples I have in mind from the past:
- CONFIG_FORCE_MAX_ZONEORDER became CONFIG_ARCH_FORCE_MAX_ORDER
- CONFIG_MTD_NAND became CONFIG_MTD_RAW_NAND
> Since kconfig doesn't have a warning mechanism the patch seems fine as is.
So yes the patch is fine as is IMHO.
Christophe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jesse T <mr.bossman075@gmail.com>, Randy Dunlap <rdunlap@infradead.org>
Cc: "Jason A . Donenfeld" <Jason@zx2c4.com>,
Rich Felker <dalias@libc.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-openrisc@vger.kernel.org" <linux-openrisc@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Greg Ungerer <gerg@linux-m68k.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Masahiro Yamada <masahiroy@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Vineet Gupta <vgupta@kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Jonas Bonn <jonas@southpole.se>,
Albert Ou <aou@eecs.berkeley.edu>, Arnd Bergmann <arnd@arndb.de>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Nicholas Piggin <npiggin@gmail.com>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> ,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Stafford Horne <shorne@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Brian Cain <bcain@quicinc.com>, Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Max Filippov <jcmvbkbc@gmail.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
"linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Date: Sat, 19 Aug 2023 08:53:25 +0000 [thread overview]
Message-ID: <c96756ed-8714-6e67-c6b1-0614f57d41d0@csgroup.eu> (raw)
In-Reply-To: <CAJFTR8T-Fdu_aKapP+Lb6pLYo_ykXwXw6rFZNGR5=WKU1QwUPQ@mail.gmail.com>
Hi,
Le 19/08/2023 à 05:33, Jesse T a écrit :
>>>
>>>> Should there be a warning here to update change it instead of removal?
>>>
>>> kconfig doesn't have a warning mechanism AFAIK.
>>> Do you have an idea of how this would work?
>
> No, unfortunately. As you said without a warning it would be overlooked so
> a change would not be necessary.
>
> A possible solution is to check in a header file with:
>
> #ifdef CONFIG_EMBEDDED
> #warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT"
> #endif
>
> Does anyone else have an opinion on this?
My opinion is that has happen several times in the past and will happen
again. It is not a big deal, whoever updates to a new kernel will make a
savedefconfig and compare with previous defconfig and see what has
changed. Once you see that CONFIG_EMBEDDED is disappearing you look at
kernel history to find out why CONFIG_EMBEDDED disappears, and you
understand from the commit message that you have to select CONFIG_EXPERT
instead.
A couple examples I have in mind from the past:
- CONFIG_FORCE_MAX_ZONEORDER became CONFIG_ARCH_FORCE_MAX_ORDER
- CONFIG_MTD_NAND became CONFIG_MTD_RAW_NAND
> Since kconfig doesn't have a warning mechanism the patch seems fine as is.
So yes the patch is fine as is IMHO.
Christophe
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jesse T <mr.bossman075@gmail.com>, Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Vineet Gupta <vgupta@kernel.org>, Brian Cain <bcain@quicinc.com>,
"linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
Greg Ungerer <gerg@linux-m68k.org>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Dinh Nguyen <dinguyen@kernel.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
"linux-openrisc@vger.kernel.org" <linux-openrisc@vger.kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Max Filippov <jcmvbkbc@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Date: Sat, 19 Aug 2023 08:53:25 +0000 [thread overview]
Message-ID: <c96756ed-8714-6e67-c6b1-0614f57d41d0@csgroup.eu> (raw)
In-Reply-To: <CAJFTR8T-Fdu_aKapP+Lb6pLYo_ykXwXw6rFZNGR5=WKU1QwUPQ@mail.gmail.com>
Hi,
Le 19/08/2023 à 05:33, Jesse T a écrit :
>>>
>>>> Should there be a warning here to update change it instead of removal?
>>>
>>> kconfig doesn't have a warning mechanism AFAIK.
>>> Do you have an idea of how this would work?
>
> No, unfortunately. As you said without a warning it would be overlooked so
> a change would not be necessary.
>
> A possible solution is to check in a header file with:
>
> #ifdef CONFIG_EMBEDDED
> #warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT"
> #endif
>
> Does anyone else have an opinion on this?
My opinion is that has happen several times in the past and will happen
again. It is not a big deal, whoever updates to a new kernel will make a
savedefconfig and compare with previous defconfig and see what has
changed. Once you see that CONFIG_EMBEDDED is disappearing you look at
kernel history to find out why CONFIG_EMBEDDED disappears, and you
understand from the commit message that you have to select CONFIG_EXPERT
instead.
A couple examples I have in mind from the past:
- CONFIG_FORCE_MAX_ZONEORDER became CONFIG_ARCH_FORCE_MAX_ORDER
- CONFIG_MTD_NAND became CONFIG_MTD_RAW_NAND
> Since kconfig doesn't have a warning mechanism the patch seems fine as is.
So yes the patch is fine as is IMHO.
Christophe
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Jesse T <mr.bossman075@gmail.com>, Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
"wireguard@lists.zx2c4.com" <wireguard@lists.zx2c4.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Vineet Gupta <vgupta@kernel.org>, Brian Cain <bcain@quicinc.com>,
"linux-hexagon@vger.kernel.org" <linux-hexagon@vger.kernel.org>,
Greg Ungerer <gerg@linux-m68k.org>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Dinh Nguyen <dinguyen@kernel.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Subject: Re: [PATCH] treewide: drop CONFIG_EMBEDDED
Date: Sat, 19 Aug 2023 08:53:25 +0000 [thread overview]
Message-ID: <c96756ed-8714-6e67-c6b1-0614f57d41d0@csgroup.eu> (raw)
In-Reply-To: <CAJFTR8T-Fdu_aKapP+Lb6pLYo_ykXwXw6rFZNGR5=WKU1QwUPQ@mail.gmail.com>
Hi,
Le 19/08/2023 à 05:33, Jesse T a écrit :
>>>
>>>> Should there be a warning here to update change it instead of removal?
>>>
>>> kconfig doesn't have a warning mechanism AFAIK.
>>> Do you have an idea of how this would work?
>
> No, unfortunately. As you said without a warning it would be overlooked so
> a change would not be necessary.
>
> A possible solution is to check in a header file with:
>
> #ifdef CONFIG_EMBEDDED
> #warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT"
> #endif
>
> Does anyone else have an opinion on this?
My opinion is that has happen several times in the past and will happen
again. It is not a big deal, whoever updates to a new kernel will make a
savedefconfig and compare with previous defconfig and see what has
changed. Once you see that CONFIG_EMBEDDED is disappearing you look at
kernel history to find out why CONFIG_EMBEDDED disappears, and you
understand from the commit message that you have to select CONFIG_EXPERT
instead.
A couple examples I have in mind from the past:
- CONFIG_FORCE_MAX_ZONEORDER became CONFIG_ARCH_FORCE_MAX_ORDER
- CONFIG_MTD_NAND became CONFIG_MTD_RAW_NAND
> Since kconfig doesn't have a warning mechanism the patch seems fine as is.
So yes the patch is fine as is IMHO.
Christophe
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-08-19 8:53 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 22:45 [PATCH] treewide: drop CONFIG_EMBEDDED Jesse Taube
2023-08-16 22:45 ` Jesse Taube
2023-08-16 22:45 ` Jesse Taube
2023-08-16 22:45 ` Jesse Taube
2023-08-17 3:15 ` Randy Dunlap
2023-08-17 3:15 ` Randy Dunlap
2023-08-17 3:15 ` Randy Dunlap
2023-08-17 3:15 ` Randy Dunlap
2023-08-17 3:15 ` Randy Dunlap
2023-08-17 3:15 ` Randy Dunlap
2023-08-18 23:44 ` Randy Dunlap
2023-08-18 23:44 ` Randy Dunlap
2023-08-18 23:44 ` Randy Dunlap
2023-08-18 23:44 ` Randy Dunlap
2023-08-18 23:44 ` Randy Dunlap
2023-08-18 23:44 ` Randy Dunlap
2023-08-19 3:33 ` Jesse T
2023-08-19 3:33 ` Jesse T
2023-08-19 3:33 ` Jesse T
2023-08-19 3:33 ` Jesse T
2023-08-19 3:33 ` Jesse T
2023-08-19 3:33 ` Jesse T
2023-08-19 8:53 ` Christophe Leroy [this message]
2023-08-19 8:53 ` Christophe Leroy
2023-08-19 8:53 ` Christophe Leroy
2023-08-19 8:53 ` Christophe Leroy
2023-08-19 8:53 ` Christophe Leroy
2023-08-19 8:53 ` Christophe Leroy
-- strict thread matches above, loose matches on Subject: below --
2023-08-16 5:50 Randy Dunlap
2023-08-16 5:50 ` Randy Dunlap
2023-08-16 5:50 ` Randy Dunlap
2023-08-16 5:50 ` Randy Dunlap
2023-08-16 5:50 ` Randy Dunlap
2023-08-16 5:50 ` Randy Dunlap
2023-08-16 7:41 ` Geert Uytterhoeven
2023-08-16 7:41 ` Geert Uytterhoeven
2023-08-16 7:41 ` Geert Uytterhoeven
2023-08-16 7:41 ` Geert Uytterhoeven
2023-08-16 7:41 ` Geert Uytterhoeven
2023-08-16 7:41 ` Geert Uytterhoeven
2023-08-16 13:11 ` Arnd Bergmann
2023-08-16 13:11 ` Arnd Bergmann
2023-08-16 13:11 ` Arnd Bergmann
2023-08-16 13:11 ` Arnd Bergmann
2023-08-16 13:11 ` Arnd Bergmann
2023-08-16 13:11 ` Arnd Bergmann
2023-08-16 14:32 ` Palmer Dabbelt
2023-08-16 14:32 ` Palmer Dabbelt
2023-08-16 14:32 ` Palmer Dabbelt
2023-08-16 14:32 ` Palmer Dabbelt
2023-08-16 14:32 ` Palmer Dabbelt
2023-08-16 14:32 ` Palmer Dabbelt
2023-08-16 22:11 ` Greg Ungerer
2023-08-16 22:11 ` Greg Ungerer
2023-08-16 22:11 ` Greg Ungerer
2023-08-16 22:11 ` Greg Ungerer
2023-08-16 22:11 ` Greg Ungerer
2023-08-16 22:11 ` Greg Ungerer
2023-08-16 22:58 ` Jason A. Donenfeld
2023-08-16 22:58 ` Jason A. Donenfeld
2023-08-16 22:58 ` Jason A. Donenfeld
2023-08-16 22:58 ` Jason A. Donenfeld
2023-08-16 22:58 ` Jason A. Donenfeld
2023-08-16 22:58 ` Jason A. Donenfeld
2023-08-17 4:38 ` Michael Ellerman
2023-08-17 4:38 ` Michael Ellerman
2023-08-17 4:38 ` Michael Ellerman
2023-08-17 4:38 ` Michael Ellerman
2023-08-17 4:38 ` Michael Ellerman
2023-08-17 4:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c96756ed-8714-6e67-c6b1-0614f57d41d0@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bcain@quicinc.com \
--cc=dalias@libc.org \
--cc=dinguyen@kernel.org \
--cc=gerg@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=josh@joshtriplett.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-openrisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=mr.bossman075@gmail.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rdunlap@infradead.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=wireguard@lists.zx2c4.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.