From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [PATCH 21/35] ASoC: Intel: Expose ACPI loading members
Date: Sat, 24 Aug 2019 11:58:33 +0200 [thread overview]
Message-ID: <c9c7b4a2-b50a-697e-e4f3-8c5426a7f2d7@intel.com> (raw)
In-Reply-To: <30929d7b-787d-3b6e-d806-02487b85ab8d@linux.intel.com>
On 2019-08-23 21:32, Pierre-Louis Bossart wrote:
>
>> diff --git a/sound/soc/intel/common/sst-dsp.h
>> b/sound/soc/intel/common/sst-dsp.h
>> index 63c29bb45cf1..a2ac7998fbdb 100644
>> --- a/sound/soc/intel/common/sst-dsp.h
>> +++ b/sound/soc/intel/common/sst-dsp.h
>> @@ -166,6 +166,27 @@
>> #define SST_PMCS_PS_MASK 0x3
>> struct sst_dsp;
>> +struct platform_device;
>
> that should be handled with an include, not redefining a type here.
>
Ack.
>> +
>> +/* Descriptor for setting up SST platform data */
>> +struct sst_acpi_desc {
>> + const char *drv_name;
>> + struct snd_soc_acpi_mach *machines;
>> + /* Platform resource indexes. Must set to -1 if not used */
>> + int resindex_lpe_base;
>> + int resindex_pcicfg_base;
>> + int resindex_fw_base;
>> + int irqindex_host_ipc;
>> + int resindex_dma_base;
>> + /* Unique number identifying the SST core on platform */
>> + int sst_id;
>> + /* DMA only valid when resindex_dma_base != -1*/
>> + int dma_engine;
>> + int dma_size;
>> +};
>> +
>> +int sst_acpi_probe(struct platform_device *pdev);
>> +int sst_acpi_remove(struct platform_device *pdev);
>> /*
>> * SST Platform Data.
>>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-08-24 9:58 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 19:03 [PATCH 00/35] ASoC: Intel: Clenaup SST initialization Cezary Rojewski
2019-08-22 19:03 ` [PATCH 01/35] ASoC: Intel: Skylake: Put FW runtime params defs in one place Cezary Rojewski
2019-08-22 19:03 ` [PATCH 02/35] ASoC: Intel: Skylake: Add FIRMWARE_CONFIG IPC request Cezary Rojewski
2019-08-23 18:24 ` Pierre-Louis Bossart
2019-08-24 9:17 ` Cezary Rojewski
2019-08-26 16:27 ` Pierre-Louis Bossart
2019-08-26 19:34 ` Cezary Rojewski
2019-08-22 19:03 ` [PATCH 03/35] ASoC: Intel: Skylake: Add HARDWARE_CONFIG " Cezary Rojewski
2019-08-23 18:32 ` Pierre-Louis Bossart
2019-08-24 9:30 ` Cezary Rojewski
2019-08-22 19:03 ` [PATCH 04/35] ASoC: Intel: Skylake: Unify firmware loading mechanism Cezary Rojewski
2019-08-23 18:40 ` Pierre-Louis Bossart
2019-08-24 9:34 ` Cezary Rojewski
2019-08-26 16:31 ` Pierre-Louis Bossart
2019-08-26 19:50 ` Cezary Rojewski
2019-08-22 19:03 ` [PATCH 05/35] ASoC: Intel: Skylake: Reload libraries on D0 entry for CNL Cezary Rojewski
2019-08-22 19:03 ` [PATCH 06/35] ASoC: Intel: Skylake: Unhardcode dsp cores number Cezary Rojewski
2019-08-22 19:03 ` [PATCH 07/35] ASoC: Intel: Skylake: Update interrupt disabling routine Cezary Rojewski
2019-08-22 19:03 ` [PATCH 08/35] ASoC: Intel: Skylake: Inline ipc free operations Cezary Rojewski
2019-08-22 19:03 ` [PATCH 09/35] ASoC: Intel: Skylake: Unify driver cleanup mechanism Cezary Rojewski
2019-08-22 19:04 ` [PATCH 10/35] ASoC: Intel: Relocate irq thread header to sst_ops Cezary Rojewski
2019-08-22 19:04 ` [PATCH 11/35] ASoC: Intel: Merge sst_dsp_device into sst_pdata Cezary Rojewski
2019-08-23 18:54 ` Pierre-Louis Bossart
2019-08-24 10:52 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 12/35] ASoC: Intel: Skylake: Reuse sst_dsp_free Cezary Rojewski
2019-08-23 19:07 ` Pierre-Louis Bossart
2019-08-24 9:35 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 13/35] ASoC: Intel: Skylake: Reuse sst_dsp_new Cezary Rojewski
2019-08-23 19:09 ` Pierre-Louis Bossart
2019-08-24 9:37 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 14/35] ASoC: Intel: Skylake: Remove skl_dsp_acquire_irq Cezary Rojewski
2019-08-22 19:04 ` [PATCH 15/35] ASoC: Intel: Skylake: Use dsp loading functions directly Cezary Rojewski
2019-08-23 19:17 ` Pierre-Louis Bossart
2019-08-24 9:41 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 16/35] ASoC: Intel: Skylake: Make dsp_ops::stream_tag obsolete Cezary Rojewski
2019-08-22 19:04 ` [PATCH 17/35] ASoC: Intel: Skylake: Remove skl_dsp_loader_ops Cezary Rojewski
2019-08-23 19:21 ` Pierre-Louis Bossart
2019-08-24 9:49 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 18/35] ASoC: Intel: Skylake: Remove window0 sst_addr fields Cezary Rojewski
2019-08-23 19:26 ` Pierre-Louis Bossart
2019-08-24 9:57 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 19/35] ASoC: Intel: Skylake: Remove redundant W0 and W1 macros Cezary Rojewski
2019-08-23 19:28 ` Pierre-Louis Bossart
2019-08-24 11:52 ` Cezary Rojewski
2019-08-24 12:04 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 20/35] ASoC: Intel: Skylake: Remove redundant SRAM fields Cezary Rojewski
2019-08-22 19:04 ` [PATCH 21/35] ASoC: Intel: Expose ACPI loading members Cezary Rojewski
2019-08-23 19:32 ` Pierre-Louis Bossart
2019-08-24 9:58 ` Cezary Rojewski [this message]
2019-08-22 19:04 ` [PATCH 22/35] ASoC: Intel: Haswell: Define separate ACPI loader Cezary Rojewski
2019-08-23 19:35 ` Pierre-Louis Bossart
2019-08-24 9:59 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 23/35] ASoC: Intel: Baytrail: " Cezary Rojewski
2019-08-23 19:36 ` Pierre-Louis Bossart
2019-08-22 19:04 ` [PATCH 24/35] ASoC: Intel: Refactor probing of ACPI devices Cezary Rojewski
2019-08-23 19:43 ` Pierre-Louis Bossart
2019-08-24 10:16 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 25/35] ASoC: Intel: Skylake: Simplify skl_sst_ctx_init declaration Cezary Rojewski
2019-08-22 19:04 ` [PATCH 26/35] ASoC: Intel: Skylake: Simplify all sst_dsp_init declarations Cezary Rojewski
2019-08-22 19:04 ` [PATCH 27/35] ASoC: Intel: Skylake: Define platform descriptors Cezary Rojewski
2019-08-23 19:50 ` Pierre-Louis Bossart
2019-08-24 10:51 ` Cezary Rojewski
2019-08-26 17:13 ` Pierre-Louis Bossart
2019-08-26 19:18 ` Cezary Rojewski
2019-08-26 21:53 ` Pierre-Louis Bossart
2019-08-22 19:04 ` [PATCH 28/35] ASoC: Intel: Skylake: Update skl_ids table Cezary Rojewski
2019-08-23 20:15 ` Pierre-Louis Bossart
2019-08-22 19:04 ` [PATCH 29/35] ASoC: Intel: Skylake: Flip SST initialization order Cezary Rojewski
2019-08-23 20:18 ` Pierre-Louis Bossart
2019-08-24 10:54 ` Cezary Rojewski
2019-08-26 16:39 ` Pierre-Louis Bossart
2019-08-26 20:03 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 30/35] ASoC: Intel: Reuse sst_pdata::fw_name field Cezary Rojewski
2019-08-23 20:20 ` Pierre-Louis Bossart
2019-08-24 10:57 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 31/35] ASoC: Intel: Reuse sst_pdata::fw field Cezary Rojewski
2019-08-22 19:04 ` [PATCH 32/35] ASoC: Intel: Skylake: Remove skl_dsp_ops Cezary Rojewski
2019-08-22 19:04 ` [PATCH 33/35] ASoC: Intel: Skylake: Privatize SST init handlers Cezary Rojewski
2019-08-23 20:25 ` Pierre-Louis Bossart
2019-08-24 11:01 ` Cezary Rojewski
2019-08-22 19:04 ` [PATCH 34/35] ASoC: Intel: Skylake: Merge skl_sst_ctx_init into skl_init_dsp Cezary Rojewski
2019-08-22 19:04 ` [PATCH 35/35] ASoC: Intel: Remove obsolete firmware fields Cezary Rojewski
2019-08-23 20:27 ` Pierre-Louis Bossart
2019-08-24 11:02 ` Cezary Rojewski
2019-08-22 20:55 ` [PATCH 00/35] ASoC: Intel: Clenaup SST initialization Pierre-Louis Bossart
2019-08-23 8:29 ` Cezary Rojewski
2019-08-23 10:26 ` Mark Brown
2019-08-23 10:43 ` Cezary Rojewski
2019-08-23 16:26 ` Pierre-Louis Bossart
2019-08-23 18:44 ` Cezary Rojewski
2019-08-23 20:12 ` Pierre-Louis Bossart
2019-08-23 21:39 ` Mark Brown
2019-08-24 13:51 ` Cezary Rojewski
2019-08-25 11:06 ` Cezary Rojewski
2019-08-26 7:24 ` Wasko, Michal
2019-08-26 16:51 ` Pierre-Louis Bossart
2019-08-26 20:08 ` Cezary Rojewski
2019-08-26 21:57 ` Pierre-Louis Bossart
2019-08-27 8:33 ` Wasko, Michal
2019-08-27 13:52 ` Pierre-Louis Bossart
2019-08-27 14:58 ` Cezary Rojewski
2019-08-27 15:00 ` Pierre-Louis Bossart
2019-08-27 15:08 ` Cezary Rojewski
2019-08-27 17:18 ` Pierre-Louis Bossart
2019-08-27 18:13 ` Cezary Rojewski
2019-08-27 19:20 ` Mark Brown
2019-08-27 19:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c7b4a2-b50a-697e-e4f3-8c5426a7f2d7@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.