From: Jon Hunter <jonathanh@nvidia.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH 5/8] ASoC: tegra: set edge mode for TDM correctly
Date: Wed, 18 Sep 2019 09:54:35 +0100 [thread overview]
Message-ID: <c9d2b321-b344-f5db-f2cb-c213bb5894a6@nvidia.com> (raw)
In-Reply-To: <20190917181233.534-6-ben.dooks@codethink.co.uk>
On 17/09/2019 19:12, Ben Dooks wrote:
> In TDM, use the negative edge to drive data and the positive edge to sample
> data.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> sound/soc/tegra/tegra30_i2s.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c
> index 4222839b63bd..d75ce12fe177 100644
> --- a/sound/soc/tegra/tegra30_i2s.c
> +++ b/sound/soc/tegra/tegra30_i2s.c
> @@ -117,6 +117,8 @@ static int tegra30_i2s_set_fmt(struct snd_soc_dai *dai,
> }
>
> pm_runtime_get_sync(dai->dev);
> + regmap_update_bits(i2s->regmap, TEGRA30_I2S_CH_CTRL_EGDE_CTRL_MASK,
> + i2s->is_tdm ? TEGRA30_I2S_CH_CTRL_EGDE_CTRL_NEG_EDGE : 0);
> regmap_update_bits(i2s->regmap, TEGRA30_I2S_CTRL, mask, val);
> pm_runtime_put(dai->dev);
I would rather set this in the case statement above where the format is
parsed and again drop this 'is_tdm' variable.
Jon
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Jon Hunter <jonathanh@nvidia.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
<linux-tegra@vger.kernel.org>, <alsa-devel@alsa-project.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@lists.codethink.co.uk
Subject: Re: [alsa-devel] [PATCH 5/8] ASoC: tegra: set edge mode for TDM correctly
Date: Wed, 18 Sep 2019 09:54:35 +0100 [thread overview]
Message-ID: <c9d2b321-b344-f5db-f2cb-c213bb5894a6@nvidia.com> (raw)
In-Reply-To: <20190917181233.534-6-ben.dooks@codethink.co.uk>
On 17/09/2019 19:12, Ben Dooks wrote:
> In TDM, use the negative edge to drive data and the positive edge to sample
> data.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> sound/soc/tegra/tegra30_i2s.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c
> index 4222839b63bd..d75ce12fe177 100644
> --- a/sound/soc/tegra/tegra30_i2s.c
> +++ b/sound/soc/tegra/tegra30_i2s.c
> @@ -117,6 +117,8 @@ static int tegra30_i2s_set_fmt(struct snd_soc_dai *dai,
> }
>
> pm_runtime_get_sync(dai->dev);
> + regmap_update_bits(i2s->regmap, TEGRA30_I2S_CH_CTRL_EGDE_CTRL_MASK,
> + i2s->is_tdm ? TEGRA30_I2S_CH_CTRL_EGDE_CTRL_NEG_EDGE : 0);
> regmap_update_bits(i2s->regmap, TEGRA30_I2S_CTRL, mask, val);
> pm_runtime_put(dai->dev);
I would rather set this in the case statement above where the format is
parsed and again drop this 'is_tdm' variable.
Jon
--
nvpublic
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-18 8:54 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 18:12 RFC: TDM mode support on the tegra30 Ben Dooks
2019-09-17 18:12 ` [alsa-devel] " Ben Dooks
2019-09-17 18:12 ` [PATCH 1/8] ASoC: tegra: Add a TDM configuration callback Ben Dooks
2019-09-17 18:12 ` [alsa-devel] " Ben Dooks
2019-09-17 18:22 ` Pierre-Louis Bossart
2019-09-17 18:22 ` [alsa-devel] " Pierre-Louis Bossart
2019-09-18 8:42 ` Jon Hunter
2019-09-18 8:42 ` [alsa-devel] " Jon Hunter
2019-09-18 10:11 ` Ben Dooks
2019-09-18 10:11 ` [alsa-devel] " Ben Dooks
2019-09-18 10:25 ` Jon Hunter
2019-09-18 10:25 ` [alsa-devel] " Jon Hunter
2019-09-18 10:48 ` Mark Brown
2019-09-18 10:48 ` [alsa-devel] " Mark Brown
2019-09-18 11:44 ` Ben Dooks
2019-09-18 11:44 ` [alsa-devel] " Ben Dooks
2019-09-18 13:33 ` Pierre-Louis Bossart
2019-09-18 13:33 ` [alsa-devel] " Pierre-Louis Bossart
2019-09-18 15:02 ` Mark Brown
2019-09-18 15:02 ` [alsa-devel] " Mark Brown
2019-09-17 18:12 ` [PATCH 2/8] ASoC: tegra: Allow 24bit and 32bit samples Ben Dooks
2019-09-17 18:12 ` [alsa-devel] " Ben Dooks
2019-09-17 18:26 ` Pierre-Louis Bossart
2019-09-17 18:26 ` [alsa-devel] " Pierre-Louis Bossart
2019-09-18 7:44 ` Ben Dooks
2019-09-18 7:44 ` [alsa-devel] " Ben Dooks
2019-09-18 10:08 ` Mark Brown
2019-09-18 10:08 ` [alsa-devel] " Mark Brown
2019-09-18 11:50 ` Ben Dooks
2019-09-18 11:50 ` [alsa-devel] " Ben Dooks
2019-09-18 12:05 ` Mark Brown
2019-09-18 12:05 ` [alsa-devel] " Mark Brown
2019-09-17 18:12 ` [PATCH 3/8] ASoC: tegra: i2s: Add support for more than 2 channels Ben Dooks
2019-09-17 18:12 ` [alsa-devel] " Ben Dooks
2019-09-18 8:50 ` Jon Hunter
2019-09-18 8:50 ` [alsa-devel] " Jon Hunter
2019-09-18 10:12 ` Ben Dooks
2019-09-18 10:12 ` [alsa-devel] " Ben Dooks
2019-09-17 18:12 ` [PATCH 4/8] ASoC: tegra: disable rx_fifo after disable stream Ben Dooks
2019-09-17 18:12 ` [alsa-devel] " Ben Dooks
2019-09-17 18:12 ` [PATCH 5/8] ASoC: tegra: set edge mode for TDM correctly Ben Dooks
2019-09-17 18:12 ` [alsa-devel] " Ben Dooks
2019-09-17 19:33 ` kbuild test robot
2019-09-17 19:33 ` [alsa-devel] " kbuild test robot
2019-09-18 8:54 ` Jon Hunter [this message]
2019-09-18 8:54 ` Jon Hunter
2019-09-18 9:02 ` Jon Hunter
2019-09-18 9:02 ` [alsa-devel] " Jon Hunter
2019-09-18 10:15 ` Ben Dooks
2019-09-18 10:15 ` [alsa-devel] " Ben Dooks
2019-09-17 18:12 ` [PATCH 6/8] ASoC: tegra: set i2s_offset to 0 for tdm Ben Dooks
2019-09-17 18:12 ` [alsa-devel] " Ben Dooks
2019-09-18 9:02 ` Jon Hunter
2019-09-18 9:02 ` [alsa-devel] " Jon Hunter
2019-09-18 11:30 ` Ben Dooks
2019-09-18 11:30 ` [alsa-devel] " Ben Dooks
2019-09-17 18:12 ` [PATCH 7/8] ASoC: tegra: config fifos on hw_param changes Ben Dooks
2019-09-17 18:12 ` [alsa-devel] " Ben Dooks
2019-09-18 9:14 ` Jon Hunter
2019-09-18 9:14 ` [alsa-devel] " Jon Hunter
2019-09-18 11:41 ` Ben Dooks
2019-09-18 11:41 ` [alsa-devel] " Ben Dooks
2019-09-17 18:12 ` [PATCH 8/8] ASoC: tegra: take packing settings from the audio cif_config Ben Dooks
2019-09-17 18:12 ` [alsa-devel] " Ben Dooks
2019-09-18 9:16 ` Jon Hunter
2019-09-18 9:16 ` [alsa-devel] " Jon Hunter
2019-09-18 10:02 ` Sameer Pujar
2019-09-18 10:02 ` [alsa-devel] " Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9d2b321-b344-f5db-f2cb-c213bb5894a6@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben.dooks@codethink.co.uk \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.