Re: [PATCH 6/6] drm/i915: Fix up verify_encoder_state

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 6/6] drm/i915: Fix up verify_encoder_state
Date: Wed, 8 Mar 2017 10:37:09 +0100	[thread overview]
Message-ID: <ca3b0c26-4ed3-5814-6968-2932c5eb3db8@linux.intel.com> (raw)
In-Reply-To: <20170301095226.30584-6-daniel.vetter@ffwll.ch>

Op 01-03-17 om 10:52 schreef Daniel Vetter:
> The trouble here is that looking at all connector->state in the
> verifier isn't good, because that's run from the commit work, which
> doesn't hold the connection_mutex. Which means we're only allowed to
> look at states in our atomic update.
>
> The simple fix for future proofing would be to switch over to
> drm_for_each_connector_in_state, but that has the problem that the
> verification then fails if not all connectors are in the state. And we
> also need to be careful to check both old and new encoders, and not
> screw things up when an encoder gets reassigned.
>
> Note that this isn't the full fix, since we still look at
> connector->state. To fix that, we need Maarten's patch series to
> switch over to state pointers within drm_atomic_state, but that's a
> different series.
>
> v2: Use oldnew iterator (Maarten).
>
> v3: Rebase onto the iter_get/put->iter_begin/end rename.
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx