From: Hector Martin <marcan@marcan.st> To: Viresh Kumar <viresh.kumar@linaro.org>, Sibi Sankar <sibis@codeaurora.org>, Saravana Kannan <saravanak@google.com> Cc: linux-arm-kernel@lists.infradead.org, Alyssa Rosenzweig <alyssa@rosenzweig.io>, Sven Peter <sven@svenpeter.dev>, Marc Zyngier <maz@kernel.org>, Mark Kettenis <mark.kettenis@xs4all.nl>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>, Catalin Marinas <catalin.marinas@arm.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist Date: Tue, 12 Oct 2021 14:57:50 +0900 [thread overview] Message-ID: <caf16a6c-f127-7f27-ed17-0522d9f1fb9e@marcan.st> (raw) In-Reply-To: <20211012055143.xmkbvhbnolspgjin@vireshk-i7> On 12/10/2021 14.51, Viresh Kumar wrote: > On 12-10-21, 14:34, Hector Martin wrote: >> The table *is* assigned to a genpd (the memory controller), it's just that >> that genpd isn't actually a parent of the CPU device. Without the patch you >> end up with: >> >> [ 3.040060] cpu cpu4: Failed to set performance rate of cpu4: 0 (-19) >> [ 3.042881] cpu cpu4: Failed to set required opps: -19 >> [ 3.045508] cpufreq: __target_index: Failed to change cpu frequency: -19 > > Hmm, Saravana and Sibi were working on a similar problem earlier and decided to > solve this using devfreq instead. Don't remember the exact series which got > merged for this, Sibi ? > > If this part fails, how do you actually set the performance state of the memory > controller's genpd ? The clock controller has the genpd as an actual power-domain parent, so it does it instead. From patch #7: > + if (cluster->has_pd) > + dev_pm_genpd_set_performance_state(cluster->dev, > + dev_pm_opp_get_required_pstate(opp, 0)); > + This is arguably not entirely representative of how the hardware works, since technically the cluster switching couldn't care less what the memory controller is doing; it's a soft dependency, states that should be switched together but are not interdependent (in fact, the clock code does this unconditionally after the CPU p-state change, regardless of whether we're shifting up or down; this is, FWIW, the same order macOS uses, and it clearly doesn't matter which way you do it). -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub
WARNING: multiple messages have this Message-ID (diff)
From: Hector Martin <marcan@marcan.st> To: Viresh Kumar <viresh.kumar@linaro.org>, Sibi Sankar <sibis@codeaurora.org>, Saravana Kannan <saravanak@google.com> Cc: linux-arm-kernel@lists.infradead.org, Alyssa Rosenzweig <alyssa@rosenzweig.io>, Sven Peter <sven@svenpeter.dev>, Marc Zyngier <maz@kernel.org>, Mark Kettenis <mark.kettenis@xs4all.nl>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>, Catalin Marinas <catalin.marinas@arm.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist Date: Tue, 12 Oct 2021 14:57:50 +0900 [thread overview] Message-ID: <caf16a6c-f127-7f27-ed17-0522d9f1fb9e@marcan.st> (raw) In-Reply-To: <20211012055143.xmkbvhbnolspgjin@vireshk-i7> On 12/10/2021 14.51, Viresh Kumar wrote: > On 12-10-21, 14:34, Hector Martin wrote: >> The table *is* assigned to a genpd (the memory controller), it's just that >> that genpd isn't actually a parent of the CPU device. Without the patch you >> end up with: >> >> [ 3.040060] cpu cpu4: Failed to set performance rate of cpu4: 0 (-19) >> [ 3.042881] cpu cpu4: Failed to set required opps: -19 >> [ 3.045508] cpufreq: __target_index: Failed to change cpu frequency: -19 > > Hmm, Saravana and Sibi were working on a similar problem earlier and decided to > solve this using devfreq instead. Don't remember the exact series which got > merged for this, Sibi ? > > If this part fails, how do you actually set the performance state of the memory > controller's genpd ? The clock controller has the genpd as an actual power-domain parent, so it does it instead. From patch #7: > + if (cluster->has_pd) > + dev_pm_genpd_set_performance_state(cluster->dev, > + dev_pm_opp_get_required_pstate(opp, 0)); > + This is arguably not entirely representative of how the hardware works, since technically the cluster switching couldn't care less what the memory controller is doing; it's a soft dependency, states that should be switched together but are not interdependent (in fact, the clock code does this unconditionally after the CPU p-state change, regardless of whether we're shifting up or down; this is, FWIW, the same order macOS uses, and it clearly doesn't matter which way you do it). -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-12 5:58 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-11 16:56 [RFC PATCH 0/9] Apple SoC CPU P-state switching Hector Martin 2021-10-11 16:56 ` Hector Martin 2021-10-11 16:56 ` [RFC PATCH 1/9] MAINTAINERS: apple: Add apple-mcc and clk-apple-cluster paths Hector Martin 2021-10-11 16:56 ` Hector Martin 2021-10-11 16:57 ` [RFC PATCH 2/9] dt-bindings: memory-controller: Add apple,mcc binding Hector Martin 2021-10-11 16:57 ` [RFC PATCH 2/9] dt-bindings: memory-controller: Add apple, mcc binding Hector Martin 2021-10-12 8:48 ` [RFC PATCH 2/9] dt-bindings: memory-controller: Add apple,mcc binding Krzysztof Kozlowski 2021-10-12 8:48 ` Krzysztof Kozlowski 2021-10-19 22:43 ` Rob Herring 2021-10-19 22:43 ` Rob Herring 2021-10-11 16:57 ` [RFC PATCH 3/9] dt-bindings: clock: Add apple,cluster-clk binding Hector Martin 2021-10-11 16:57 ` Hector Martin 2021-10-12 8:51 ` Krzysztof Kozlowski 2021-10-12 8:51 ` [RFC PATCH 3/9] dt-bindings: clock: Add apple, cluster-clk binding Krzysztof Kozlowski 2021-10-12 9:35 ` [RFC PATCH 3/9] dt-bindings: clock: Add apple,cluster-clk binding Viresh Kumar 2021-10-12 9:35 ` [RFC PATCH 3/9] dt-bindings: clock: Add apple, cluster-clk binding Viresh Kumar [not found] ` <D0DE08FE-562E-4A48-BCA0-9094DAFCA564@marcan.st> [not found] ` <20211012094302.3cownyzr4phxwifs@vireshk-i7> [not found] ` <64584F8C-D49F-41B5-9658-CF8A25186E67@marcan.st> [not found] ` <20211012095735.mhh2lzu52ohtotl6@vireshk-i7> 2021-10-12 13:48 ` [RFC PATCH 3/9] dt-bindings: clock: Add apple,cluster-clk binding Hector Martin 2021-10-12 13:48 ` [RFC PATCH 3/9] dt-bindings: clock: Add apple, cluster-clk binding Hector Martin 2021-10-14 21:47 ` Stephen Boyd 2021-10-11 16:57 ` [RFC PATCH 4/9] opp: core: Don't warn if required OPP device does not exist Hector Martin 2021-10-11 16:57 ` Hector Martin 2021-10-12 3:21 ` Viresh Kumar 2021-10-12 3:21 ` Viresh Kumar 2021-10-12 5:34 ` Hector Martin 2021-10-12 5:34 ` Hector Martin 2021-10-12 5:51 ` Viresh Kumar 2021-10-12 5:51 ` Viresh Kumar 2021-10-12 5:57 ` Hector Martin [this message] 2021-10-12 5:57 ` Hector Martin 2021-10-12 9:26 ` Viresh Kumar 2021-10-12 9:26 ` Viresh Kumar 2021-10-12 9:31 ` Hector Martin "marcan" 2021-10-12 9:31 ` Hector Martin "marcan" 2021-10-12 9:32 ` Viresh Kumar 2021-10-12 9:32 ` Viresh Kumar 2021-10-14 6:52 ` Hector Martin 2021-10-14 6:52 ` Hector Martin 2021-10-14 6:56 ` Viresh Kumar 2021-10-14 6:56 ` Viresh Kumar 2021-10-14 7:03 ` Hector Martin 2021-10-14 7:03 ` Hector Martin 2021-10-14 7:22 ` Viresh Kumar 2021-10-14 7:22 ` Viresh Kumar 2021-10-14 7:23 ` Hector Martin 2021-10-14 7:23 ` Hector Martin 2021-10-14 11:08 ` Ulf Hansson 2021-10-14 11:08 ` Ulf Hansson 2021-10-14 9:55 ` Ulf Hansson 2021-10-14 9:55 ` Ulf Hansson 2021-10-14 11:43 ` Hector Martin 2021-10-14 11:43 ` Hector Martin 2021-10-14 12:55 ` Ulf Hansson 2021-10-14 12:55 ` Ulf Hansson 2021-10-14 17:02 ` Hector Martin 2021-10-14 17:02 ` Hector Martin 2021-10-15 11:26 ` Ulf Hansson 2021-10-15 11:26 ` Ulf Hansson 2021-10-11 16:57 ` [RFC PATCH 5/9] PM: domains: Add of_genpd_add_provider_simple_noclk() Hector Martin 2021-10-11 16:57 ` Hector Martin 2021-10-11 16:57 ` [RFC PATCH 6/9] memory: apple: Add apple-mcc driver to manage MCC perf in Apple SoCs Hector Martin 2021-10-11 16:57 ` Hector Martin 2021-10-12 7:24 ` kernel test robot 2021-10-12 9:19 ` Krzysztof Kozlowski 2021-10-12 9:19 ` Krzysztof Kozlowski 2021-10-14 6:59 ` Hector Martin 2021-10-14 6:59 ` Hector Martin 2021-10-14 7:36 ` Krzysztof Kozlowski 2021-10-14 7:36 ` Krzysztof Kozlowski 2021-10-14 7:52 ` Hector Martin 2021-10-14 7:52 ` Hector Martin 2021-10-14 8:04 ` Krzysztof Kozlowski 2021-10-14 8:04 ` Krzysztof Kozlowski 2021-10-14 8:31 ` Hector Martin 2021-10-14 8:31 ` Hector Martin 2021-10-11 16:57 ` [RFC PATCH 7/9] clk: apple: Add clk-apple-cluster driver to manage CPU p-states Hector Martin 2021-10-11 16:57 ` Hector Martin 2021-10-13 3:45 ` kernel test robot 2021-10-14 22:07 ` Stephen Boyd 2021-10-17 9:16 ` Hector Martin 2021-10-17 9:16 ` Hector Martin 2021-10-11 16:57 ` [RFC PATCH 8/9] arm64: apple: Select MEMORY and APPLE_MCC Hector Martin 2021-10-11 16:57 ` Hector Martin 2021-10-11 16:57 ` [RFC PATCH 9/9] arm64: apple: Add CPU frequency scaling support for t8103 Hector Martin 2021-10-11 16:57 ` Hector Martin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=caf16a6c-f127-7f27-ed17-0522d9f1fb9e@marcan.st \ --to=marcan@marcan.st \ --cc=alyssa@rosenzweig.io \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=khilman@kernel.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.kettenis@xs4all.nl \ --cc=maz@kernel.org \ --cc=mturquette@baylibre.com \ --cc=nm@ti.com \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=saravanak@google.com \ --cc=sboyd@kernel.org \ --cc=sibis@codeaurora.org \ --cc=sven@svenpeter.dev \ --cc=ulf.hansson@linaro.org \ --cc=viresh.kumar@linaro.org \ --cc=vireshk@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.