From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Lu, Brent" <brent.lu@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
"R, Dharageswari" <dharageswari.r@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Tzung-Bi Shih <tzungbi@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jie Yang <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
"Zhi, Yong" <yong.zhi@intel.com>, Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
"M, Naveen" <naveen.m@intel.com>,
"Wang, Rander" <rander.wang@intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Fred Oh <fred.oh@linux.intel.com>,
"Gopal, Vamshi Krishna" <vamshi.krishna.gopal@intel.com>,
"Nujella, Sathyanarayana" <sathyanarayana.nujella@intel.com>
Subject: Re: [PATCH 3/4] ASoC: intel: sof_cs42l42: add support for jsl_cs4242_mx98360a
Date: Mon, 7 Jun 2021 09:43:02 -0500 [thread overview]
Message-ID: <cb76f83c-e9d1-9726-ff8d-8d48a4de8e26@linux.intel.com> (raw)
In-Reply-To: <DM6PR11MB36421AD935E4A2B8EBD0FE6197389@DM6PR11MB3642.namprd11.prod.outlook.com>
On 6/7/21 9:29 AM, Lu, Brent wrote:
>> On 6/5/21 7:41 PM, Brent Lu wrote:
>>> This patch adds driver data for jsl_cs4242_mx98360a which supports two
>>> max98360a speaker amplifiers on SSP1 and cs42l42 headphone codec on
>>> SSP0 running on JSL platform. DAI format is leveraged from sof_rt5682
>>> machine driver to reuse the topology.
>>
>> This also looks like we have two topologies configuring the same DAIs
>> differently on different platforms.
>>
>> Why can't we pick one configuration that would work in all cases?
>>
>
> The comment just say we are reusing rt5685's sof-jsl-rt5682-mx98360a.tplg.
> This patch does not care about the dai sequence. Maybe I should reword the
> commit log.
I was referring to the bclk frequency, one case uses 2.4 and the other
3.072MHz.
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Lu, Brent" <brent.lu@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "Nujella, Sathyanarayana" <sathyanarayana.nujella@intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
"R, Dharageswari" <dharageswari.r@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Tzung-Bi Shih <tzungbi@google.com>,
Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
"M, Naveen" <naveen.m@intel.com>,
"Wang, Rander" <rander.wang@intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Fred Oh <fred.oh@linux.intel.com>,
"Gopal, Vamshi Krishna" <vamshi.krishna.gopal@intel.com>,
"Zhi, Yong" <yong.zhi@intel.com>
Subject: Re: [PATCH 3/4] ASoC: intel: sof_cs42l42: add support for jsl_cs4242_mx98360a
Date: Mon, 7 Jun 2021 09:43:02 -0500 [thread overview]
Message-ID: <cb76f83c-e9d1-9726-ff8d-8d48a4de8e26@linux.intel.com> (raw)
In-Reply-To: <DM6PR11MB36421AD935E4A2B8EBD0FE6197389@DM6PR11MB3642.namprd11.prod.outlook.com>
On 6/7/21 9:29 AM, Lu, Brent wrote:
>> On 6/5/21 7:41 PM, Brent Lu wrote:
>>> This patch adds driver data for jsl_cs4242_mx98360a which supports two
>>> max98360a speaker amplifiers on SSP1 and cs42l42 headphone codec on
>>> SSP0 running on JSL platform. DAI format is leveraged from sof_rt5682
>>> machine driver to reuse the topology.
>>
>> This also looks like we have two topologies configuring the same DAIs
>> differently on different platforms.
>>
>> Why can't we pick one configuration that would work in all cases?
>>
>
> The comment just say we are reusing rt5685's sof-jsl-rt5682-mx98360a.tplg.
> This patch does not care about the dai sequence. Maybe I should reword the
> commit log.
I was referring to the bclk frequency, one case uses 2.4 and the other
3.072MHz.
next prev parent reply other threads:[~2021-06-07 14:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 0:40 [PATCH 0/4] Support CS42L42 on JSL platform Brent Lu
2021-06-06 0:40 ` Brent Lu
2021-06-06 0:40 ` [PATCH 1/4] ASoC: Intel: sof_cs42l42: support JSL DAI link sequence Brent Lu
2021-06-06 0:40 ` Brent Lu
2021-06-07 13:32 ` Pierre-Louis Bossart
2021-06-07 13:32 ` Pierre-Louis Bossart
2021-06-07 14:23 ` Lu, Brent
2021-06-07 14:23 ` Lu, Brent
2021-06-07 20:49 ` Pierre-Louis Bossart
2021-06-07 20:49 ` Pierre-Louis Bossart
2021-06-06 0:41 ` [PATCH 2/4] ASoC: Intel: maxim-common: support max98360a Brent Lu
2021-06-06 0:41 ` Brent Lu
2021-06-06 0:41 ` [PATCH 3/4] ASoC: intel: sof_cs42l42: add support for jsl_cs4242_mx98360a Brent Lu
2021-06-06 0:41 ` Brent Lu
2021-06-07 13:40 ` Pierre-Louis Bossart
2021-06-07 13:40 ` Pierre-Louis Bossart
2021-06-07 14:29 ` Lu, Brent
2021-06-07 14:29 ` Lu, Brent
2021-06-07 14:43 ` Pierre-Louis Bossart [this message]
2021-06-07 14:43 ` Pierre-Louis Bossart
2021-06-07 16:28 ` Lu, Brent
2021-06-07 16:28 ` Lu, Brent
2021-06-07 18:32 ` Pierre-Louis Bossart
2021-06-07 18:32 ` Pierre-Louis Bossart
2021-06-06 0:41 ` [PATCH 4/4] ASoC: Intel: sof_rt5682: code refactor for max98360a Brent Lu
2021-06-06 0:41 ` Brent Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb76f83c-e9d1-9726-ff8d-8d48a4de8e26@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=dharageswari.r@intel.com \
--cc=fred.oh@linux.intel.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=rander.wang@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.