From: David Virag <virag.david003@gmail.com> To: Marc Zyngier <maz@kernel.org> Cc: Sam Protsenko <semen.protsenko@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Rob Herring <robh+dt@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v4 7/7] arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC Date: Sun, 19 Dec 2021 15:36:20 +0100 [thread overview] Message-ID: <cc27e22d9945b1ab5ccc7ef20eb36af63402ef54.camel@gmail.com> (raw) In-Reply-To: <b0f95b77e335596ee567ae83c1cbe549@misterjones.org> On Tue, 2021-12-07 at 19:42 +0000, Marc Zyngier wrote: > On 2021-12-06 15:31, David Virag wrote: > > Add initial Exynos7885 device tree nodes with dts for the Samsung > > Galaxy > > A8 (2018), a.k.a. "jackpotlte", with model number "SM-A530F". > > Currently this includes some clock support, UART support, and I2C > > nodes. > > > > Signed-off-by: David Virag <virag.david003@gmail.com> > > [...] > > > + psci { > > + compatible = "arm,psci"; > > + method = "smc"; > > + cpu_suspend = <0xc4000001>; > > + cpu_off = <0x84000002>; > > + cpu_on = <0xc4000003>; > > Aren't these the standard PSCI 0.2 function numbers? Can't you > make the compatible "arm,psci-0.2" instead? This is not a proper PSCI 0.2 implementation. For example 0.2 has a get version call which is definitely not implemented properly as after setting the compatible to 0.2 I get the following: [ 0.000000] psci: PSCIv65535.65535 detected in firmware. Which is obviously not right. > > > + }; > > + > > + timer { > > + compatible = "arm,armv8-timer"; > > + /* Hypervisor Virtual Timer interrupt is not wired > > to GIC */ > > I don't understand this comment. You seem to have a bunch of > ARMv8.0 cores, for which there is no such thing as a hypervisor > virtual timer (this is an ARMv8.1 addition). My bad, will remove it! Should have read docs better. > > > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | > > IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | > > IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | > > IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | > > IRQ_TYPE_LEVEL_LOW)>; > > + }; > > Thanks, > > M.
WARNING: multiple messages have this Message-ID (diff)
From: David Virag <virag.david003@gmail.com> To: Marc Zyngier <maz@kernel.org> Cc: Sam Protsenko <semen.protsenko@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, Rob Herring <robh+dt@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v4 7/7] arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC Date: Sun, 19 Dec 2021 15:36:20 +0100 [thread overview] Message-ID: <cc27e22d9945b1ab5ccc7ef20eb36af63402ef54.camel@gmail.com> (raw) In-Reply-To: <b0f95b77e335596ee567ae83c1cbe549@misterjones.org> On Tue, 2021-12-07 at 19:42 +0000, Marc Zyngier wrote: > On 2021-12-06 15:31, David Virag wrote: > > Add initial Exynos7885 device tree nodes with dts for the Samsung > > Galaxy > > A8 (2018), a.k.a. "jackpotlte", with model number "SM-A530F". > > Currently this includes some clock support, UART support, and I2C > > nodes. > > > > Signed-off-by: David Virag <virag.david003@gmail.com> > > [...] > > > + psci { > > + compatible = "arm,psci"; > > + method = "smc"; > > + cpu_suspend = <0xc4000001>; > > + cpu_off = <0x84000002>; > > + cpu_on = <0xc4000003>; > > Aren't these the standard PSCI 0.2 function numbers? Can't you > make the compatible "arm,psci-0.2" instead? This is not a proper PSCI 0.2 implementation. For example 0.2 has a get version call which is definitely not implemented properly as after setting the compatible to 0.2 I get the following: [ 0.000000] psci: PSCIv65535.65535 detected in firmware. Which is obviously not right. > > > + }; > > + > > + timer { > > + compatible = "arm,armv8-timer"; > > + /* Hypervisor Virtual Timer interrupt is not wired > > to GIC */ > > I don't understand this comment. You seem to have a bunch of > ARMv8.0 cores, for which there is no such thing as a hypervisor > virtual timer (this is an ARMv8.1 addition). My bad, will remove it! Should have read docs better. > > > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | > > IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | > > IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | > > IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | > > IRQ_TYPE_LEVEL_LOW)>; > > + }; > > Thanks, > > M. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-19 14:37 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-06 15:31 [PATCH v4 0/7] Initial Samsung Galaxy A8 (2018) support David Virag 2021-12-06 15:31 ` David Virag 2021-12-06 15:31 ` [PATCH v4 1/7] dt-bindings: clock: Add bindings definitions for Exynos7885 CMU David Virag 2021-12-06 15:31 ` David Virag 2021-12-07 18:15 ` Sam Protsenko 2021-12-07 18:15 ` Sam Protsenko 2021-12-10 21:26 ` Rob Herring 2021-12-10 21:26 ` Rob Herring 2021-12-12 18:39 ` Krzysztof Kozlowski 2021-12-12 18:39 ` Krzysztof Kozlowski 2021-12-20 9:40 ` Krzysztof Kozlowski 2021-12-20 9:40 ` Krzysztof Kozlowski 2021-12-19 22:52 ` Sylwester Nawrocki 2021-12-19 22:52 ` Sylwester Nawrocki 2021-12-06 15:31 ` [PATCH v4 2/7] dt-bindings: clock: Document Exynos7885 CMU bindings David Virag 2021-12-06 15:31 ` David Virag 2021-12-07 18:23 ` Sam Protsenko 2021-12-07 18:23 ` Sam Protsenko 2021-12-10 21:28 ` Rob Herring 2021-12-10 21:28 ` Rob Herring 2021-12-06 15:31 ` [PATCH v4 3/7] dt-bindings: arm: samsung: document jackpotlte board binding David Virag 2021-12-06 15:31 ` David Virag 2021-12-07 18:26 ` Sam Protsenko 2021-12-07 18:26 ` Sam Protsenko 2021-12-10 21:30 ` Rob Herring 2021-12-10 21:30 ` Rob Herring 2021-12-15 16:21 ` (subset) " Krzysztof Kozlowski 2021-12-15 16:21 ` Krzysztof Kozlowski 2021-12-19 14:53 ` David Virag 2021-12-19 14:53 ` David Virag 2021-12-20 9:38 ` Krzysztof Kozlowski 2021-12-20 9:38 ` Krzysztof Kozlowski 2021-12-06 15:31 ` [PATCH v4 4/7] clk: samsung: Make exynos850_register_cmu shared David Virag 2021-12-06 15:31 ` David Virag 2021-12-07 9:32 ` Krzysztof Kozlowski 2021-12-07 9:32 ` Krzysztof Kozlowski 2021-12-07 18:53 ` Sam Protsenko 2021-12-07 18:53 ` Sam Protsenko 2021-12-06 15:31 ` [PATCH v4 5/7] clk: samsung: clk-pll: Add support for pll1417x David Virag 2021-12-06 15:31 ` David Virag 2021-12-07 19:00 ` Sam Protsenko 2021-12-07 19:00 ` Sam Protsenko 2021-12-08 8:50 ` Krzysztof Kozlowski 2021-12-08 8:50 ` Krzysztof Kozlowski 2021-12-06 15:31 ` [PATCH v4 6/7] clk: samsung: Add initial Exynos7885 clock driver David Virag 2021-12-06 15:31 ` David Virag 2021-12-07 9:33 ` Krzysztof Kozlowski 2021-12-07 9:33 ` Krzysztof Kozlowski 2021-12-07 19:14 ` Sam Protsenko 2021-12-07 19:14 ` Sam Protsenko 2021-12-06 15:31 ` [PATCH v4 7/7] arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC David Virag 2021-12-06 15:31 ` David Virag 2021-12-07 9:39 ` Krzysztof Kozlowski 2021-12-07 9:39 ` Krzysztof Kozlowski 2021-12-07 19:42 ` Marc Zyngier 2021-12-07 19:42 ` Marc Zyngier 2021-12-19 14:36 ` David Virag [this message] 2021-12-19 14:36 ` David Virag 2021-12-20 8:44 ` Marc Zyngier 2021-12-20 8:44 ` Marc Zyngier 2021-12-07 20:19 ` Sam Protsenko 2021-12-07 20:19 ` Sam Protsenko 2021-12-07 22:29 ` David Virag 2021-12-07 22:29 ` David Virag 2021-12-08 0:55 ` Chanho Park 2021-12-08 0:55 ` Chanho Park 2021-12-08 9:05 ` Krzysztof Kozlowski 2021-12-08 9:05 ` Krzysztof Kozlowski 2021-12-08 15:37 ` Sam Protsenko 2021-12-08 15:37 ` Sam Protsenko 2021-12-08 16:28 ` Krzysztof Kozlowski 2021-12-08 16:28 ` Krzysztof Kozlowski 2021-12-08 16:51 ` Sam Protsenko 2021-12-08 16:51 ` Sam Protsenko 2022-01-31 15:35 ` Krzysztof Kozlowski 2022-01-31 15:35 ` Krzysztof Kozlowski 2022-02-01 0:47 ` David Virag 2022-02-01 0:47 ` David Virag
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cc27e22d9945b1ab5ccc7ef20eb36af63402ef54.camel@gmail.com \ --to=virag.david003@gmail.com \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=maz@kernel.org \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.