From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: daniel@ffwll.ch, airlied@gmail.com,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
nouveau@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Tue, 17 Jan 2023 09:45:31 +0100 [thread overview]
Message-ID: <cc6366b5-6072-19b7-a2fb-648b6241b67c@suse.de> (raw)
In-Reply-To: <Y8W3y32sOpP3D6YX@ravnborg.org>
[-- Attachment #1.1: Type: text/plain, Size: 10643 bytes --]
Hi
Am 16.01.23 um 21:47 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Mon, Jan 16, 2023 at 02:12:13PM +0100, Thomas Zimmermann wrote:
>> A lot of source files include drm_crtc_helper.h for its contained
>> include statements. This leads to excessive compile-time dependencies.
>>
>> Where possible, remove the include statements for drm_crtc_helper.h
>> and include the required source files directly. Also remove the
>> include statements from drm_crtc_helper.h itself, which doesn't need
>> most of them.
> With this patchset drm_crtc_helper usage is reduced from 85 places to 35
> places. And the 35 places is only .c files.
> This is a very nice reduction of bloat! I hope this has a measureable
> effect on building times.
I cannot say what the effect is for a single header, but if we do this
for all header files, the effect is measureable.
>
> I was working on something similar, but that approach only added missing
> includes, and did not kill all the unnessesary includes - which I think
> is the biggest win here.
>
> All patches are:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thank you.
>
> For a few of them the r-b is conditional, see the specific comments
> posted.
I fixed all your comments, including the minor complaint about the
commit messages.
I don't intent to send out a v2 here, but the fixed patches should soon
show up in drm-misc-next.
Best regards
Thomas
>
>
> I did a build check here with the archs and config I verifies with.
> This covers "alpha arm arm64 sparc64 i386 x86 powerpc s390 riscv sh"
> and everything was fine. I have a few specific configs to pull in
> drivers that need a bit extra to be built.
> So I consider build coverage OK for applying, but it would be nice to
> wait a few days for the bots to verify too.
>
> My own work on slimming drm_atomic_helper.h and drm_print.h will be
> rebased on top of your work before I continue it.
> I need to look into removing unused includes too.
>
> Sam
>
>>
>> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
>> all include dependencies.
>>
>> Thanks to Sam Ravnborg for bringing this to my attention.
>>
>> Thomas Zimmermann (22):
>> drm/amdgpu: Fix coding style
>> drm: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/amdgpu: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/arm/komeda: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/aspeed: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ast: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/bridge: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/gma500: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/i2c/ch7006: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ingenic: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/logicvc: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/nouveau: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/radeon: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/rockchip: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/shmobile: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/udl: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/vboxvideo: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/crtc-helper: Remove most include statements from drm_crtc_helper.h
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
>> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 +
>> drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++
>> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 -
>> drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 -
>> drivers/gpu/drm/ast/ast_drv.c | 1 -
>> drivers/gpu/drm/ast/ast_main.c | 1 -
>> drivers/gpu/drm/ast/ast_mode.c | 1 -
>> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 -
>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>> .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 -
>> drivers/gpu/drm/bridge/ite-it6505.c | 1 -
>> drivers/gpu/drm/bridge/ite-it66121.c | 1 -
>> drivers/gpu/drm/bridge/tc358768.c | 1 -
>> drivers/gpu/drm/bridge/tc358775.c | 1 -
>> drivers/gpu/drm/drm_crtc_helper.c | 1 -
>> drivers/gpu/drm/drm_lease.c | 2 +-
>> drivers/gpu/drm/drm_plane_helper.c | 1 -
>> drivers/gpu/drm/gma500/cdv_device.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_display.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/framebuffer.c | 2 ++
>> drivers/gpu/drm/gma500/gma_display.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
>> drivers/gpu/drm/gma500/psb_device.c | 1 +
>> drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++
>> drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -
>> drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_priv.h | 1 -
>> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 -
>> drivers/gpu/drm/kmb/kmb_crtc.c | 1 -
>> drivers/gpu/drm/kmb/kmb_plane.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_interface.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_mode.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv50/head.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
>> drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/atombios_encoders.c | 1 +
>> drivers/gpu/drm/radeon/r300.c | 1 -
>> drivers/gpu/drm/radeon/radeon_asic.c | 1 -
>> drivers/gpu/drm/radeon/radeon_connectors.c | 1 +
>> drivers/gpu/drm/radeon/radeon_display.c | 1 +
>> drivers/gpu/drm/radeon/radeon_drv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_encoders.c | 1 -
>> drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 -
>> drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_mode.h | 2 +-
>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++
>> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dpu.c | 1 -
>> drivers/gpu/drm/sprd/sprd_drm.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dsi.c | 1 -
>> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_crtc.c | 1 -
>> drivers/gpu/drm/tidss/tidss_drv.c | 1 -
>> drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_kms.c | 1 -
>> drivers/gpu/drm/tidss/tidss_plane.c | 1 -
>> drivers/gpu/drm/udl/udl_drv.c | 2 +-
>> drivers/gpu/drm/udl/udl_modeset.c | 1 -
>> drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +-
>> drivers/gpu/drm/vboxvideo/vbox_main.c | 1 -
>> include/drm/drm_crtc_helper.h | 14 +++++++++-----
>> include/drm/drm_fixed.h | 1 +
>> 94 files changed, 70 insertions(+), 70 deletions(-)
>>
>>
>> base-commit: 68d139b609a97a83e7c231189d4864aba4e1679b
>> prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
>> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
>> prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
>> --
>> 2.39.0
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org,
linux-mips@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
linux-sunxi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Nouveau] [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Tue, 17 Jan 2023 09:45:31 +0100 [thread overview]
Message-ID: <cc6366b5-6072-19b7-a2fb-648b6241b67c@suse.de> (raw)
In-Reply-To: <Y8W3y32sOpP3D6YX@ravnborg.org>
[-- Attachment #1.1: Type: text/plain, Size: 10643 bytes --]
Hi
Am 16.01.23 um 21:47 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Mon, Jan 16, 2023 at 02:12:13PM +0100, Thomas Zimmermann wrote:
>> A lot of source files include drm_crtc_helper.h for its contained
>> include statements. This leads to excessive compile-time dependencies.
>>
>> Where possible, remove the include statements for drm_crtc_helper.h
>> and include the required source files directly. Also remove the
>> include statements from drm_crtc_helper.h itself, which doesn't need
>> most of them.
> With this patchset drm_crtc_helper usage is reduced from 85 places to 35
> places. And the 35 places is only .c files.
> This is a very nice reduction of bloat! I hope this has a measureable
> effect on building times.
I cannot say what the effect is for a single header, but if we do this
for all header files, the effect is measureable.
>
> I was working on something similar, but that approach only added missing
> includes, and did not kill all the unnessesary includes - which I think
> is the biggest win here.
>
> All patches are:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thank you.
>
> For a few of them the r-b is conditional, see the specific comments
> posted.
I fixed all your comments, including the minor complaint about the
commit messages.
I don't intent to send out a v2 here, but the fixed patches should soon
show up in drm-misc-next.
Best regards
Thomas
>
>
> I did a build check here with the archs and config I verifies with.
> This covers "alpha arm arm64 sparc64 i386 x86 powerpc s390 riscv sh"
> and everything was fine. I have a few specific configs to pull in
> drivers that need a bit extra to be built.
> So I consider build coverage OK for applying, but it would be nice to
> wait a few days for the bots to verify too.
>
> My own work on slimming drm_atomic_helper.h and drm_print.h will be
> rebased on top of your work before I continue it.
> I need to look into removing unused includes too.
>
> Sam
>
>>
>> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
>> all include dependencies.
>>
>> Thanks to Sam Ravnborg for bringing this to my attention.
>>
>> Thomas Zimmermann (22):
>> drm/amdgpu: Fix coding style
>> drm: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/amdgpu: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/arm/komeda: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/aspeed: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ast: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/bridge: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/gma500: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/i2c/ch7006: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ingenic: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/logicvc: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/nouveau: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/radeon: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/rockchip: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/shmobile: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/udl: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/vboxvideo: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/crtc-helper: Remove most include statements from drm_crtc_helper.h
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
>> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 +
>> drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++
>> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 -
>> drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 -
>> drivers/gpu/drm/ast/ast_drv.c | 1 -
>> drivers/gpu/drm/ast/ast_main.c | 1 -
>> drivers/gpu/drm/ast/ast_mode.c | 1 -
>> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 -
>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>> .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 -
>> drivers/gpu/drm/bridge/ite-it6505.c | 1 -
>> drivers/gpu/drm/bridge/ite-it66121.c | 1 -
>> drivers/gpu/drm/bridge/tc358768.c | 1 -
>> drivers/gpu/drm/bridge/tc358775.c | 1 -
>> drivers/gpu/drm/drm_crtc_helper.c | 1 -
>> drivers/gpu/drm/drm_lease.c | 2 +-
>> drivers/gpu/drm/drm_plane_helper.c | 1 -
>> drivers/gpu/drm/gma500/cdv_device.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_display.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/framebuffer.c | 2 ++
>> drivers/gpu/drm/gma500/gma_display.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
>> drivers/gpu/drm/gma500/psb_device.c | 1 +
>> drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++
>> drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -
>> drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_priv.h | 1 -
>> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 -
>> drivers/gpu/drm/kmb/kmb_crtc.c | 1 -
>> drivers/gpu/drm/kmb/kmb_plane.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_interface.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_mode.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv50/head.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
>> drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/atombios_encoders.c | 1 +
>> drivers/gpu/drm/radeon/r300.c | 1 -
>> drivers/gpu/drm/radeon/radeon_asic.c | 1 -
>> drivers/gpu/drm/radeon/radeon_connectors.c | 1 +
>> drivers/gpu/drm/radeon/radeon_display.c | 1 +
>> drivers/gpu/drm/radeon/radeon_drv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_encoders.c | 1 -
>> drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 -
>> drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_mode.h | 2 +-
>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++
>> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dpu.c | 1 -
>> drivers/gpu/drm/sprd/sprd_drm.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dsi.c | 1 -
>> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_crtc.c | 1 -
>> drivers/gpu/drm/tidss/tidss_drv.c | 1 -
>> drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_kms.c | 1 -
>> drivers/gpu/drm/tidss/tidss_plane.c | 1 -
>> drivers/gpu/drm/udl/udl_drv.c | 2 +-
>> drivers/gpu/drm/udl/udl_modeset.c | 1 -
>> drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +-
>> drivers/gpu/drm/vboxvideo/vbox_main.c | 1 -
>> include/drm/drm_crtc_helper.h | 14 +++++++++-----
>> include/drm/drm_fixed.h | 1 +
>> 94 files changed, 70 insertions(+), 70 deletions(-)
>>
>>
>> base-commit: 68d139b609a97a83e7c231189d4864aba4e1679b
>> prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
>> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
>> prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
>> --
>> 2.39.0
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org,
linux-mips@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Tue, 17 Jan 2023 09:45:31 +0100 [thread overview]
Message-ID: <cc6366b5-6072-19b7-a2fb-648b6241b67c@suse.de> (raw)
In-Reply-To: <Y8W3y32sOpP3D6YX@ravnborg.org>
[-- Attachment #1.1: Type: text/plain, Size: 10643 bytes --]
Hi
Am 16.01.23 um 21:47 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Mon, Jan 16, 2023 at 02:12:13PM +0100, Thomas Zimmermann wrote:
>> A lot of source files include drm_crtc_helper.h for its contained
>> include statements. This leads to excessive compile-time dependencies.
>>
>> Where possible, remove the include statements for drm_crtc_helper.h
>> and include the required source files directly. Also remove the
>> include statements from drm_crtc_helper.h itself, which doesn't need
>> most of them.
> With this patchset drm_crtc_helper usage is reduced from 85 places to 35
> places. And the 35 places is only .c files.
> This is a very nice reduction of bloat! I hope this has a measureable
> effect on building times.
I cannot say what the effect is for a single header, but if we do this
for all header files, the effect is measureable.
>
> I was working on something similar, but that approach only added missing
> includes, and did not kill all the unnessesary includes - which I think
> is the biggest win here.
>
> All patches are:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thank you.
>
> For a few of them the r-b is conditional, see the specific comments
> posted.
I fixed all your comments, including the minor complaint about the
commit messages.
I don't intent to send out a v2 here, but the fixed patches should soon
show up in drm-misc-next.
Best regards
Thomas
>
>
> I did a build check here with the archs and config I verifies with.
> This covers "alpha arm arm64 sparc64 i386 x86 powerpc s390 riscv sh"
> and everything was fine. I have a few specific configs to pull in
> drivers that need a bit extra to be built.
> So I consider build coverage OK for applying, but it would be nice to
> wait a few days for the bots to verify too.
>
> My own work on slimming drm_atomic_helper.h and drm_print.h will be
> rebased on top of your work before I continue it.
> I need to look into removing unused includes too.
>
> Sam
>
>>
>> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
>> all include dependencies.
>>
>> Thanks to Sam Ravnborg for bringing this to my attention.
>>
>> Thomas Zimmermann (22):
>> drm/amdgpu: Fix coding style
>> drm: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/amdgpu: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/arm/komeda: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/aspeed: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ast: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/bridge: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/gma500: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/i2c/ch7006: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ingenic: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/logicvc: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/nouveau: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/radeon: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/rockchip: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/shmobile: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/udl: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/vboxvideo: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/crtc-helper: Remove most include statements from drm_crtc_helper.h
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
>> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 +
>> drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++
>> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 -
>> drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 -
>> drivers/gpu/drm/ast/ast_drv.c | 1 -
>> drivers/gpu/drm/ast/ast_main.c | 1 -
>> drivers/gpu/drm/ast/ast_mode.c | 1 -
>> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 -
>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>> .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 -
>> drivers/gpu/drm/bridge/ite-it6505.c | 1 -
>> drivers/gpu/drm/bridge/ite-it66121.c | 1 -
>> drivers/gpu/drm/bridge/tc358768.c | 1 -
>> drivers/gpu/drm/bridge/tc358775.c | 1 -
>> drivers/gpu/drm/drm_crtc_helper.c | 1 -
>> drivers/gpu/drm/drm_lease.c | 2 +-
>> drivers/gpu/drm/drm_plane_helper.c | 1 -
>> drivers/gpu/drm/gma500/cdv_device.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_display.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/framebuffer.c | 2 ++
>> drivers/gpu/drm/gma500/gma_display.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
>> drivers/gpu/drm/gma500/psb_device.c | 1 +
>> drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++
>> drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -
>> drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_priv.h | 1 -
>> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 -
>> drivers/gpu/drm/kmb/kmb_crtc.c | 1 -
>> drivers/gpu/drm/kmb/kmb_plane.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_interface.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_mode.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv50/head.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
>> drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/atombios_encoders.c | 1 +
>> drivers/gpu/drm/radeon/r300.c | 1 -
>> drivers/gpu/drm/radeon/radeon_asic.c | 1 -
>> drivers/gpu/drm/radeon/radeon_connectors.c | 1 +
>> drivers/gpu/drm/radeon/radeon_display.c | 1 +
>> drivers/gpu/drm/radeon/radeon_drv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_encoders.c | 1 -
>> drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 -
>> drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_mode.h | 2 +-
>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++
>> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dpu.c | 1 -
>> drivers/gpu/drm/sprd/sprd_drm.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dsi.c | 1 -
>> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_crtc.c | 1 -
>> drivers/gpu/drm/tidss/tidss_drv.c | 1 -
>> drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_kms.c | 1 -
>> drivers/gpu/drm/tidss/tidss_plane.c | 1 -
>> drivers/gpu/drm/udl/udl_drv.c | 2 +-
>> drivers/gpu/drm/udl/udl_modeset.c | 1 -
>> drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +-
>> drivers/gpu/drm/vboxvideo/vbox_main.c | 1 -
>> include/drm/drm_crtc_helper.h | 14 +++++++++-----
>> include/drm/drm_fixed.h | 1 +
>> 94 files changed, 70 insertions(+), 70 deletions(-)
>>
>>
>> base-commit: 68d139b609a97a83e7c231189d4864aba4e1679b
>> prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
>> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
>> prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
>> --
>> 2.39.0
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org,
linux-mips@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
airlied@gmail.com, linux-sunxi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Tue, 17 Jan 2023 09:45:31 +0100 [thread overview]
Message-ID: <cc6366b5-6072-19b7-a2fb-648b6241b67c@suse.de> (raw)
In-Reply-To: <Y8W3y32sOpP3D6YX@ravnborg.org>
[-- Attachment #1.1: Type: text/plain, Size: 10643 bytes --]
Hi
Am 16.01.23 um 21:47 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Mon, Jan 16, 2023 at 02:12:13PM +0100, Thomas Zimmermann wrote:
>> A lot of source files include drm_crtc_helper.h for its contained
>> include statements. This leads to excessive compile-time dependencies.
>>
>> Where possible, remove the include statements for drm_crtc_helper.h
>> and include the required source files directly. Also remove the
>> include statements from drm_crtc_helper.h itself, which doesn't need
>> most of them.
> With this patchset drm_crtc_helper usage is reduced from 85 places to 35
> places. And the 35 places is only .c files.
> This is a very nice reduction of bloat! I hope this has a measureable
> effect on building times.
I cannot say what the effect is for a single header, but if we do this
for all header files, the effect is measureable.
>
> I was working on something similar, but that approach only added missing
> includes, and did not kill all the unnessesary includes - which I think
> is the biggest win here.
>
> All patches are:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thank you.
>
> For a few of them the r-b is conditional, see the specific comments
> posted.
I fixed all your comments, including the minor complaint about the
commit messages.
I don't intent to send out a v2 here, but the fixed patches should soon
show up in drm-misc-next.
Best regards
Thomas
>
>
> I did a build check here with the archs and config I verifies with.
> This covers "alpha arm arm64 sparc64 i386 x86 powerpc s390 riscv sh"
> and everything was fine. I have a few specific configs to pull in
> drivers that need a bit extra to be built.
> So I consider build coverage OK for applying, but it would be nice to
> wait a few days for the bots to verify too.
>
> My own work on slimming drm_atomic_helper.h and drm_print.h will be
> rebased on top of your work before I continue it.
> I need to look into removing unused includes too.
>
> Sam
>
>>
>> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
>> all include dependencies.
>>
>> Thanks to Sam Ravnborg for bringing this to my attention.
>>
>> Thomas Zimmermann (22):
>> drm/amdgpu: Fix coding style
>> drm: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/amdgpu: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/arm/komeda: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/aspeed: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ast: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/bridge: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/gma500: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/i2c/ch7006: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ingenic: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/logicvc: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/nouveau: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/radeon: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/rockchip: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/shmobile: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/udl: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/vboxvideo: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/crtc-helper: Remove most include statements from drm_crtc_helper.h
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
>> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 +
>> drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++
>> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 -
>> drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 -
>> drivers/gpu/drm/ast/ast_drv.c | 1 -
>> drivers/gpu/drm/ast/ast_main.c | 1 -
>> drivers/gpu/drm/ast/ast_mode.c | 1 -
>> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 -
>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>> .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 -
>> drivers/gpu/drm/bridge/ite-it6505.c | 1 -
>> drivers/gpu/drm/bridge/ite-it66121.c | 1 -
>> drivers/gpu/drm/bridge/tc358768.c | 1 -
>> drivers/gpu/drm/bridge/tc358775.c | 1 -
>> drivers/gpu/drm/drm_crtc_helper.c | 1 -
>> drivers/gpu/drm/drm_lease.c | 2 +-
>> drivers/gpu/drm/drm_plane_helper.c | 1 -
>> drivers/gpu/drm/gma500/cdv_device.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_display.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/framebuffer.c | 2 ++
>> drivers/gpu/drm/gma500/gma_display.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
>> drivers/gpu/drm/gma500/psb_device.c | 1 +
>> drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++
>> drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -
>> drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_priv.h | 1 -
>> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 -
>> drivers/gpu/drm/kmb/kmb_crtc.c | 1 -
>> drivers/gpu/drm/kmb/kmb_plane.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_interface.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_mode.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv50/head.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
>> drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/atombios_encoders.c | 1 +
>> drivers/gpu/drm/radeon/r300.c | 1 -
>> drivers/gpu/drm/radeon/radeon_asic.c | 1 -
>> drivers/gpu/drm/radeon/radeon_connectors.c | 1 +
>> drivers/gpu/drm/radeon/radeon_display.c | 1 +
>> drivers/gpu/drm/radeon/radeon_drv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_encoders.c | 1 -
>> drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 -
>> drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_mode.h | 2 +-
>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++
>> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dpu.c | 1 -
>> drivers/gpu/drm/sprd/sprd_drm.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dsi.c | 1 -
>> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_crtc.c | 1 -
>> drivers/gpu/drm/tidss/tidss_drv.c | 1 -
>> drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_kms.c | 1 -
>> drivers/gpu/drm/tidss/tidss_plane.c | 1 -
>> drivers/gpu/drm/udl/udl_drv.c | 2 +-
>> drivers/gpu/drm/udl/udl_modeset.c | 1 -
>> drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +-
>> drivers/gpu/drm/vboxvideo/vbox_main.c | 1 -
>> include/drm/drm_crtc_helper.h | 14 +++++++++-----
>> include/drm/drm_fixed.h | 1 +
>> 94 files changed, 70 insertions(+), 70 deletions(-)
>>
>>
>> base-commit: 68d139b609a97a83e7c231189d4864aba4e1679b
>> prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
>> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
>> prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
>> --
>> 2.39.0
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: daniel@ffwll.ch, airlied@gmail.com,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
nouveau@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Tue, 17 Jan 2023 09:45:31 +0100 [thread overview]
Message-ID: <cc6366b5-6072-19b7-a2fb-648b6241b67c@suse.de> (raw)
In-Reply-To: <Y8W3y32sOpP3D6YX@ravnborg.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 10643 bytes --]
Hi
Am 16.01.23 um 21:47 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Mon, Jan 16, 2023 at 02:12:13PM +0100, Thomas Zimmermann wrote:
>> A lot of source files include drm_crtc_helper.h for its contained
>> include statements. This leads to excessive compile-time dependencies.
>>
>> Where possible, remove the include statements for drm_crtc_helper.h
>> and include the required source files directly. Also remove the
>> include statements from drm_crtc_helper.h itself, which doesn't need
>> most of them.
> With this patchset drm_crtc_helper usage is reduced from 85 places to 35
> places. And the 35 places is only .c files.
> This is a very nice reduction of bloat! I hope this has a measureable
> effect on building times.
I cannot say what the effect is for a single header, but if we do this
for all header files, the effect is measureable.
>
> I was working on something similar, but that approach only added missing
> includes, and did not kill all the unnessesary includes - which I think
> is the biggest win here.
>
> All patches are:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thank you.
>
> For a few of them the r-b is conditional, see the specific comments
> posted.
I fixed all your comments, including the minor complaint about the
commit messages.
I don't intent to send out a v2 here, but the fixed patches should soon
show up in drm-misc-next.
Best regards
Thomas
>
>
> I did a build check here with the archs and config I verifies with.
> This covers "alpha arm arm64 sparc64 i386 x86 powerpc s390 riscv sh"
> and everything was fine. I have a few specific configs to pull in
> drivers that need a bit extra to be built.
> So I consider build coverage OK for applying, but it would be nice to
> wait a few days for the bots to verify too.
>
> My own work on slimming drm_atomic_helper.h and drm_print.h will be
> rebased on top of your work before I continue it.
> I need to look into removing unused includes too.
>
> Sam
>
>>
>> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
>> all include dependencies.
>>
>> Thanks to Sam Ravnborg for bringing this to my attention.
>>
>> Thomas Zimmermann (22):
>> drm/amdgpu: Fix coding style
>> drm: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/amdgpu: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/arm/komeda: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/aspeed: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ast: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/bridge: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/gma500: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/i2c/ch7006: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ingenic: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/logicvc: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/nouveau: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/radeon: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/rockchip: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/shmobile: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/udl: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/vboxvideo: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/crtc-helper: Remove most include statements from drm_crtc_helper.h
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
>> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 +
>> drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++
>> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 -
>> drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 -
>> drivers/gpu/drm/ast/ast_drv.c | 1 -
>> drivers/gpu/drm/ast/ast_main.c | 1 -
>> drivers/gpu/drm/ast/ast_mode.c | 1 -
>> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 -
>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>> .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 -
>> drivers/gpu/drm/bridge/ite-it6505.c | 1 -
>> drivers/gpu/drm/bridge/ite-it66121.c | 1 -
>> drivers/gpu/drm/bridge/tc358768.c | 1 -
>> drivers/gpu/drm/bridge/tc358775.c | 1 -
>> drivers/gpu/drm/drm_crtc_helper.c | 1 -
>> drivers/gpu/drm/drm_lease.c | 2 +-
>> drivers/gpu/drm/drm_plane_helper.c | 1 -
>> drivers/gpu/drm/gma500/cdv_device.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_display.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/framebuffer.c | 2 ++
>> drivers/gpu/drm/gma500/gma_display.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
>> drivers/gpu/drm/gma500/psb_device.c | 1 +
>> drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++
>> drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -
>> drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_priv.h | 1 -
>> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 -
>> drivers/gpu/drm/kmb/kmb_crtc.c | 1 -
>> drivers/gpu/drm/kmb/kmb_plane.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_interface.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_mode.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv50/head.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
>> drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/atombios_encoders.c | 1 +
>> drivers/gpu/drm/radeon/r300.c | 1 -
>> drivers/gpu/drm/radeon/radeon_asic.c | 1 -
>> drivers/gpu/drm/radeon/radeon_connectors.c | 1 +
>> drivers/gpu/drm/radeon/radeon_display.c | 1 +
>> drivers/gpu/drm/radeon/radeon_drv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_encoders.c | 1 -
>> drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 -
>> drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_mode.h | 2 +-
>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++
>> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dpu.c | 1 -
>> drivers/gpu/drm/sprd/sprd_drm.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dsi.c | 1 -
>> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_crtc.c | 1 -
>> drivers/gpu/drm/tidss/tidss_drv.c | 1 -
>> drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_kms.c | 1 -
>> drivers/gpu/drm/tidss/tidss_plane.c | 1 -
>> drivers/gpu/drm/udl/udl_drv.c | 2 +-
>> drivers/gpu/drm/udl/udl_modeset.c | 1 -
>> drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +-
>> drivers/gpu/drm/vboxvideo/vbox_main.c | 1 -
>> include/drm/drm_crtc_helper.h | 14 +++++++++-----
>> include/drm/drm_fixed.h | 1 +
>> 94 files changed, 70 insertions(+), 70 deletions(-)
>>
>>
>> base-commit: 68d139b609a97a83e7c231189d4864aba4e1679b
>> prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
>> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
>> prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
>> --
>> 2.39.0
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: daniel@ffwll.ch, airlied@gmail.com,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
nouveau@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h
Date: Tue, 17 Jan 2023 09:45:31 +0100 [thread overview]
Message-ID: <cc6366b5-6072-19b7-a2fb-648b6241b67c@suse.de> (raw)
In-Reply-To: <Y8W3y32sOpP3D6YX@ravnborg.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 10643 bytes --]
Hi
Am 16.01.23 um 21:47 schrieb Sam Ravnborg:
> Hi Thomas.
>
> On Mon, Jan 16, 2023 at 02:12:13PM +0100, Thomas Zimmermann wrote:
>> A lot of source files include drm_crtc_helper.h for its contained
>> include statements. This leads to excessive compile-time dependencies.
>>
>> Where possible, remove the include statements for drm_crtc_helper.h
>> and include the required source files directly. Also remove the
>> include statements from drm_crtc_helper.h itself, which doesn't need
>> most of them.
> With this patchset drm_crtc_helper usage is reduced from 85 places to 35
> places. And the 35 places is only .c files.
> This is a very nice reduction of bloat! I hope this has a measureable
> effect on building times.
I cannot say what the effect is for a single header, but if we do this
for all header files, the effect is measureable.
>
> I was working on something similar, but that approach only added missing
> includes, and did not kill all the unnessesary includes - which I think
> is the biggest win here.
>
> All patches are:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thank you.
>
> For a few of them the r-b is conditional, see the specific comments
> posted.
I fixed all your comments, including the minor complaint about the
commit messages.
I don't intent to send out a v2 here, but the fixed patches should soon
show up in drm-misc-next.
Best regards
Thomas
>
>
> I did a build check here with the archs and config I verifies with.
> This covers "alpha arm arm64 sparc64 i386 x86 powerpc s390 riscv sh"
> and everything was fine. I have a few specific configs to pull in
> drivers that need a bit extra to be built.
> So I consider build coverage OK for applying, but it would be nice to
> wait a few days for the bots to verify too.
>
> My own work on slimming drm_atomic_helper.h and drm_print.h will be
> rebased on top of your work before I continue it.
> I need to look into removing unused includes too.
>
> Sam
>
>>
>> I built this patchset on x86-64, aarch64 and arm. Hopefully I found
>> all include dependencies.
>>
>> Thanks to Sam Ravnborg for bringing this to my attention.
>>
>> Thomas Zimmermann (22):
>> drm/amdgpu: Fix coding style
>> drm: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/amdgpu: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/arm/komeda: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/aspeed: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ast: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/bridge: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/gma500: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/i2c/ch7006: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/ingenic: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/kmb: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/logicvc: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/nouveau: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/radeon: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/rockchip: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/shmobile: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/sprd: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/sun4i: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/tidss: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/udl: Remove unnecessary include statements for drm_crtc_helper.h
>> drm/vboxvideo: Remove unnecessary include statements for
>> drm_crtc_helper.h
>> drm/crtc-helper: Remove most include statements from drm_crtc_helper.h
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
>> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 +
>> drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_crtc.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 1 -
>> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 ++
>> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 ++
>> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 1 -
>> drivers/gpu/drm/arm/display/komeda/komeda_kms.h | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 1 -
>> drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 1 -
>> drivers/gpu/drm/ast/ast_drv.c | 1 -
>> drivers/gpu/drm/ast/ast_main.c | 1 -
>> drivers/gpu/drm/ast/ast_mode.c | 1 -
>> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 1 -
>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 -
>> .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 1 -
>> drivers/gpu/drm/bridge/ite-it6505.c | 1 -
>> drivers/gpu/drm/bridge/ite-it66121.c | 1 -
>> drivers/gpu/drm/bridge/tc358768.c | 1 -
>> drivers/gpu/drm/bridge/tc358775.c | 1 -
>> drivers/gpu/drm/drm_crtc_helper.c | 1 -
>> drivers/gpu/drm/drm_lease.c | 2 +-
>> drivers/gpu/drm/drm_plane_helper.c | 1 -
>> drivers/gpu/drm/gma500/cdv_device.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_crt.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_display.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 +
>> drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/framebuffer.c | 2 ++
>> drivers/gpu/drm/gma500/gma_display.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>> drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 ++
>> drivers/gpu/drm/gma500/oaktrail_lvds.c | 1 +
>> drivers/gpu/drm/gma500/psb_device.c | 1 +
>> drivers/gpu/drm/gma500/psb_intel_display.c | 3 +++
>> drivers/gpu/drm/gma500/psb_intel_drv.h | 1 -
>> drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 ++
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++
>> drivers/gpu/drm/i2c/ch7006_priv.h | 1 -
>> drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 -
>> drivers/gpu/drm/kmb/kmb_crtc.c | 1 -
>> drivers/gpu/drm/kmb/kmb_plane.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_interface.c | 1 -
>> drivers/gpu/drm/logicvc/logicvc_mode.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/crtc.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv04/dac.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/dfp.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvmodesnv17.c | 1 -
>> drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 2 +-
>> drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 1 +
>> drivers/gpu/drm/nouveau/dispnv50/head.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
>> drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
>> drivers/gpu/drm/radeon/atombios_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/atombios_encoders.c | 1 +
>> drivers/gpu/drm/radeon/r300.c | 1 -
>> drivers/gpu/drm/radeon/radeon_asic.c | 1 -
>> drivers/gpu/drm/radeon/radeon_connectors.c | 1 +
>> drivers/gpu/drm/radeon/radeon_display.c | 1 +
>> drivers/gpu/drm/radeon/radeon_drv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_encoders.c | 1 -
>> drivers/gpu/drm/radeon/radeon_irq_kms.c | 1 -
>> drivers/gpu/drm/radeon/radeon_legacy_crtc.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +-
>> drivers/gpu/drm/radeon/radeon_legacy_tv.c | 1 -
>> drivers/gpu/drm/radeon/radeon_mode.h | 2 +-
>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 ++
>> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 1 -
>> drivers/gpu/drm/shmobile/shmob_drm_plane.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dpu.c | 1 -
>> drivers/gpu/drm/sprd/sprd_drm.c | 1 -
>> drivers/gpu/drm/sprd/sprd_dsi.c | 1 -
>> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_crtc.c | 1 -
>> drivers/gpu/drm/tidss/tidss_drv.c | 1 -
>> drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
>> drivers/gpu/drm/tidss/tidss_kms.c | 1 -
>> drivers/gpu/drm/tidss/tidss_plane.c | 1 -
>> drivers/gpu/drm/udl/udl_drv.c | 2 +-
>> drivers/gpu/drm/udl/udl_modeset.c | 1 -
>> drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +-
>> drivers/gpu/drm/vboxvideo/vbox_main.c | 1 -
>> include/drm/drm_crtc_helper.h | 14 +++++++++-----
>> include/drm/drm_fixed.h | 1 +
>> 94 files changed, 70 insertions(+), 70 deletions(-)
>>
>>
>> base-commit: 68d139b609a97a83e7c231189d4864aba4e1679b
>> prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
>> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
>> prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
>> --
>> 2.39.0
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-17 8:45 UTC|newest]
Thread overview: 172+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 13:12 [Nouveau] [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] [PATCH 01/22] drm/amdgpu: Fix coding style Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 18:05 ` Alex Deucher
2023-01-16 18:05 ` Alex Deucher
2023-01-16 18:05 ` Alex Deucher
2023-01-16 18:05 ` Alex Deucher
2023-01-16 18:05 ` Alex Deucher
2023-01-16 18:05 ` [Nouveau] " Alex Deucher
2023-01-16 13:12 ` [Nouveau] [PATCH 02/22] drm: Remove unnecessary include statements for drm_crtc_helper.h Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 20:15 ` Sam Ravnborg
2023-01-16 20:15 ` [Nouveau] " Sam Ravnborg
2023-01-16 20:15 ` Sam Ravnborg
2023-01-16 20:15 ` Sam Ravnborg
2023-01-16 20:15 ` Sam Ravnborg
2023-01-16 20:15 ` Sam Ravnborg
2023-01-16 13:12 ` [Nouveau] [PATCH 03/22] drm/amdgpu: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 20:18 ` Sam Ravnborg
2023-01-16 20:18 ` [Nouveau] " Sam Ravnborg
2023-01-16 20:18 ` Sam Ravnborg
2023-01-16 20:18 ` Sam Ravnborg
2023-01-16 20:18 ` Sam Ravnborg
2023-01-16 20:18 ` Sam Ravnborg
2023-01-16 13:12 ` [Nouveau] [PATCH 04/22] drm/arm/komeda: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] [PATCH 05/22] drm/aspeed: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 20:27 ` Sam Ravnborg
2023-01-16 20:27 ` Sam Ravnborg
2023-01-16 20:27 ` [Nouveau] " Sam Ravnborg
2023-01-16 20:27 ` Sam Ravnborg
2023-01-16 20:27 ` Sam Ravnborg
2023-01-16 20:27 ` Sam Ravnborg
2023-01-16 13:12 ` [Nouveau] [PATCH 06/22] drm/ast: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] [PATCH 07/22] drm/bridge: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 08/22] drm/gma500: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 09/22] drm/i2c/ch7006: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 10/22] drm/ingenic: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 11/22] drm/kmb: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] [PATCH 12/22] drm/logicvc: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] [PATCH 13/22] drm/nouveau: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 14/22] drm/radeon: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 15/22] drm/rockchip: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 16/22] drm/shmobile: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 17/22] drm/sprd: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 18/22] drm/sun4i: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 20:31 ` Sam Ravnborg
2023-01-16 20:31 ` Sam Ravnborg
2023-01-16 20:31 ` Sam Ravnborg
2023-01-16 20:31 ` [Nouveau] " Sam Ravnborg
2023-01-16 20:31 ` Sam Ravnborg
2023-01-16 20:31 ` Sam Ravnborg
2023-01-16 13:12 ` [PATCH 19/22] drm/tidss: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 20/22] drm/udl: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 21/22] drm/vboxvideo: " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [PATCH 22/22] drm/crtc-helper: Remove most include statements from drm_crtc_helper.h Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` Thomas Zimmermann
2023-01-16 13:12 ` [Nouveau] " Thomas Zimmermann
2023-01-16 16:19 ` [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h Jani Nikula
2023-01-16 16:19 ` Jani Nikula
2023-01-16 16:19 ` Jani Nikula
2023-01-16 16:19 ` [Nouveau] " Jani Nikula
2023-01-16 18:37 ` Alex Deucher
2023-01-16 18:37 ` Alex Deucher
2023-01-16 18:37 ` Alex Deucher
2023-01-16 18:37 ` Alex Deucher
2023-01-16 18:37 ` Alex Deucher
2023-01-16 18:37 ` Alex Deucher
2023-01-17 8:41 ` Thomas Zimmermann
2023-01-17 8:41 ` Thomas Zimmermann
2023-01-17 8:41 ` Thomas Zimmermann
2023-01-17 8:41 ` Thomas Zimmermann
2023-01-17 8:41 ` [Nouveau] " Thomas Zimmermann
2023-01-16 20:47 ` Sam Ravnborg
2023-01-16 20:47 ` Sam Ravnborg
2023-01-16 20:47 ` Sam Ravnborg
2023-01-16 20:47 ` Sam Ravnborg
2023-01-16 20:47 ` Sam Ravnborg
2023-01-16 20:47 ` [Nouveau] " Sam Ravnborg
2023-01-17 8:45 ` Thomas Zimmermann [this message]
2023-01-17 8:45 ` Thomas Zimmermann
2023-01-17 8:45 ` Thomas Zimmermann
2023-01-17 8:45 ` Thomas Zimmermann
2023-01-17 8:45 ` Thomas Zimmermann
2023-01-17 8:45 ` [Nouveau] " Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc6366b5-6072-19b7-a2fb-648b6241b67c@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=nouveau@lists.freedesktop.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.