From: Marek Szyprowski <m.szyprowski@samsung.com> To: Sam Protsenko <semen.protsenko@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com> Cc: Tomasz Figa <tomasz.figa@gmail.com>, Alim Akhtar <alim.akhtar@samsung.com>, Chanho Park <chanho61.park@samsung.com>, David Virag <virag.david003@gmail.com>, Sumit Semwal <sumit.semwal@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] clk: samsung: Add PM support for ARM64 Exynos chips Date: Fri, 3 Feb 2023 15:33:27 +0100 [thread overview] Message-ID: <cc9734eb-4157-eea3-90a2-4f7eb36de744@samsung.com> (raw) In-Reply-To: <20230203060924.8257-1-semen.protsenko@linaro.org> On 03.02.2023 07:09, Sam Protsenko wrote: > In order to prepare for PM enablement in clk-exynos850, common PM code > was extracted from clk-exynos5433 to clk-exynos-arm64. Also some related > cleanups were done prior to that. More specifically: > > - patches #1..5: cleanups > - patch #6: PM code extraction > > During the extraction of the exynos5433_cmu_probe() content to > exynos_arm64_register_cmu_pm() some code was reworked a bit, and also > split into smaller functions. In particular: > > - cmu_data structure now contains a pointer to ctx, which is now > allocated in samsung_clk_init() > - cmu_data structure initialization was moved into separate function > - code for configuring gate clocks was added (optional) > > Which in turn resulted in somehow modified code of probe function: > > Original > -------- > > ... > devm_platform_ioremap_resource(...); > samsung_clk_init(...); > exynos_arm64_cmu_prepare_pm(...); > exynos_arm64_enable_bus_clk(...); > platform_set_drvdata(...); > ... > > Modified > -------- > > ... > platform_set_drvdata(...); > exynos_arm64_cmu_prepare_pm(...); > exynos_arm64_enable_bus_clk(...); > exynos_arm64_init_clocks(...); > devm_platform_ioremap_resource(...); > samsung_clk_init(...); > ... > > That shouldn't really change the logic or mode of operation. It was > preliminary tested on Exynos850 based board, with some extra patches on > top of this series (will be submitted later). > > Marek, could you please test these patches on Exynos5433 platform, and > also review accordingly? I've tested and Exynos5433 still works fine after applying your changes. Btw, you should probably rebase your changes onto arm-soc tree (or recent linux-next), as there are some conflicts between your changes and the s3c24xx removal merged there. Feel free to add: Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> I will try to review the individual patches on Monday though. > Thanks! > > Sam Protsenko (6): > clk: samsung: Don't pass reg_base to samsung_clk_register_pll() > clk: samsung: Remove np argument from samsung_clk_init() > clk: samsung: Set dev in samsung_clk_init() > clk: samsung: Extract clocks registration to common function > clk: samsung: Extract parent clock enabling to common function > clk: samsung: exynos5433: Extract PM support to common ARM64 layer > > drivers/clk/samsung/clk-exynos-arm64.c | 219 +++++++++++++++++++++-- > drivers/clk/samsung/clk-exynos-arm64.h | 3 + > drivers/clk/samsung/clk-exynos4.c | 6 +- > drivers/clk/samsung/clk-exynos4412-isp.c | 3 +- > drivers/clk/samsung/clk-exynos5250.c | 5 +- > drivers/clk/samsung/clk-exynos5420.c | 5 +- > drivers/clk/samsung/clk-exynos5433.c | 157 +--------------- > drivers/clk/samsung/clk-pll.c | 11 +- > drivers/clk/samsung/clk-s3c2410.c | 6 +- > drivers/clk/samsung/clk-s3c2412.c | 5 +- > drivers/clk/samsung/clk-s3c2443.c | 6 +- > drivers/clk/samsung/clk-s3c64xx.c | 4 +- > drivers/clk/samsung/clk-s5pv210.c | 6 +- > drivers/clk/samsung/clk.c | 64 ++++--- > drivers/clk/samsung/clk.h | 10 +- > 15 files changed, 282 insertions(+), 228 deletions(-) > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com> To: Sam Protsenko <semen.protsenko@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com> Cc: Tomasz Figa <tomasz.figa@gmail.com>, Alim Akhtar <alim.akhtar@samsung.com>, Chanho Park <chanho61.park@samsung.com>, David Virag <virag.david003@gmail.com>, Sumit Semwal <sumit.semwal@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] clk: samsung: Add PM support for ARM64 Exynos chips Date: Fri, 3 Feb 2023 15:33:27 +0100 [thread overview] Message-ID: <cc9734eb-4157-eea3-90a2-4f7eb36de744@samsung.com> (raw) In-Reply-To: <20230203060924.8257-1-semen.protsenko@linaro.org> On 03.02.2023 07:09, Sam Protsenko wrote: > In order to prepare for PM enablement in clk-exynos850, common PM code > was extracted from clk-exynos5433 to clk-exynos-arm64. Also some related > cleanups were done prior to that. More specifically: > > - patches #1..5: cleanups > - patch #6: PM code extraction > > During the extraction of the exynos5433_cmu_probe() content to > exynos_arm64_register_cmu_pm() some code was reworked a bit, and also > split into smaller functions. In particular: > > - cmu_data structure now contains a pointer to ctx, which is now > allocated in samsung_clk_init() > - cmu_data structure initialization was moved into separate function > - code for configuring gate clocks was added (optional) > > Which in turn resulted in somehow modified code of probe function: > > Original > -------- > > ... > devm_platform_ioremap_resource(...); > samsung_clk_init(...); > exynos_arm64_cmu_prepare_pm(...); > exynos_arm64_enable_bus_clk(...); > platform_set_drvdata(...); > ... > > Modified > -------- > > ... > platform_set_drvdata(...); > exynos_arm64_cmu_prepare_pm(...); > exynos_arm64_enable_bus_clk(...); > exynos_arm64_init_clocks(...); > devm_platform_ioremap_resource(...); > samsung_clk_init(...); > ... > > That shouldn't really change the logic or mode of operation. It was > preliminary tested on Exynos850 based board, with some extra patches on > top of this series (will be submitted later). > > Marek, could you please test these patches on Exynos5433 platform, and > also review accordingly? I've tested and Exynos5433 still works fine after applying your changes. Btw, you should probably rebase your changes onto arm-soc tree (or recent linux-next), as there are some conflicts between your changes and the s3c24xx removal merged there. Feel free to add: Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> I will try to review the individual patches on Monday though. > Thanks! > > Sam Protsenko (6): > clk: samsung: Don't pass reg_base to samsung_clk_register_pll() > clk: samsung: Remove np argument from samsung_clk_init() > clk: samsung: Set dev in samsung_clk_init() > clk: samsung: Extract clocks registration to common function > clk: samsung: Extract parent clock enabling to common function > clk: samsung: exynos5433: Extract PM support to common ARM64 layer > > drivers/clk/samsung/clk-exynos-arm64.c | 219 +++++++++++++++++++++-- > drivers/clk/samsung/clk-exynos-arm64.h | 3 + > drivers/clk/samsung/clk-exynos4.c | 6 +- > drivers/clk/samsung/clk-exynos4412-isp.c | 3 +- > drivers/clk/samsung/clk-exynos5250.c | 5 +- > drivers/clk/samsung/clk-exynos5420.c | 5 +- > drivers/clk/samsung/clk-exynos5433.c | 157 +--------------- > drivers/clk/samsung/clk-pll.c | 11 +- > drivers/clk/samsung/clk-s3c2410.c | 6 +- > drivers/clk/samsung/clk-s3c2412.c | 5 +- > drivers/clk/samsung/clk-s3c2443.c | 6 +- > drivers/clk/samsung/clk-s3c64xx.c | 4 +- > drivers/clk/samsung/clk-s5pv210.c | 6 +- > drivers/clk/samsung/clk.c | 64 ++++--- > drivers/clk/samsung/clk.h | 10 +- > 15 files changed, 282 insertions(+), 228 deletions(-) > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-03 14:33 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20230203060905eucas1p20dc8b2dbf93ec2b0c604bd461afbae94@eucas1p2.samsung.com> 2023-02-03 6:09 ` [PATCH 0/6] clk: samsung: Add PM support for ARM64 Exynos chips Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 1/6] clk: samsung: Don't pass reg_base to samsung_clk_register_pll() Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 2/6] clk: samsung: Remove np argument from samsung_clk_init() Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 3/6] clk: samsung: Set dev in samsung_clk_init() Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 4/6] clk: samsung: Extract clocks registration to common function Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 5/6] clk: samsung: Extract parent clock enabling " Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 9:14 ` Krzysztof Kozlowski 2023-02-03 9:14 ` Krzysztof Kozlowski 2023-02-08 6:00 ` Sam Protsenko 2023-02-08 6:00 ` Sam Protsenko 2023-02-03 6:09 ` [PATCH 6/6] clk: samsung: exynos5433: Extract PM support to common ARM64 layer Sam Protsenko 2023-02-03 6:09 ` Sam Protsenko 2023-02-03 9:18 ` Krzysztof Kozlowski 2023-02-03 9:18 ` Krzysztof Kozlowski 2023-02-08 6:08 ` Sam Protsenko 2023-02-08 6:08 ` Sam Protsenko 2023-02-03 12:19 ` kernel test robot 2023-02-03 12:19 ` kernel test robot 2023-02-03 14:33 ` Marek Szyprowski [this message] 2023-02-03 14:33 ` [PATCH 0/6] clk: samsung: Add PM support for ARM64 Exynos chips Marek Szyprowski 2023-02-08 6:05 ` Sam Protsenko 2023-02-08 6:05 ` Sam Protsenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cc9734eb-4157-eea3-90a2-4f7eb36de744@samsung.com \ --to=m.szyprowski@samsung.com \ --cc=alim.akhtar@samsung.com \ --cc=chanho61.park@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=sumit.semwal@linaro.org \ --cc=tomasz.figa@gmail.com \ --cc=virag.david003@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.