[PATCH] timer: remove unnecessary dependency on likely

[PATCH] timer: remove unnecessary dependency on likely

[Eric Wong]

I don't see likely/unlikely being used by ccan/timer or any of its
dependencies right now.

Running `tools/ccanlint/ccanlint ccan/timer' reveals no regressions

Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 ccan/timer/_info   | 1 -
 ccan/timer/timer.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/ccan/timer/_info b/ccan/timer/_info
index 9f5ec7a2..d76a7e67 100644
--- a/ccan/timer/_info
+++ b/ccan/timer/_info
@@ -70,7 +70,6 @@ int main(int argc, char *argv[])
 	if (strcmp(argv[1], "depends") == 0) {
 		printf("ccan/array_size\n");
 		printf("ccan/ilog\n");
-		printf("ccan/likely\n");
 		printf("ccan/list\n");
 		printf("ccan/time\n");
 		return 0;
diff --git a/ccan/timer/timer.c b/ccan/timer/timer.c
index 91f46393..84d7aa14 100644
--- a/ccan/timer/timer.c
+++ b/ccan/timer/timer.c
@@ -2,7 +2,6 @@
 #include <ccan/timer/timer.h>
 #include <ccan/array_size/array_size.h>
 #include <ccan/ilog/ilog.h>
-#include <ccan/likely/likely.h>
 #include <stdlib.h>
 #include <stdio.h>
 
-- 
EW
_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan

Re: [PATCH] timer: remove unnecessary dependency on likely

[David Gibson]

[-- Attachment #1.1: Type: text/plain, Size: 1381 bytes --]

On Fri, Jun 08, 2018 at 02:45:42AM +0000, Eric Wong wrote:
> I don't see likely/unlikely being used by ccan/timer or any of its
> dependencies right now.
> 
> Running `tools/ccanlint/ccanlint ccan/timer' reveals no regressions
> 
> Signed-off-by: Eric Wong <normalperson@yhbt.net>

Applied, thanks.

> ---
>  ccan/timer/_info   | 1 -
>  ccan/timer/timer.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/ccan/timer/_info b/ccan/timer/_info
> index 9f5ec7a2..d76a7e67 100644
> --- a/ccan/timer/_info
> +++ b/ccan/timer/_info
> @@ -70,7 +70,6 @@ int main(int argc, char *argv[])
>  	if (strcmp(argv[1], "depends") == 0) {
>  		printf("ccan/array_size\n");
>  		printf("ccan/ilog\n");
> -		printf("ccan/likely\n");
>  		printf("ccan/list\n");
>  		printf("ccan/time\n");
>  		return 0;
> diff --git a/ccan/timer/timer.c b/ccan/timer/timer.c
> index 91f46393..84d7aa14 100644
> --- a/ccan/timer/timer.c
> +++ b/ccan/timer/timer.c
> @@ -2,7 +2,6 @@
>  #include <ccan/timer/timer.h>
>  #include <ccan/array_size/array_size.h>
>  #include <ccan/ilog/ilog.h>
> -#include <ccan/likely/likely.h>
>  #include <stdlib.h>
>  #include <stdio.h>
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
ccan mailing list
ccan@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/ccan