From: Thomas Zimmermann <tzimmermann@suse.de> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: alexandre.belloni@bootlin.com, linux-aspeed@lists.ozlabs.org, "Neil Armstrong" <narmstrong@baylibre.com>, "Dave Airlie" <airlied@linux.ie>, "Liviu Dudau" <liviu.dudau@arm.com>, "ML dri-devel" <dri-devel@lists.freedesktop.org>, "Paul Cercueil" <paul@crapouillou.net>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, "Mihail Atanassov" <mihail.atanassov@arm.com>, "Sam Ravnborg" <sam@ravnborg.org>, "Marek Vašut" <marex@denx.de>, khilman@baylibre.com, "Alexey Brodkin" <abrodkin@synopsys.com>, "Xinwei Kong" <kong.kongxinwei@hisilicon.com>, "Xinliang Liu" <xinliang.liu@linaro.org>, ludovic.desroches@microchip.com, "Tomi Valkeinen" <tomi.valkeinen@ti.com>, "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>, "NXP Linux Team" <linux-imx@nxp.com>, joel@jms.id.au, "Alexandre Torgue" <alexandre.torgue@st.com>, "Chen Feng" <puck.chen@hisilicon.com>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Alison Wang" <alison.wang@nxp.com>, "Jyri Sarha" <jsarha@ti.com>, "Chen-Yu Tsai" <wens@csie.org>, "Vincent Abriou" <vincent.abriou@st.com>, LAKML <linux-arm-kernel@lists.infradead.org>, "Maxime Coquelin" <mcoquelin.stm32@gmail.com>, bbrezillon@kernel.org, andrew@aj.id.au, "Philippe Cornu" <philippe.cornu@st.com>, "Yannick Fertre" <yannick.fertre@st.com>, "Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>, "Sascha Hauer" <kernel@pengutronix.de>, "Rongrong Zou" <zourongrong@gmail.com>, "Shawn Guo" <shawnguo@kernel.org> Subject: Re: [PATCH 07/21] drm/hisilicon/kirin: Use GEM CMA object functions Date: Mon, 25 May 2020 14:41:54 +0200 [thread overview] Message-ID: <ccee78e2-8930-2de6-0b7c-0f1ad1e636f8@suse.de> (raw) In-Reply-To: <CACvgo51cYh4iLKEfrLSbgOGQM4=ojsBq54gW9VJBPoX+p04o+g@mail.gmail.com> [-- Attachment #1.1.1: Type: text/plain, Size: 2335 bytes --] Hi Emil Am 22.05.20 um 20:11 schrieb Emil Velikov: > Hi Thomas, > > On Fri, 22 May 2020 at 14:53, Thomas Zimmermann <tzimmermann@suse.de> wrote: >> >> The kirin driver uses the default implementation for CMA functions; except >> for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets >> these defaults and .dumb_create in struct drm_driver. All remaining >> operations are provided by CMA GEM object functions. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> --- >> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 +----------- >> 1 file changed, 1 insertion(+), 11 deletions(-) >> >> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> index c339e632522a9..b1ffd7d43e562 100644 >> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> @@ -921,17 +921,7 @@ DEFINE_DRM_GEM_CMA_FOPS(ade_fops); >> static struct drm_driver ade_driver = { >> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, >> .fops = &ade_fops, >> - .gem_free_object_unlocked = drm_gem_cma_free_object, >> - .gem_vm_ops = &drm_gem_cma_vm_ops, >> - .dumb_create = drm_gem_cma_dumb_create_internal, > > This doesn't seem right. The _internal documentation explicitly says > that this should _not_ be used as .dumb_create. Instead drivers should > use it to implement their callback. > > Since it yields the same result as drm_gem_cma_dumb_create we can use > the default macro below. I noticed this and thought that the driver authors probably had their reasons. Changing the driver to the default macro is probably still a good idea. Best regards Thomas > > Weather to the .dumb_create in separate patch, or squash it here - > I'll leave to you. > In case of the latter, please mentioned it in the commit message. > > -Emil > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: alexandre.belloni@bootlin.com, linux-aspeed@lists.ozlabs.org, "Neil Armstrong" <narmstrong@baylibre.com>, "Dave Airlie" <airlied@linux.ie>, "Liviu Dudau" <liviu.dudau@arm.com>, "ML dri-devel" <dri-devel@lists.freedesktop.org>, nicolas.ferre@microchip.com, "Paul Cercueil" <paul@crapouillou.net>, "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>, "Mihail Atanassov" <mihail.atanassov@arm.com>, "Sam Ravnborg" <sam@ravnborg.org>, "Marek Vašut" <marex@denx.de>, khilman@baylibre.com, "Alexey Brodkin" <abrodkin@synopsys.com>, "Xinwei Kong" <kong.kongxinwei@hisilicon.com>, "Xinliang Liu" <xinliang.liu@linaro.org>, ludovic.desroches@microchip.com, "Tomi Valkeinen" <tomi.valkeinen@ti.com>, "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>, "NXP Linux Team" <linux-imx@nxp.com>, joel@jms.id.au, "Alexandre Torgue" <alexandre.torgue@st.com>, "Chen Feng" <puck.chen@hisilicon.com>, "Sascha Hauer" <s.hauer@pengutronix.de>, "Alison Wang" <alison.wang@nxp.com>, "Jyri Sarha" <jsarha@ti.com>, "Chen-Yu Tsai" <wens@csie.org>, "Vincent Abriou" <vincent.abriou@st.com>, LAKML <linux-arm-kernel@lists.infradead.org>, "Maxime Coquelin" <mcoquelin.stm32@gmail.com>, bbrezillon@kernel.org, andrew@aj.id.au, "Philippe Cornu" <philippe.cornu@st.com>, "Yannick Fertre" <yannick.fertre@st.com>, "Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>, "Sascha Hauer" <kernel@pengutronix.de>, "Rongrong Zou" <zourongrong@gmail.com>, "Shawn Guo" <shawnguo@kernel.org> Subject: Re: [PATCH 07/21] drm/hisilicon/kirin: Use GEM CMA object functions Date: Mon, 25 May 2020 14:41:54 +0200 [thread overview] Message-ID: <ccee78e2-8930-2de6-0b7c-0f1ad1e636f8@suse.de> (raw) In-Reply-To: <CACvgo51cYh4iLKEfrLSbgOGQM4=ojsBq54gW9VJBPoX+p04o+g@mail.gmail.com> [-- Attachment #1.1.1: Type: text/plain, Size: 2335 bytes --] Hi Emil Am 22.05.20 um 20:11 schrieb Emil Velikov: > Hi Thomas, > > On Fri, 22 May 2020 at 14:53, Thomas Zimmermann <tzimmermann@suse.de> wrote: >> >> The kirin driver uses the default implementation for CMA functions; except >> for the .dumb_create callback. The __DRM_GEM_CMA_DRIVER_OPS macro now sets >> these defaults and .dumb_create in struct drm_driver. All remaining >> operations are provided by CMA GEM object functions. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> >> --- >> drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 +----------- >> 1 file changed, 1 insertion(+), 11 deletions(-) >> >> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> index c339e632522a9..b1ffd7d43e562 100644 >> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c >> @@ -921,17 +921,7 @@ DEFINE_DRM_GEM_CMA_FOPS(ade_fops); >> static struct drm_driver ade_driver = { >> .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, >> .fops = &ade_fops, >> - .gem_free_object_unlocked = drm_gem_cma_free_object, >> - .gem_vm_ops = &drm_gem_cma_vm_ops, >> - .dumb_create = drm_gem_cma_dumb_create_internal, > > This doesn't seem right. The _internal documentation explicitly says > that this should _not_ be used as .dumb_create. Instead drivers should > use it to implement their callback. > > Since it yields the same result as drm_gem_cma_dumb_create we can use > the default macro below. I noticed this and thought that the driver authors probably had their reasons. Changing the driver to the default macro is probably still a good idea. Best regards Thomas > > Weather to the .dumb_create in separate patch, or squash it here - > I'll leave to you. > In case of the latter, please mentioned it in the commit message. > > -Emil > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-25 12:42 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-22 13:52 [PATCH 00/21] drm: Convert most CMA-based drivers to GEM object functions Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 01/21] drm/cma-helper: Rework DRM_GEM_CMA_VMAP_DRIVER_OPS macro Thomas Zimmermann 2020-05-22 17:48 ` Sam Ravnborg 2020-05-22 17:48 ` Sam Ravnborg 2020-05-22 18:15 ` Emil Velikov 2020-05-22 18:15 ` Emil Velikov 2020-05-22 18:45 ` Sam Ravnborg 2020-05-22 18:45 ` Sam Ravnborg 2020-05-22 19:48 ` Laurent Pinchart 2020-05-22 19:48 ` Laurent Pinchart 2020-05-25 12:03 ` Thomas Zimmermann 2020-05-25 12:03 ` Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 02/21] drm/arc: Use GEM CMA object functions Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 03/21] drm/arm: " Thomas Zimmermann 2020-05-26 23:30 ` Liviu Dudau 2020-05-26 23:30 ` Liviu Dudau 2020-05-22 13:52 ` [PATCH 04/21] drm/aspeed: Set driver CMA functions with DRM_GEM_CMA_DRIVER_OPS Thomas Zimmermann 2020-10-09 7:54 ` Joel Stanley 2020-10-09 7:54 ` Joel Stanley 2020-10-09 8:01 ` Thomas Zimmermann 2020-10-09 8:01 ` Thomas Zimmermann 2020-10-09 8:06 ` Joel Stanley 2020-10-09 8:06 ` Joel Stanley 2020-10-09 8:26 ` Thomas Zimmermann 2020-10-09 8:26 ` Thomas Zimmermann 2020-10-09 10:45 ` Joel Stanley 2020-10-09 10:45 ` Joel Stanley 2020-05-22 13:52 ` [PATCH 05/21] drm/atmel-hlcdc: Use GEM CMA object functions Thomas Zimmermann 2020-05-22 18:08 ` Sam Ravnborg 2020-05-22 18:08 ` Sam Ravnborg 2020-05-25 12:10 ` Thomas Zimmermann 2020-05-25 12:10 ` Thomas Zimmermann 2020-05-22 19:25 ` Sam Ravnborg 2020-05-22 19:25 ` Sam Ravnborg 2020-05-25 12:37 ` Thomas Zimmermann 2020-05-25 12:37 ` Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 06/21] drm/fsl-dcu: " Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 07/21] drm/hisilicon/kirin: " Thomas Zimmermann 2020-05-22 18:11 ` Emil Velikov 2020-05-25 12:41 ` Thomas Zimmermann [this message] 2020-05-25 12:41 ` Thomas Zimmermann 2020-05-28 14:34 ` Emil Velikov 2020-05-28 14:34 ` Emil Velikov 2020-05-22 13:52 ` [PATCH 08/21] drm/imx: " Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 09/21] drm/ingenic: " Thomas Zimmermann 2020-05-27 0:28 ` Paul Cercueil 2020-05-27 0:28 ` Paul Cercueil 2020-05-22 13:52 ` [PATCH 10/21] drm/komeda: " Thomas Zimmermann 2020-05-26 23:33 ` Liviu Dudau 2020-05-26 23:33 ` Liviu Dudau 2020-05-22 13:52 ` [PATCH 11/21] drm/malidp: " Thomas Zimmermann 2020-05-26 23:33 ` Liviu Dudau 2020-05-26 23:33 ` Liviu Dudau 2020-05-22 13:52 ` [PATCH 12/21] drm/mcde: " Thomas Zimmermann 2020-05-25 11:36 ` Linus Walleij 2020-05-25 11:36 ` Linus Walleij 2020-05-25 12:51 ` Thomas Zimmermann 2020-05-25 12:51 ` Thomas Zimmermann 2020-05-25 13:08 ` Linus Walleij 2020-05-25 13:08 ` Linus Walleij 2020-05-25 13:27 ` Thomas Zimmermann 2020-05-25 13:27 ` Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 13/21] drm/meson: " Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 14/21] drm/mxsfb: " Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 15/21] drm/rcar-du: " Thomas Zimmermann 2020-05-22 20:12 ` Laurent Pinchart 2020-05-22 20:12 ` Laurent Pinchart 2020-05-25 12:49 ` Thomas Zimmermann 2020-05-25 12:49 ` Thomas Zimmermann 2020-05-25 15:38 ` Kieran Bingham 2020-05-25 15:38 ` Kieran Bingham 2020-06-03 7:48 ` Thomas Zimmermann 2020-06-03 7:48 ` Thomas Zimmermann 2020-05-26 1:50 ` Laurent Pinchart 2020-05-26 1:50 ` Laurent Pinchart 2020-05-22 13:52 ` [PATCH 16/21] drm/shmobile: " Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 17/21] drm/stm: " Thomas Zimmermann 2020-05-26 13:22 ` Philippe CORNU 2020-05-26 13:22 ` Philippe CORNU 2020-05-22 13:52 ` [PATCH 18/21] drm/sti: " Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 19/21] drm/tilcdc: " Thomas Zimmermann 2020-05-22 13:52 ` [PATCH 20/21] drm/tv200: " Thomas Zimmermann 2020-05-25 11:36 ` Linus Walleij 2020-05-25 11:36 ` Linus Walleij 2020-05-22 13:52 ` [PATCH 21/21] drm/zte: " Thomas Zimmermann 2020-05-22 19:03 ` Sam Ravnborg 2020-05-22 19:03 ` Sam Ravnborg 2020-05-24 14:50 ` kbuild test robot 2020-05-24 14:50 ` kbuild test robot 2020-05-24 20:11 ` kbuild test robot 2020-05-24 20:11 ` kbuild test robot 2020-05-22 18:19 ` [PATCH 00/21] drm: Convert most CMA-based drivers to GEM " Emil Velikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ccee78e2-8930-2de6-0b7c-0f1ad1e636f8@suse.de \ --to=tzimmermann@suse.de \ --cc=abrodkin@synopsys.com \ --cc=airlied@linux.ie \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@st.com \ --cc=alison.wang@nxp.com \ --cc=andrew@aj.id.au \ --cc=bbrezillon@kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.l.velikov@gmail.com \ --cc=james.qian.wang@arm.com \ --cc=joel@jms.id.au \ --cc=jsarha@ti.com \ --cc=kernel@pengutronix.de \ --cc=khilman@baylibre.com \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=kong.kongxinwei@hisilicon.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-imx@nxp.com \ --cc=liviu.dudau@arm.com \ --cc=ludovic.desroches@microchip.com \ --cc=marex@denx.de \ --cc=mcoquelin.stm32@gmail.com \ --cc=mihail.atanassov@arm.com \ --cc=narmstrong@baylibre.com \ --cc=paul@crapouillou.net \ --cc=philippe.cornu@st.com \ --cc=puck.chen@hisilicon.com \ --cc=s.hauer@pengutronix.de \ --cc=sam@ravnborg.org \ --cc=shawnguo@kernel.org \ --cc=tomi.valkeinen@ti.com \ --cc=vincent.abriou@st.com \ --cc=wens@csie.org \ --cc=xinliang.liu@linaro.org \ --cc=yannick.fertre@st.com \ --cc=zourongrong@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.