From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] pinctrl: pinconf-generic: Infer map type from DT property
Date: Wed, 12 Nov 2014 18:46:26 +0000 [thread overview]
Message-ID: <ce4400ac9091437aa7da16ea131c65cd@BN1BFFO11FD005.protection.gbl> (raw)
In-Reply-To: <CACRpkdbOLMT1vfFg=CAU_VHdjxPWn_Ybso=+8Asp=mXhmNBRSA@mail.gmail.com>
On Tue, 2014-11-11 at 01:47PM +0100, Linus Walleij wrote:
> On Mon, Nov 3, 2014 at 8:05 PM, Soren Brinkmann
> <soren.brinkmann@xilinx.com> wrote:
>
> > With the new 'groups' property, the DT parser can infer the map type
> > from the fact whether 'pins' or 'groups' is used to specify the pin
> > group to work on.
> > To maintain backwards compatibitliy with current usage of the DT
> > binding, this is only done when an invalid map type is passed to the
> > parsing function.
>
> So that is this:
>
> > + if (type = PIN_MAP_TYPE_INVALID)
> > + type = PIN_MAP_TYPE_CONFIGS_GROUP;
> > + dt_pin_specifier = "groups";
>
> This is just kludgy. There are only two kernel-internal users of this function,
> refactor the function signature and change the other callers over instead,
> patch the drivers.
As I said in my other email. I chose to maintain current behavior to
avoid disturbing current users. If changing this the way you suggest,
works for everybody that is clearly preferred.
>
> Take this opportunity to add some kerneldoc above the
> pinconf_generic_dt_subnode_to_map() and give the function a
> reasonable signature.
Yeah, didn't want to put too much effort into it without a confirmation
of this being on the right track.
>
> BTW: this is just for config settings for groups right? Not for muxing
> I hope?
Yep, when 'function' is found, the pins/groups are passed to
pinctrl_utils_add_map_mux() which always uses mux group as type.
Sören
WARNING: multiple messages have this Message-ID (diff)
From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Michal Simek <michal.simek@xilinx.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Alessandro Rubini <rubini@unipv.it>,
Heiko Stuebner <heiko@sntech.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
<linux-rockchip@lists.infradead.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 2/7] pinctrl: pinconf-generic: Infer map type from DT property
Date: Wed, 12 Nov 2014 10:46:26 -0800 [thread overview]
Message-ID: <ce4400ac9091437aa7da16ea131c65cd@BN1BFFO11FD005.protection.gbl> (raw)
In-Reply-To: <CACRpkdbOLMT1vfFg=CAU_VHdjxPWn_Ybso=+8Asp=mXhmNBRSA@mail.gmail.com>
On Tue, 2014-11-11 at 01:47PM +0100, Linus Walleij wrote:
> On Mon, Nov 3, 2014 at 8:05 PM, Soren Brinkmann
> <soren.brinkmann@xilinx.com> wrote:
>
> > With the new 'groups' property, the DT parser can infer the map type
> > from the fact whether 'pins' or 'groups' is used to specify the pin
> > group to work on.
> > To maintain backwards compatibitliy with current usage of the DT
> > binding, this is only done when an invalid map type is passed to the
> > parsing function.
>
> So that is this:
>
> > + if (type == PIN_MAP_TYPE_INVALID)
> > + type = PIN_MAP_TYPE_CONFIGS_GROUP;
> > + dt_pin_specifier = "groups";
>
> This is just kludgy. There are only two kernel-internal users of this function,
> refactor the function signature and change the other callers over instead,
> patch the drivers.
As I said in my other email. I chose to maintain current behavior to
avoid disturbing current users. If changing this the way you suggest,
works for everybody that is clearly preferred.
>
> Take this opportunity to add some kerneldoc above the
> pinconf_generic_dt_subnode_to_map() and give the function a
> reasonable signature.
Yeah, didn't want to put too much effort into it without a confirmation
of this being on the right track.
>
> BTW: this is just for config settings for groups right? Not for muxing
> I hope?
Yep, when 'function' is found, the pins/groups are passed to
pinctrl_utils_add_map_mux() which always uses mux group as type.
Sören
WARNING: multiple messages have this Message-ID (diff)
From: soren.brinkmann@xilinx.com (Sören Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] pinctrl: pinconf-generic: Infer map type from DT property
Date: Wed, 12 Nov 2014 10:46:26 -0800 [thread overview]
Message-ID: <ce4400ac9091437aa7da16ea131c65cd@BN1BFFO11FD005.protection.gbl> (raw)
In-Reply-To: <CACRpkdbOLMT1vfFg=CAU_VHdjxPWn_Ybso=+8Asp=mXhmNBRSA@mail.gmail.com>
On Tue, 2014-11-11 at 01:47PM +0100, Linus Walleij wrote:
> On Mon, Nov 3, 2014 at 8:05 PM, Soren Brinkmann
> <soren.brinkmann@xilinx.com> wrote:
>
> > With the new 'groups' property, the DT parser can infer the map type
> > from the fact whether 'pins' or 'groups' is used to specify the pin
> > group to work on.
> > To maintain backwards compatibitliy with current usage of the DT
> > binding, this is only done when an invalid map type is passed to the
> > parsing function.
>
> So that is this:
>
> > + if (type == PIN_MAP_TYPE_INVALID)
> > + type = PIN_MAP_TYPE_CONFIGS_GROUP;
> > + dt_pin_specifier = "groups";
>
> This is just kludgy. There are only two kernel-internal users of this function,
> refactor the function signature and change the other callers over instead,
> patch the drivers.
As I said in my other email. I chose to maintain current behavior to
avoid disturbing current users. If changing this the way you suggest,
works for everybody that is clearly preferred.
>
> Take this opportunity to add some kerneldoc above the
> pinconf_generic_dt_subnode_to_map() and give the function a
> reasonable signature.
Yeah, didn't want to put too much effort into it without a confirmation
of this being on the right track.
>
> BTW: this is just for config settings for groups right? Not for muxing
> I hope?
Yep, when 'function' is found, the pins/groups are passed to
pinctrl_utils_add_map_mux() which always uses mux group as type.
S?ren
next prev parent reply other threads:[~2014-11-12 18:46 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 19:05 [PATCH 0/7] Pinctrl support for Zynq Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` [PATCH 1/7] pinctrl: pinconf-generic: Declare dt_params/conf_items const Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-11 12:00 ` Linus Walleij
2014-11-11 12:00 ` Linus Walleij
2014-11-11 12:00 ` Linus Walleij
2014-11-03 19:05 ` [PATCH 2/7] pinctrl: pinconf-generic: Infer map type from DT property Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-05 13:56 ` Laurent Pinchart
2014-11-05 13:56 ` Laurent Pinchart
2014-11-05 13:56 ` Laurent Pinchart
2014-11-05 18:09 ` Sören Brinkmann
2014-11-05 18:09 ` Sören Brinkmann
2014-11-05 18:09 ` Sören Brinkmann
2014-11-05 18:17 ` Laurent Pinchart
2014-11-05 18:17 ` Laurent Pinchart
2014-11-05 18:17 ` Laurent Pinchart
2014-11-11 12:29 ` Linus Walleij
2014-11-11 12:29 ` Linus Walleij
2014-11-11 12:29 ` Linus Walleij
2014-11-12 18:43 ` Sören Brinkmann
2014-11-12 18:43 ` Sören Brinkmann
2014-11-12 18:43 ` Sören Brinkmann
2014-11-11 12:47 ` Linus Walleij
2014-11-11 12:47 ` Linus Walleij
2014-11-11 12:47 ` Linus Walleij
2014-11-12 18:46 ` Sören Brinkmann [this message]
2014-11-12 18:46 ` Sören Brinkmann
2014-11-12 18:46 ` Sören Brinkmann
2014-11-12 19:38 ` Sören Brinkmann
2014-11-12 19:38 ` Sören Brinkmann
2014-11-12 19:38 ` Sören Brinkmann
2014-11-03 19:05 ` [PATCH 3/7] pinctrl: pinconf-generic: Allow driver to specify DT params Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:12 ` Geert Uytterhoeven
2014-11-03 19:12 ` Geert Uytterhoeven
2014-11-03 19:12 ` Geert Uytterhoeven
2014-11-11 14:53 ` Linus Walleij
2014-11-11 14:53 ` Linus Walleij
2014-11-11 14:53 ` Linus Walleij
2014-11-18 8:50 ` Ivan T. Ivanov
2014-11-18 8:50 ` Ivan T. Ivanov
2014-11-18 8:50 ` Ivan T. Ivanov
2014-11-18 17:25 ` Sören Brinkmann
2014-11-18 17:25 ` Sören Brinkmann
2014-11-18 17:25 ` Sören Brinkmann
2014-11-19 7:49 ` Ivan T. Ivanov
2014-11-19 7:49 ` Ivan T. Ivanov
2014-11-19 7:49 ` Ivan T. Ivanov
2014-11-19 15:35 ` Sören Brinkmann
2014-11-19 15:35 ` Sören Brinkmann
2014-11-19 15:35 ` Sören Brinkmann
2014-11-20 8:06 ` Ivan T. Ivanov
2014-11-20 8:06 ` Ivan T. Ivanov
2014-11-20 8:06 ` Ivan T. Ivanov
2014-11-20 16:22 ` Sören Brinkmann
2014-11-20 16:22 ` Sören Brinkmann
2014-11-20 16:22 ` Sören Brinkmann
2014-11-21 7:35 ` Ivan T. Ivanov
2014-11-21 7:35 ` Ivan T. Ivanov
2014-11-21 7:35 ` Ivan T. Ivanov
2014-11-22 16:06 ` Sören Brinkmann
2014-11-22 16:06 ` Sören Brinkmann
2014-11-22 16:06 ` Sören Brinkmann
2014-11-24 8:52 ` Ivan T. Ivanov
2014-11-24 8:52 ` Ivan T. Ivanov
2014-11-24 8:52 ` Ivan T. Ivanov
2014-11-27 17:53 ` Sören Brinkmann
2014-11-27 17:53 ` Sören Brinkmann
2014-11-27 17:53 ` Sören Brinkmann
2014-11-03 19:05 ` [PATCH 4/7] pinctrl: zynq: Document DT binding Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-05 3:35 ` Andreas Färber
2014-11-05 3:35 ` Andreas Färber
2014-11-05 3:35 ` Andreas Färber
2014-11-05 17:07 ` Sören Brinkmann
2014-11-05 17:07 ` Sören Brinkmann
2014-11-05 17:07 ` Sören Brinkmann
2014-11-11 15:00 ` Linus Walleij
2014-11-11 15:00 ` Linus Walleij
2014-11-11 15:00 ` Linus Walleij
2014-11-12 18:53 ` Sören Brinkmann
2014-11-12 18:53 ` Sören Brinkmann
2014-11-12 18:53 ` Sören Brinkmann
2014-11-27 13:10 ` Linus Walleij
2014-11-27 13:10 ` Linus Walleij
2014-11-27 13:10 ` Linus Walleij
2014-11-03 19:05 ` [PATCH 5/7] pinctrl: Add driver for Zynq Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-05 3:24 ` Andreas Färber
2014-11-05 3:24 ` Andreas Färber
2014-11-05 3:24 ` Andreas Färber
2014-11-05 17:10 ` Sören Brinkmann
2014-11-05 17:10 ` Sören Brinkmann
2014-11-05 17:10 ` Sören Brinkmann
2014-11-05 5:12 ` Andreas Färber
2014-11-05 5:12 ` Andreas Färber
2014-11-05 5:12 ` Andreas Färber
2014-11-05 17:14 ` Sören Brinkmann
2014-11-05 17:14 ` Sören Brinkmann
2014-11-05 17:14 ` Sören Brinkmann
2014-11-03 19:05 ` [PATCH 6/7] ARM: zynq: Enable pinctrl Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` [PATCH 7/7] ARM: zynq: DT: Add pinctrl information Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-03 19:05 ` Soren Brinkmann
2014-11-05 5:56 ` [PATCH 0/7] Pinctrl support for Zynq Andreas Färber
2014-11-05 5:56 ` Andreas Färber
2014-11-05 5:56 ` Andreas Färber
2014-11-05 17:03 ` Sören Brinkmann
2014-11-05 17:03 ` Sören Brinkmann
2014-11-05 17:03 ` Sören Brinkmann
2014-11-06 3:51 ` Andreas Färber
2014-11-06 3:51 ` Andreas Färber
2014-11-06 3:51 ` Andreas Färber
2014-11-06 4:13 ` Sören Brinkmann
2014-11-06 4:13 ` Sören Brinkmann
2014-11-06 4:13 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce4400ac9091437aa7da16ea131c65cd@BN1BFFO11FD005.protection.gbl \
--to=soren.brinkmann@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.