"Signed-off-by" jenkins job for PRs now failing

"Signed-off-by" jenkins job for PRs now failing

[Alfonso Martinez Hidalgo]

Hi All,

It seems that this job has started to fail on several PRs.
Does anyone have privileges to fix this error?

============================= test session starts ==============================
platform linux2 -- Python 2.7.12, pytest-4.6.11, py-1.9.0,
pluggy-0.13.1 -- /tmp/venv.4M9HM0FOIP/bin/python2.7
cachedir: .pytest_cache
rootdir: /home/jenkins-build/build/workspace/ceph-pr-commits
collecting ... collected 2 items / 1 deselected / 1 selected

ceph-build/ceph-pr-commits/build/test_commits.py::TestCommits::test_signed_off_by
Running command: git fetch origin
+refs/heads/master:refs/remotes/origin/master
Running command: git log -z --no-merges origin/master..HEAD
FAILED

=================================== FAILURES ===================================
________________________ TestCommits.test_signed_off_by ________________________

self = <test_commits.TestCommits object at 0x7f95779c8190>

    @pytest.mark.code_test
    def test_signed_off_by(self):
        signed_off_regex = r'Signed-off-by: \S.* <[^@]+@[^@]+\.[^@]+>'
        # '-z' puts a '\0' between commits, see later split('\0')
        check_signed_off_commits = 'git log -z --no-merges origin/%s..%s' % (
            self.target_branch, self.source_branch)
        wrong_commits = list(filterfalse(
            re.compile(signed_off_regex).search,
>           self.command(check_signed_off_commits).split('\0')))

ceph-build/ceph-pr-commits/build/test_commits.py:63:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

cls = <class 'test_commits.TestCommits'>
command = 'git log -z --no-merges origin/master..HEAD'

    @classmethod
    def command(cls, command):
        print("Running command:", command)
>       return check_output(shlex.split(command), cwd=cls.ceph_checkout).decode()
E       UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in
position 68: ordinal not in range(128)

ceph-build/ceph-pr-commits/build/test_commits.py:29: UnicodeDecodeError
- generated xml file:
/home/jenkins-build/build/workspace/ceph-pr-commits/report.xml -
==================== 1 failed, 1 deselected in 0.60 seconds ====================
Build step 'Execute shell' marked build as failure


Regards,
-- 

Alfonso Martínez
Senior Software Engineer, Ceph Storage
Red Hat

Re: "Signed-off-by" jenkins job for PRs now failing

[Ken Dreyer]

I thought we were going to switch over to https://github.com/apps/dco
? Is that still the case?

- Ken

On Wed, Oct 7, 2020 at 2:25 AM Alfonso Martinez Hidalgo
<almartin@redhat.com> wrote:
>
> Hi All,
>
> It seems that this job has started to fail on several PRs.
> Does anyone have privileges to fix this error?
>
> ============================= test session starts ==============================
> platform linux2 -- Python 2.7.12, pytest-4.6.11, py-1.9.0,
> pluggy-0.13.1 -- /tmp/venv.4M9HM0FOIP/bin/python2.7
> cachedir: .pytest_cache
> rootdir: /home/jenkins-build/build/workspace/ceph-pr-commits
> collecting ... collected 2 items / 1 deselected / 1 selected
>
> ceph-build/ceph-pr-commits/build/test_commits.py::TestCommits::test_signed_off_by
> Running command: git fetch origin
> +refs/heads/master:refs/remotes/origin/master
> Running command: git log -z --no-merges origin/master..HEAD
> FAILED
>
> =================================== FAILURES ===================================
> ________________________ TestCommits.test_signed_off_by ________________________
>
> self = <test_commits.TestCommits object at 0x7f95779c8190>
>
>     @pytest.mark.code_test
>     def test_signed_off_by(self):
>         signed_off_regex = r'Signed-off-by: \S.* <[^@]+@[^@]+\.[^@]+>'
>         # '-z' puts a '\0' between commits, see later split('\0')
>         check_signed_off_commits = 'git log -z --no-merges origin/%s..%s' % (
>             self.target_branch, self.source_branch)
>         wrong_commits = list(filterfalse(
>             re.compile(signed_off_regex).search,
> >           self.command(check_signed_off_commits).split('\0')))
>
> ceph-build/ceph-pr-commits/build/test_commits.py:63:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
> cls = <class 'test_commits.TestCommits'>
> command = 'git log -z --no-merges origin/master..HEAD'
>
>     @classmethod
>     def command(cls, command):
>         print("Running command:", command)
> >       return check_output(shlex.split(command), cwd=cls.ceph_checkout).decode()
> E       UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in
> position 68: ordinal not in range(128)
>
> ceph-build/ceph-pr-commits/build/test_commits.py:29: UnicodeDecodeError
> - generated xml file:
> /home/jenkins-build/build/workspace/ceph-pr-commits/report.xml -
> ==================== 1 failed, 1 deselected in 0.60 seconds ====================
> Build step 'Execute shell' marked build as failure
>
>
> Regards,
> --
>
> Alfonso Martínez
> Senior Software Engineer, Ceph Storage
> Red Hat
>