* [PATCH] ceph: demote quotarealm lookup warning to a debug message
@ 2020-05-05 12:59 Luis Henriques
2020-05-05 14:55 ` Jeff Layton
2020-05-07 13:44 ` Jeff Layton
0 siblings, 2 replies; 4+ messages in thread
From: Luis Henriques @ 2020-05-05 12:59 UTC (permalink / raw)
To: Jeff Layton, Ilya Dryomov, Gregory Farnum; +Cc: ceph-devel, linux-kernel
A misconfigured cephx can easily result in having the kernel client
flooding the logs with:
ceph: Can't lookup inode 1 (err: -13)
Change his message to debug level.
Link: https://tracker.ceph.com/issues/44546
Signed-off-by: Luis Henriques <lhenriques@suse.com>
---
Hi!
This patch should fix some harmless warnings when using cephx to restrict
users access to certain filesystem paths. I've added a comment to the
tracker where removing this warning could result (unlikely, IMHO!) in an
admin to miss not-so-harmless bogus configurations.
Cheers,
--
Luís
fs/ceph/quota.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ceph/quota.c b/fs/ceph/quota.c
index de56dee60540..19507e2fdb57 100644
--- a/fs/ceph/quota.c
+++ b/fs/ceph/quota.c
@@ -159,8 +159,8 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc,
}
if (IS_ERR(in)) {
- pr_warn("Can't lookup inode %llx (err: %ld)\n",
- realm->ino, PTR_ERR(in));
+ dout("Can't lookup inode %llx (err: %ld)\n",
+ realm->ino, PTR_ERR(in));
qri->timeout = jiffies + msecs_to_jiffies(60 * 1000); /* XXX */
} else {
qri->timeout = 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ceph: demote quotarealm lookup warning to a debug message
2020-05-05 12:59 [PATCH] ceph: demote quotarealm lookup warning to a debug message Luis Henriques
@ 2020-05-05 14:55 ` Jeff Layton
2020-05-07 13:44 ` Jeff Layton
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Layton @ 2020-05-05 14:55 UTC (permalink / raw)
To: Luis Henriques, Ilya Dryomov, Gregory Farnum; +Cc: ceph-devel, linux-kernel
On Tue, 2020-05-05 at 13:59 +0100, Luis Henriques wrote:
> A misconfigured cephx can easily result in having the kernel client
> flooding the logs with:
>
> ceph: Can't lookup inode 1 (err: -13)
>
> Change his message to debug level.
>
> Link: https://tracker.ceph.com/issues/44546
> Signed-off-by: Luis Henriques <lhenriques@suse.com>
> ---
> Hi!
>
> This patch should fix some harmless warnings when using cephx to restrict
> users access to certain filesystem paths. I've added a comment to the
> tracker where removing this warning could result (unlikely, IMHO!) in an
> admin to miss not-so-harmless bogus configurations.
>
> Cheers,
> --
> Luís
>
> fs/ceph/quota.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ceph/quota.c b/fs/ceph/quota.c
> index de56dee60540..19507e2fdb57 100644
> --- a/fs/ceph/quota.c
> +++ b/fs/ceph/quota.c
> @@ -159,8 +159,8 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc,
> }
>
> if (IS_ERR(in)) {
> - pr_warn("Can't lookup inode %llx (err: %ld)\n",
> - realm->ino, PTR_ERR(in));
> + dout("Can't lookup inode %llx (err: %ld)\n",
> + realm->ino, PTR_ERR(in));
> qri->timeout = jiffies + msecs_to_jiffies(60 * 1000); /* XXX */
> } else {
> qri->timeout = 0;
>
Merged into testing.
Thanks Luis!
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ceph: demote quotarealm lookup warning to a debug message
2020-05-05 12:59 [PATCH] ceph: demote quotarealm lookup warning to a debug message Luis Henriques
2020-05-05 14:55 ` Jeff Layton
@ 2020-05-07 13:44 ` Jeff Layton
2020-05-07 16:26 ` Ilya Dryomov
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Layton @ 2020-05-07 13:44 UTC (permalink / raw)
To: Ilya Dryomov; +Cc: ceph-devel, linux-kernel, Gregory Farnum, Luis Henriques
On Tue, 2020-05-05 at 13:59 +0100, Luis Henriques wrote:
> A misconfigured cephx can easily result in having the kernel client
> flooding the logs with:
>
> ceph: Can't lookup inode 1 (err: -13)
>
> Change his message to debug level.
>
> Link: https://tracker.ceph.com/issues/44546
> Signed-off-by: Luis Henriques <lhenriques@suse.com>
> ---
> Hi!
>
> This patch should fix some harmless warnings when using cephx to restrict
> users access to certain filesystem paths. I've added a comment to the
> tracker where removing this warning could result (unlikely, IMHO!) in an
> admin to miss not-so-harmless bogus configurations.
>
> Cheers,
> --
> Luís
>
> fs/ceph/quota.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ceph/quota.c b/fs/ceph/quota.c
> index de56dee60540..19507e2fdb57 100644
> --- a/fs/ceph/quota.c
> +++ b/fs/ceph/quota.c
> @@ -159,8 +159,8 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc,
> }
>
> if (IS_ERR(in)) {
> - pr_warn("Can't lookup inode %llx (err: %ld)\n",
> - realm->ino, PTR_ERR(in));
> + dout("Can't lookup inode %llx (err: %ld)\n",
> + realm->ino, PTR_ERR(in));
> qri->timeout = jiffies + msecs_to_jiffies(60 * 1000); /* XXX */
> } else {
> qri->timeout = 0;
>
Ilya,
We've had a number of reports where people get a ton of kernel log spam
when they hit this problem. I think we probably ought to mark this patch
for stable and go ahead and send it to Linus for v5.7 -- any objection?
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ceph: demote quotarealm lookup warning to a debug message
2020-05-07 13:44 ` Jeff Layton
@ 2020-05-07 16:26 ` Ilya Dryomov
0 siblings, 0 replies; 4+ messages in thread
From: Ilya Dryomov @ 2020-05-07 16:26 UTC (permalink / raw)
To: Jeff Layton; +Cc: Ceph Development, LKML, Gregory Farnum, Luis Henriques
On Thu, May 7, 2020 at 3:44 PM Jeff Layton <jlayton@kernel.org> wrote:
>
> On Tue, 2020-05-05 at 13:59 +0100, Luis Henriques wrote:
> > A misconfigured cephx can easily result in having the kernel client
> > flooding the logs with:
> >
> > ceph: Can't lookup inode 1 (err: -13)
> >
> > Change his message to debug level.
> >
> > Link: https://tracker.ceph.com/issues/44546
> > Signed-off-by: Luis Henriques <lhenriques@suse.com>
> > ---
> > Hi!
> >
> > This patch should fix some harmless warnings when using cephx to restrict
> > users access to certain filesystem paths. I've added a comment to the
> > tracker where removing this warning could result (unlikely, IMHO!) in an
> > admin to miss not-so-harmless bogus configurations.
> >
> > Cheers,
> > --
> > Luís
> >
> > fs/ceph/quota.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/ceph/quota.c b/fs/ceph/quota.c
> > index de56dee60540..19507e2fdb57 100644
> > --- a/fs/ceph/quota.c
> > +++ b/fs/ceph/quota.c
> > @@ -159,8 +159,8 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc,
> > }
> >
> > if (IS_ERR(in)) {
> > - pr_warn("Can't lookup inode %llx (err: %ld)\n",
> > - realm->ino, PTR_ERR(in));
> > + dout("Can't lookup inode %llx (err: %ld)\n",
> > + realm->ino, PTR_ERR(in));
> > qri->timeout = jiffies + msecs_to_jiffies(60 * 1000); /* XXX */
> > } else {
> > qri->timeout = 0;
> >
>
> Ilya,
>
> We've had a number of reports where people get a ton of kernel log spam
> when they hit this problem. I think we probably ought to mark this patch
> for stable and go ahead and send it to Linus for v5.7 -- any objection?
Sure, I'll queue it up.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-07 16:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 12:59 [PATCH] ceph: demote quotarealm lookup warning to a debug message Luis Henriques
2020-05-05 14:55 ` Jeff Layton
2020-05-07 13:44 ` Jeff Layton
2020-05-07 16:26 ` Ilya Dryomov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).