ceph-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [ceph-client:pr/22 32/34] include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration
@ 2020-12-14 15:32 kernel test robot
  2020-12-14 17:20 ` Ilya Dryomov
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-12-14 15:32 UTC (permalink / raw)
  To: Ilya Dryomov; +Cc: kbuild-all, ceph-devel

[-- Attachment #1: Type: text/plain, Size: 4164 bytes --]

tree:   https://github.com/ceph/ceph-client.git pr/22
head:   524d1e6601a7d1214c502d5739f5a34f09a0960c
commit: 48b7789934f0e94b975e98b74eaf18301fc0cfcd [32/34] libceph: implement msgr2.1 protocol (crc and secure modes)
config: arm-randconfig-r006-20201214 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ceph/ceph-client/commit/48b7789934f0e94b975e98b74eaf18301fc0cfcd
        git remote add ceph-client https://github.com/ceph/ceph-client.git
        git fetch --no-tags ceph-client pr/22
        git checkout 48b7789934f0e94b975e98b74eaf18301fc0cfcd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/ceph/ceph_fs.h:16,
                    from include/linux/ceph/types.h:11,
                    from include/linux/ceph/libceph.h:20,
                    from drivers/block/rbd.c:31:
>> include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
      43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
         | ^~~~~~~~~~~~~~~~~~~~
>> include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
   include/linux/ceph/msgr.h:37:24: warning: 'CEPH_MSGR2_FEATUREMASK_REVISION_1' defined but not used [-Wunused-const-variable=]
      37 |  const static uint64_t CEPH_MSGR2_FEATUREMASK_##name =            \
         |                        ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/ceph/msgr.h:43:1: note: in expansion of macro 'DEFINE_MSGR2_FEATURE'
      43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
         | ^~~~~~~~~~~~~~~~~~~~
   include/linux/ceph/msgr.h:36:24: warning: 'CEPH_MSGR2_FEATURE_REVISION_1' defined but not used [-Wunused-const-variable=]
      36 |  const static uint64_t CEPH_MSGR2_FEATURE_##name = (1ULL << bit); \
         |                        ^~~~~~~~~~~~~~~~~~~
   include/linux/ceph/msgr.h:43:1: note: in expansion of macro 'DEFINE_MSGR2_FEATURE'
      43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
         | ^~~~~~~~~~~~~~~~~~~~
--
   In file included from include/linux/ceph/ceph_fs.h:16,
                    from include/linux/ceph/types.h:11,
                    from include/linux/ceph/decode.h:11,
                    from net/ceph/messenger_v2.c:24:
>> include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
      43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
         | ^~~~~~~~~~~~~~~~~~~~
>> include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
   include/linux/ceph/msgr.h:37:24: warning: 'CEPH_MSGR2_FEATUREMASK_REVISION_1' defined but not used [-Wunused-const-variable=]
      37 |  const static uint64_t CEPH_MSGR2_FEATUREMASK_##name =            \
         |                        ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/ceph/msgr.h:43:1: note: in expansion of macro 'DEFINE_MSGR2_FEATURE'
      43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
         | ^~~~~~~~~~~~~~~~~~~~

vim +/static +43 include/linux/ceph/msgr.h

    34	
    35	#define DEFINE_MSGR2_FEATURE(bit, incarnation, name)               \
    36		const static uint64_t CEPH_MSGR2_FEATURE_##name = (1ULL << bit); \
    37		const static uint64_t CEPH_MSGR2_FEATUREMASK_##name =            \
    38				(1ULL << bit | CEPH_MSGR2_INCARNATION_##incarnation);
    39	
    40	#define HAVE_MSGR2_FEATURE(x, name) \
    41		(((x) & (CEPH_MSGR2_FEATUREMASK_##name)) == (CEPH_MSGR2_FEATUREMASK_##name))
    42	
  > 43	DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
    44	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30378 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [ceph-client:pr/22 32/34] include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration
  2020-12-14 15:32 [ceph-client:pr/22 32/34] include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration kernel test robot
@ 2020-12-14 17:20 ` Ilya Dryomov
  0 siblings, 0 replies; 2+ messages in thread
From: Ilya Dryomov @ 2020-12-14 17:20 UTC (permalink / raw)
  To: kernel test robot; +Cc: kbuild-all, Ceph Development

On Mon, Dec 14, 2020 at 4:33 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://github.com/ceph/ceph-client.git pr/22
> head:   524d1e6601a7d1214c502d5739f5a34f09a0960c
> commit: 48b7789934f0e94b975e98b74eaf18301fc0cfcd [32/34] libceph: implement msgr2.1 protocol (crc and secure modes)
> config: arm-randconfig-r006-20201214 (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/ceph/ceph-client/commit/48b7789934f0e94b975e98b74eaf18301fc0cfcd
>         git remote add ceph-client https://github.com/ceph/ceph-client.git
>         git fetch --no-tags ceph-client pr/22
>         git checkout 48b7789934f0e94b975e98b74eaf18301fc0cfcd
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>    In file included from include/linux/ceph/ceph_fs.h:16,
>                     from include/linux/ceph/types.h:11,
>                     from include/linux/ceph/libceph.h:20,
>                     from drivers/block/rbd.c:31:
> >> include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
>       43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
>          | ^~~~~~~~~~~~~~~~~~~~
> >> include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
>    include/linux/ceph/msgr.h:37:24: warning: 'CEPH_MSGR2_FEATUREMASK_REVISION_1' defined but not used [-Wunused-const-variable=]
>       37 |  const static uint64_t CEPH_MSGR2_FEATUREMASK_##name =            \
>          |                        ^~~~~~~~~~~~~~~~~~~~~~~
>    include/linux/ceph/msgr.h:43:1: note: in expansion of macro 'DEFINE_MSGR2_FEATURE'
>       43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
>          | ^~~~~~~~~~~~~~~~~~~~
>    include/linux/ceph/msgr.h:36:24: warning: 'CEPH_MSGR2_FEATURE_REVISION_1' defined but not used [-Wunused-const-variable=]
>       36 |  const static uint64_t CEPH_MSGR2_FEATURE_##name = (1ULL << bit); \
>          |                        ^~~~~~~~~~~~~~~~~~~
>    include/linux/ceph/msgr.h:43:1: note: in expansion of macro 'DEFINE_MSGR2_FEATURE'
>       43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
>          | ^~~~~~~~~~~~~~~~~~~~
> --
>    In file included from include/linux/ceph/ceph_fs.h:16,
>                     from include/linux/ceph/types.h:11,
>                     from include/linux/ceph/decode.h:11,
>                     from net/ceph/messenger_v2.c:24:
> >> include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
>       43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
>          | ^~~~~~~~~~~~~~~~~~~~
> >> include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration]
>    include/linux/ceph/msgr.h:37:24: warning: 'CEPH_MSGR2_FEATUREMASK_REVISION_1' defined but not used [-Wunused-const-variable=]
>       37 |  const static uint64_t CEPH_MSGR2_FEATUREMASK_##name =            \
>          |                        ^~~~~~~~~~~~~~~~~~~~~~~
>    include/linux/ceph/msgr.h:43:1: note: in expansion of macro 'DEFINE_MSGR2_FEATURE'
>       43 | DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
>          | ^~~~~~~~~~~~~~~~~~~~
>
> vim +/static +43 include/linux/ceph/msgr.h
>
>     34
>     35  #define DEFINE_MSGR2_FEATURE(bit, incarnation, name)               \
>     36          const static uint64_t CEPH_MSGR2_FEATURE_##name = (1ULL << bit); \
>     37          const static uint64_t CEPH_MSGR2_FEATUREMASK_##name =            \
>     38                          (1ULL << bit | CEPH_MSGR2_INCARNATION_##incarnation);
>     39
>     40  #define HAVE_MSGR2_FEATURE(x, name) \
>     41          (((x) & (CEPH_MSGR2_FEATUREMASK_##name)) == (CEPH_MSGR2_FEATUREMASK_##name))
>     42
>   > 43  DEFINE_MSGR2_FEATURE( 0, 1, REVISION_1)   // msgr2.1
>     44
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

This came from a userspace header.  Fixed.

Thanks,

                Ilya

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-14 17:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-14 15:32 [ceph-client:pr/22 32/34] include/linux/ceph/msgr.h:43:1: warning: 'static' is not at beginning of declaration kernel test robot
2020-12-14 17:20 ` Ilya Dryomov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).