* Re: [PATCH] ceph: remove unused macro anywhere
[not found] <20200925014806.GA1422079@jerryopenix>
@ 2020-09-25 9:40 ` Ilya Dryomov
0 siblings, 0 replies; only message in thread
From: Ilya Dryomov @ 2020-09-25 9:40 UTC (permalink / raw)
To: Liu, Changcheng; +Cc: Jeff Layton, Ceph Development
On Fri, Sep 25, 2020 at 3:55 AM Liu, Changcheng
<changcheng.liu@intel.com> wrote:
>
> CEPH_PORT_FIRST isn't used anywhere.
> non-monitors ports are in below range:
> [CEPH_PORT_START, CEPH_PORT_LAST]
>
> Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
>
> diff --git a/include/linux/ceph/msgr.h b/include/linux/ceph/msgr.h
> index 9e50aede46c8..0e7888665492 100644
> --- a/include/linux/ceph/msgr.h
> +++ b/include/linux/ceph/msgr.h
> @@ -13,7 +13,6 @@
> * range, simply for the benefit of tools like nmap or wireshark
> * that would like to identify the protocol.
> */
> -#define CEPH_PORT_FIRST 6789
> #define CEPH_PORT_START 6800 /* non-monitors start here */
> #define CEPH_PORT_LAST 6900
>
> --
> 2.17.1
>
Hi Changcheng,
This is sent from changcheng.liu@intel.com, but the Signed-off-by
line doesn't cover that address. It is quite common for people to
own several addresses, but the Signed-off-by line has to match.
Could you please resend from the correct address / with the correct
Signed-off-by line?
Thanks,
Ilya
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-25 9:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200925014806.GA1422079@jerryopenix>
2020-09-25 9:40 ` [PATCH] ceph: remove unused macro anywhere Ilya Dryomov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).