From: Mat Martineau <mathew.j.martineau at linux.intel.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net 1/2] mptcp: more strict state checking for acks
Date: Tue, 12 Jan 2021 13:37:48 -0800 [thread overview]
Message-ID: <cf5db42-8431-da6f-422-da51da18a119@linux.intel.com> (raw)
In-Reply-To: 5566ba1c4409a652440d84ff49b99e58ca998a0e.1610471474.git.pabeni@redhat.com
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Tue, 12 Jan 2021, Paolo Abeni wrote:
> Syzkaller found a way to trigger division by zero
> in mptcp_subflow_cleanup_rbuf().
>
> The current checks implemented into tcp_can_send_ack()
> are too week, let's be more accurate.
>
> Reported-by: Christoph Paasch <cpaasch(a)apple.com>
> Fixes: ea4ca586b16f ("mptcp: refine MPTCP-level ack scheduling")
> Fixes: fd8976790a6c ("mptcp: be careful on MPTCP-level ack.")
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> ---
> net/mptcp/protocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
--
Mat Martineau
Intel
WARNING: multiple messages have this Message-ID (diff)
From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, mptcp@lists.01.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [MPTCP] [PATCH net 1/2] mptcp: more strict state checking for acks
Date: Tue, 12 Jan 2021 13:37:48 -0800 (PST) [thread overview]
Message-ID: <cf5db42-8431-da6f-422-da51da18a119@linux.intel.com> (raw)
In-Reply-To: <5566ba1c4409a652440d84ff49b99e58ca998a0e.1610471474.git.pabeni@redhat.com>
On Tue, 12 Jan 2021, Paolo Abeni wrote:
> Syzkaller found a way to trigger division by zero
> in mptcp_subflow_cleanup_rbuf().
>
> The current checks implemented into tcp_can_send_ack()
> are too week, let's be more accurate.
>
> Reported-by: Christoph Paasch <cpaasch@apple.com>
> Fixes: ea4ca586b16f ("mptcp: refine MPTCP-level ack scheduling")
> Fixes: fd8976790a6c ("mptcp: be careful on MPTCP-level ack.")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> net/mptcp/protocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
--
Mat Martineau
Intel
next reply other threads:[~2021-01-12 21:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 21:37 Mat Martineau [this message]
2021-01-12 21:37 ` [MPTCP] [PATCH net 1/2] mptcp: more strict state checking for acks Mat Martineau
-- strict thread matches above, loose matches on Subject: below --
2021-01-13 15:26 [MPTCP] Re: [PATCH net 2/2] mptcp: better msk-level shutdown Paolo Abeni
2021-01-13 15:26 ` Paolo Abeni
2021-01-13 10:26 [MPTCP] " Eric Dumazet
2021-01-13 10:26 ` Eric Dumazet
2021-01-13 10:21 [MPTCP] " Eric Dumazet
2021-01-13 10:21 ` Eric Dumazet
2021-01-12 21:38 [MPTCP] " Mat Martineau
2021-01-12 21:38 ` [MPTCP] " Mat Martineau
2021-01-12 17:25 Paolo Abeni
2021-01-12 17:25 ` Paolo Abeni
2021-01-12 17:25 [MPTCP] [PATCH net 1/2] mptcp: more strict state checking for acks Paolo Abeni
2021-01-12 17:25 ` Paolo Abeni
2021-01-12 17:25 [MPTCP] [PATCH net 0/2] mptcp: a couple of fixes Paolo Abeni
2021-01-12 17:25 ` Paolo Abeni
2021-01-13 4:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf5db42-8431-da6f-422-da51da18a119@linux.intel.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.