From: Faiz Abbas <faiz_abbas@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <robh+dt@kernel.org>,
<bcousson@baylibre.com>, <paul@pwsan.com>, <t-kristo@ti.com>,
<mark.rutland@arm.com>
Subject: Re: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset
Date: Fri, 6 Jul 2018 15:34:31 +0530 [thread overview]
Message-ID: <cf8652a1-019c-d423-9b44-0d62006734f8@ti.com> (raw)
In-Reply-To: <20180705154758.GA112168@atomide.com>
Hi,
On Thursday 05 July 2018 09:17 PM, Tony Lindgren wrote:
> * Faiz Abbas <faiz_abbas@ti.com> [180705 14:24]:
>> +static int sysc_reset(struct sysc *ddata)
>> +{
>> + int offset = ddata->offsets[SYSC_SYSCONFIG];
>> + int val = sysc_read(ddata, offset);
>
> Can you please just warn and return early for now if no
> syss_mask is specified? Otherwise we'll have mysterious
> errors if somebody leaves out "ti,hwmods" for module types
> we do not yet support reset for.
RESET write to sysconfig can still happen even if there's no syss_mask
right? Not all modules need to poll on reset status.
Thanks,
Faiz
WARNING: multiple messages have this Message-ID (diff)
From: Faiz Abbas <faiz_abbas@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, paul@pwsan.com,
linux-kernel@vger.kernel.org, t-kristo@ti.com,
robh+dt@kernel.org, bcousson@baylibre.com,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset
Date: Fri, 6 Jul 2018 15:34:31 +0530 [thread overview]
Message-ID: <cf8652a1-019c-d423-9b44-0d62006734f8@ti.com> (raw)
In-Reply-To: <20180705154758.GA112168@atomide.com>
Hi,
On Thursday 05 July 2018 09:17 PM, Tony Lindgren wrote:
> * Faiz Abbas <faiz_abbas@ti.com> [180705 14:24]:
>> +static int sysc_reset(struct sysc *ddata)
>> +{
>> + int offset = ddata->offsets[SYSC_SYSCONFIG];
>> + int val = sysc_read(ddata, offset);
>
> Can you please just warn and return early for now if no
> syss_mask is specified? Otherwise we'll have mysterious
> errors if somebody leaves out "ti,hwmods" for module types
> we do not yet support reset for.
RESET write to sysconfig can still happen even if there's no syss_mask
right? Not all modules need to poll on reset status.
Thanks,
Faiz
WARNING: multiple messages have this Message-ID (diff)
From: faiz_abbas@ti.com (Faiz Abbas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/6] bus: ti-sysc: Add support for software reset
Date: Fri, 6 Jul 2018 15:34:31 +0530 [thread overview]
Message-ID: <cf8652a1-019c-d423-9b44-0d62006734f8@ti.com> (raw)
In-Reply-To: <20180705154758.GA112168@atomide.com>
Hi,
On Thursday 05 July 2018 09:17 PM, Tony Lindgren wrote:
> * Faiz Abbas <faiz_abbas@ti.com> [180705 14:24]:
>> +static int sysc_reset(struct sysc *ddata)
>> +{
>> + int offset = ddata->offsets[SYSC_SYSCONFIG];
>> + int val = sysc_read(ddata, offset);
>
> Can you please just warn and return early for now if no
> syss_mask is specified? Otherwise we'll have mysterious
> errors if somebody leaves out "ti,hwmods" for module types
> we do not yet support reset for.
RESET write to sysconfig can still happen even if there's no syss_mask
right? Not all modules need to poll on reset status.
Thanks,
Faiz
next prev parent reply other threads:[~2018-07-06 10:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 14:23 [PATCH v4 0/6] Add MCAN Support for dra76x Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` [PATCH v4 1/6] ARM: dts: dra762: Add MCAN clock support Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` [PATCH v4 2/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-06 20:47 ` Stephen Boyd
2018-07-06 20:47 ` Stephen Boyd
2018-07-06 20:47 ` Stephen Boyd
2018-07-06 20:47 ` Stephen Boyd
2018-07-05 14:23 ` [PATCH v4 3/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` [PATCH v4 4/6] bus: ti-sysc: Add support for software reset Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 15:47 ` Tony Lindgren
2018-07-05 15:47 ` Tony Lindgren
2018-07-06 10:04 ` Faiz Abbas [this message]
2018-07-06 10:04 ` Faiz Abbas
2018-07-06 10:04 ` Faiz Abbas
2018-07-06 10:35 ` Tony Lindgren
2018-07-06 10:35 ` Tony Lindgren
2018-07-06 12:35 ` Faiz Abbas
2018-07-06 12:35 ` Faiz Abbas
2018-07-06 12:35 ` Faiz Abbas
2018-07-06 12:35 ` Faiz Abbas
2018-07-05 14:23 ` [PATCH v4 5/6] ARM: dts: Add generic interconnect target module node for MCAN Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` [PATCH v4 6/6] ARM: dts: dra76x: Add MCAN node Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
2018-07-05 14:23 ` Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf8652a1-019c-d423-9b44-0d62006734f8@ti.com \
--to=faiz_abbas@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul@pwsan.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.