Re: [PATCH] arm64: dts: mt8183: juniper: Remove CrosEC base detection node

From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	kernel@collabora.com, Conor Dooley <conor+dt@kernel.org>,
	Enric Balletbo i Serra <eballetbo@kernel.org>,
	Ikjoon Jang <ikjn@chromium.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: mt8183: juniper: Remove CrosEC base detection node
Date: Fri, 12 Jan 2024 09:19:52 -0300	[thread overview]
Message-ID: <cfa39af2-936d-470e-93ea-adc2a632849f@notapiano> (raw)
In-Reply-To: <CAGXv+5FKHX482+QjYP=jWKWz2HD=Af6x9Cahi+fc4EKNmM-MMQ@mail.gmail.com>

On Fri, Jan 12, 2024 at 03:10:12PM +0800, Chen-Yu Tsai wrote:
> On Fri, Jan 12, 2024 at 3:55 AM Nícolas F. R. A. Prado
> <nfraprado@collabora.com> wrote:
> >
> > The cbas node is used to describe base detection functionality in the
> > ChromeOS EC, which is used for units that have a detachable keyboard and
> > thus rely on this functionality to switch between tablet and laptop
> > mode.
> >
> > The juniper-sku16 machine is a convertible, meaning the keyboard can be
> > flipped but not detached. The detection for the keyboard getting
> > flipped is handled by the driver bound to the keyboard-controller
> > node in the EC.
> 
> We could do this for the whole jacuzzi family, which are all clamshell
> or convertibles.

Ah that's great info, thanks! I suspected so but since this unit was the only
one that I could actually test the change on, I decided to stick to it.

I'll send a v2 removing the node at the jacuzzi dtsi level then.

Thanks,
Nícolas