From: "Jürgen Groß" <jgross@suse.com>
To: Paul Durrant <pdurrant@amazon.com>,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 3/4] xen/interface: re-define FRONT/BACK_RING_ATTACH()
Date: Thu, 12 Dec 2019 07:04:27 +0100 [thread overview]
Message-ID: <cfd8f169-e925-dbff-64b2-d471300a6694@suse.com> (raw)
In-Reply-To: <20191211152956.5168-4-pdurrant@amazon.com>
On 11.12.19 16:29, Paul Durrant wrote:
> Currently these macros are defined to re-initialize a front/back ring
> (respectively) to values read from the shared ring in such a way that any
> requests/responses that are added to the shared ring whilst the front/back
> is detached will be skipped over. This, in general, is not a desirable
> semantic since most frontend implementations will eventually block waiting
> for a response which would either never appear or never be processed.
>
> Since the macros are currently unused, take this opportunity to re-define
> them to re-initialize a front/back ring using specified values. This also
> allows FRONT/BACK_RING_INIT() to be re-defined in terms of
> FRONT/BACK_RING_ATTACH() using a specified value of 0.
>
> NOTE: BACK_RING_ATTACH() will be used directly in a subsequent patch.
>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
WARNING: multiple messages have this Message-ID (diff)
From: "Jürgen Groß" <jgross@suse.com>
To: Paul Durrant <pdurrant@amazon.com>,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [Xen-devel] [PATCH v3 3/4] xen/interface: re-define FRONT/BACK_RING_ATTACH()
Date: Thu, 12 Dec 2019 07:04:27 +0100 [thread overview]
Message-ID: <cfd8f169-e925-dbff-64b2-d471300a6694@suse.com> (raw)
In-Reply-To: <20191211152956.5168-4-pdurrant@amazon.com>
On 11.12.19 16:29, Paul Durrant wrote:
> Currently these macros are defined to re-initialize a front/back ring
> (respectively) to values read from the shared ring in such a way that any
> requests/responses that are added to the shared ring whilst the front/back
> is detached will be skipped over. This, in general, is not a desirable
> semantic since most frontend implementations will eventually block waiting
> for a response which would either never appear or never be processed.
>
> Since the macros are currently unused, take this opportunity to re-define
> them to re-initialize a front/back ring using specified values. This also
> allows FRONT/BACK_RING_INIT() to be re-defined in terms of
> FRONT/BACK_RING_ATTACH() using a specified value of 0.
>
> NOTE: BACK_RING_ATTACH() will be used directly in a subsequent patch.
>
> Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-12 6:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 15:29 [PATCH v3 0/4] xen-blkback: support live update Paul Durrant
2019-12-11 15:29 ` [Xen-devel] " Paul Durrant
2019-12-11 15:29 ` [PATCH v3 1/4] xenbus: move xenbus_dev_shutdown() into frontend code Paul Durrant
2019-12-11 15:29 ` [Xen-devel] " Paul Durrant
2019-12-11 15:29 ` [PATCH v3 2/4] xenbus: limit when state is forced to closed Paul Durrant
2019-12-11 15:29 ` [Xen-devel] " Paul Durrant
2019-12-12 6:02 ` Jürgen Groß
2019-12-12 6:02 ` [Xen-devel] " Jürgen Groß
2019-12-11 15:29 ` [PATCH v3 3/4] xen/interface: re-define FRONT/BACK_RING_ATTACH() Paul Durrant
2019-12-11 15:29 ` [Xen-devel] " Paul Durrant
2019-12-12 6:04 ` Jürgen Groß [this message]
2019-12-12 6:04 ` Jürgen Groß
2019-12-13 8:59 ` Jürgen Groß
2019-12-13 8:59 ` [Xen-devel] " Jürgen Groß
2019-12-13 9:02 ` Durrant, Paul
2019-12-13 9:02 ` [Xen-devel] " Durrant, Paul
2019-12-11 15:29 ` [PATCH v3 4/4] xen-blkback: support dynamic unbind/bind Paul Durrant
2019-12-11 15:29 ` [Xen-devel] " Paul Durrant
2019-12-12 6:07 ` Jürgen Groß
2019-12-12 6:07 ` [Xen-devel] " Jürgen Groß
2019-12-12 11:46 ` Roger Pau Monné
2019-12-12 11:46 ` [Xen-devel] " Roger Pau Monné
2019-12-12 12:04 ` Jürgen Groß
2019-12-12 12:04 ` [Xen-devel] " Jürgen Groß
2019-12-20 12:45 ` [PATCH v3 0/4] xen-blkback: support live update Jürgen Groß
2019-12-20 12:45 ` [Xen-devel] " Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfd8f169-e925-dbff-64b2-d471300a6694@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdurrant@amazon.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.