chrome-platform.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform/chrome: cros_typec_switch: Add missing fwnode_handle_put()
@ 2023-03-22  4:16 Liang He
  2023-04-07 18:50 ` patchwork-bot+chrome-platform
  2023-04-10 20:30 ` patchwork-bot+chrome-platform
  0 siblings, 2 replies; 3+ messages in thread
From: Liang He @ 2023-03-22  4:16 UTC (permalink / raw)
  To: pmalani, bleung, chrome-platform, windhl

In cros_typec_register_switches(), we should add fwnode_handle_put()
when break out of the iteration device_for_each_child_node()
as it will automatically increase and decrease the refcounter.

Fixes: affc804c44c8 ("platform/chrome: cros_typec_switch: Add switch driver")
Signed-off-by: Liang He <windhl@126.com>
---
 drivers/platform/chrome/cros_typec_switch.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/chrome/cros_typec_switch.c b/drivers/platform/chrome/cros_typec_switch.c
index a26219e97c93..26af51952f7f 100644
--- a/drivers/platform/chrome/cros_typec_switch.c
+++ b/drivers/platform/chrome/cros_typec_switch.c
@@ -268,6 +268,7 @@ static int cros_typec_register_switches(struct cros_typec_switch_data *sdata)
 
 	return 0;
 err_switch:
+	fwnode_handle_put(fwnode);
 	cros_typec_unregister_switches(sdata);
 	return ret;
 }
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] platform/chrome: cros_typec_switch: Add missing fwnode_handle_put()
  2023-03-22  4:16 [PATCH] platform/chrome: cros_typec_switch: Add missing fwnode_handle_put() Liang He
@ 2023-04-07 18:50 ` patchwork-bot+chrome-platform
  2023-04-10 20:30 ` patchwork-bot+chrome-platform
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-04-07 18:50 UTC (permalink / raw)
  To: Liang He; +Cc: pmalani, bleung, chrome-platform

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci)
by Prashant Malani <pmalani@chromium.org>:

On Wed, 22 Mar 2023 12:16:57 +0800 you wrote:
> In cros_typec_register_switches(), we should add fwnode_handle_put()
> when break out of the iteration device_for_each_child_node()
> as it will automatically increase and decrease the refcounter.
> 
> Fixes: affc804c44c8 ("platform/chrome: cros_typec_switch: Add switch driver")
> Signed-off-by: Liang He <windhl@126.com>
> 
> [...]

Here is the summary with links:
  - platform/chrome: cros_typec_switch: Add missing fwnode_handle_put()
    https://git.kernel.org/chrome-platform/c/d946c9118047

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] platform/chrome: cros_typec_switch: Add missing fwnode_handle_put()
  2023-03-22  4:16 [PATCH] platform/chrome: cros_typec_switch: Add missing fwnode_handle_put() Liang He
  2023-04-07 18:50 ` patchwork-bot+chrome-platform
@ 2023-04-10 20:30 ` patchwork-bot+chrome-platform
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-04-10 20:30 UTC (permalink / raw)
  To: Liang He; +Cc: pmalani, bleung, chrome-platform

Hello:

This patch was applied to chrome-platform/linux.git (for-next)
by Prashant Malani <pmalani@chromium.org>:

On Wed, 22 Mar 2023 12:16:57 +0800 you wrote:
> In cros_typec_register_switches(), we should add fwnode_handle_put()
> when break out of the iteration device_for_each_child_node()
> as it will automatically increase and decrease the refcounter.
> 
> Fixes: affc804c44c8 ("platform/chrome: cros_typec_switch: Add switch driver")
> Signed-off-by: Liang He <windhl@126.com>
> 
> [...]

Here is the summary with links:
  - platform/chrome: cros_typec_switch: Add missing fwnode_handle_put()
    https://git.kernel.org/chrome-platform/c/d946c9118047

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-10 20:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22  4:16 [PATCH] platform/chrome: cros_typec_switch: Add missing fwnode_handle_put() Liang He
2023-04-07 18:50 ` patchwork-bot+chrome-platform
2023-04-10 20:30 ` patchwork-bot+chrome-platform

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).