From: Prashant Malani <pmalani@chromium.org>
To: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev
Cc: bleung@chromium.org, Prashant Malani <pmalani@chromium.org>,
Daisuke Nojiri <dnojiri@chromium.org>,
"Dustin L. Howett" <dustin@howett.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Tinghan Shen <tinghan.shen@mediatek.com>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Xiang wangx <wangxiang@cdjrlc.com>
Subject: [PATCH v5 3/7] platform/chrome: cros_typec_switch: Set EC retimer
Date: Mon, 15 Aug 2022 06:34:21 +0000 [thread overview]
Message-ID: <20220815063555.1384505-4-pmalani@chromium.org> (raw)
In-Reply-To: <20220815063555.1384505-1-pmalani@chromium.org>
Invoke Chrome EC host commands to set EC-controlled retimer switches to
the state the Type-C framework instructs.
Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
Changes since v4:
- Update cros_ec_command() to cros_ec_cmd().
Changes since v3:
- No changes.
Changes since v2:
- No changes.
Changes since v1:
- No changes.
drivers/platform/chrome/cros_typec_switch.c | 56 ++++++++++++++++++++-
1 file changed, 55 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_typec_switch.c b/drivers/platform/chrome/cros_typec_switch.c
index 0d319e315d57..befe35655a9a 100644
--- a/drivers/platform/chrome/cros_typec_switch.c
+++ b/drivers/platform/chrome/cros_typec_switch.c
@@ -9,7 +9,10 @@
#include <linux/acpi.h>
#include <linux/module.h>
#include <linux/platform_data/cros_ec_commands.h>
+#include <linux/platform_data/cros_ec_proto.h>
#include <linux/platform_device.h>
+#include <linux/usb/typec_altmode.h>
+#include <linux/usb/typec_dp.h>
#include <linux/usb/typec_retimer.h>
#define DRV_NAME "cros-typec-switch"
@@ -28,9 +31,60 @@ struct cros_typec_switch_data {
struct cros_typec_port *ports[EC_USB_PD_MAX_PORTS];
};
+static int cros_typec_cmd_mux_set(struct cros_typec_switch_data *sdata, int port_num, u8 index,
+ u8 state)
+{
+ struct typec_usb_mux_set params = {
+ .mux_index = index,
+ .mux_flags = state,
+ };
+
+ struct ec_params_typec_control req = {
+ .port = port_num,
+ .command = TYPEC_CONTROL_COMMAND_USB_MUX_SET,
+ .mux_params = params,
+ };
+
+ return cros_ec_cmd(sdata->ec, 0, EC_CMD_TYPEC_CONTROL, &req,
+ sizeof(req), NULL, 0);
+}
+
+static int cros_typec_get_mux_state(unsigned long mode, struct typec_altmode *alt)
+{
+ int ret = -EOPNOTSUPP;
+
+ if (mode == TYPEC_STATE_SAFE)
+ ret = USB_PD_MUX_SAFE_MODE;
+ else if (mode == TYPEC_STATE_USB)
+ ret = USB_PD_MUX_USB_ENABLED;
+ else if (alt && alt->svid == USB_TYPEC_DP_SID)
+ ret = USB_PD_MUX_DP_ENABLED;
+
+ return ret;
+}
+
+/*
+ * The Chrome EC treats both mode-switches and retimers as "muxes" for the purposes of the
+ * host command API. This common function configures and verifies the retimer/mode-switch
+ * according to the provided setting.
+ */
+static int cros_typec_configure_mux(struct cros_typec_switch_data *sdata, int port_num, int index,
+ unsigned long mode, struct typec_altmode *alt)
+{
+ int ret = cros_typec_get_mux_state(mode, alt);
+
+ if (ret < 0)
+ return ret;
+
+ return cros_typec_cmd_mux_set(sdata, port_num, index, (u8)ret);
+}
+
static int cros_typec_retimer_set(struct typec_retimer *retimer, struct typec_retimer_state *state)
{
- return 0;
+ struct cros_typec_port *port = typec_retimer_get_drvdata(retimer);
+
+ /* Retimers have index 1. */
+ return cros_typec_configure_mux(port->sdata, port->port_num, 1, state->mode, state->alt);
}
static void cros_typec_unregister_switches(struct cros_typec_switch_data *sdata)
--
2.37.1.595.g718a3a8f04-goog
next prev parent reply other threads:[~2022-08-15 6:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 6:34 [PATCH v5 0/7] platform/chrome: Type-C switch driver Prashant Malani
2022-08-15 6:34 ` [PATCH v5 1/7] platform/chrome: Add Type-C mux set command definitions Prashant Malani
2022-08-16 5:08 ` Tzung-Bi Shih
2022-08-15 6:34 ` [PATCH v5 2/7] platform/chrome: cros_typec_switch: Add switch driver Prashant Malani
2022-08-16 5:11 ` Tzung-Bi Shih
2022-08-16 21:44 ` Prashant Malani
2022-08-15 6:34 ` Prashant Malani [this message]
2022-08-16 5:11 ` [PATCH v5 3/7] platform/chrome: cros_typec_switch: Set EC retimer Tzung-Bi Shih
2022-08-16 21:45 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 4/7] platform/chrome: cros_typec_switch: Add event check Prashant Malani
2022-08-16 5:11 ` Tzung-Bi Shih
2022-08-16 21:45 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 5/7] platform/chrome: cros_typec_switch: Register mode switches Prashant Malani
2022-08-16 5:12 ` Tzung-Bi Shih
2022-08-16 21:45 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 6/7] platform/chrome: cros_ec_typec: Cleanup switch handle return paths Prashant Malani
2022-08-16 5:12 ` Tzung-Bi Shih
2022-08-15 6:34 ` [PATCH v5 7/7] platform/chrome: cros_ec_typec: Get retimer handle Prashant Malani
2022-08-16 5:13 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815063555.1384505-4-pmalani@chromium.org \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dnojiri@chromium.org \
--cc=dustin@howett.net \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tinghan.shen@mediatek.com \
--cc=tzungbi@kernel.org \
--cc=wangxiang@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).