From: Prashant Malani <pmalani@chromium.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
bleung@chromium.org, Daisuke Nojiri <dnojiri@chromium.org>,
"Dustin L. Howett" <dustin@howett.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Tinghan Shen <tinghan.shen@mediatek.com>,
Xiang wangx <wangxiang@cdjrlc.com>
Subject: Re: [PATCH v5 2/7] platform/chrome: cros_typec_switch: Add switch driver
Date: Tue, 16 Aug 2022 14:44:45 -0700 [thread overview]
Message-ID: <CACeCKadOK22FzOwyOEkmaqw+V4-Jna=QqetDmsqNhs27skzU7A@mail.gmail.com> (raw)
In-Reply-To: <Yvsm7qEiCpoYPeTS@google.com>
Hi Tzung-Bi,
Thanks for reviewing the patch series.
On Mon, Aug 15, 2022 at 10:11 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> On Mon, Aug 15, 2022 at 06:34:19AM +0000, Prashant Malani wrote:
> > Introduce a driver to configure USB Type-C mode switches and retimers
> > which are controlled by the Chrome OS EC (Embedded Controller).
> > This allows Type-C port drivers, as well as alternate mode drivers to
> > configure their relevant mode switches and retimers according to the
> > Type-C state they want to achieve.
>
> s/Chrome OS/ChromeOS/.
Fixed in v6.
>
> > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> [...]
> > +config CROS_TYPEC_SWITCH
> > + tristate "ChromeOS EC Type-C Switch Control"
> > + depends on MFD_CROS_EC_DEV && TYPEC && ACPI
> > + default MFD_CROS_EC_DEV
> > + help
> > + If you say Y here, you get support for configuring the Chrome OS EC Type C
> > + muxes and retimers.
>
> s/Chrome OS/ChromeOS/.
>
> Up to you, s/Type C/Type-C/g.
Fixed in v6.
>
> > diff --git a/drivers/platform/chrome/cros_typec_switch.c b/drivers/platform/chrome/cros_typec_switch.c
> > new file mode 100644
> > index 000000000000..0d319e315d57
> > --- /dev/null
> > +++ b/drivers/platform/chrome/cros_typec_switch.c
> > @@ -0,0 +1,170 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Copyright 2022 Google LLC
> > + *
> > + * This driver provides the ability to configure Type C muxes and retimers which are controlled by
> > + * the Chrome OS EC.
> > + */
>
> s/Chrome OS/ChromeOS/.
Fixed in v6.
>
> > +static int cros_typec_register_switches(struct cros_typec_switch_data *sdata)
> > +{
> > + struct cros_typec_port *port = NULL;
> > + struct device *dev = sdata->dev;
> > + struct fwnode_handle *fwnode;
> > + struct acpi_device *adev;
> > + unsigned long long index;
> > + int ret = 0;
>
> `port` and `ret` don't need to be initialized.
Fixed in v6.
>
> > +MODULE_DESCRIPTION("Chrome OS EC Type C Switch control");
>
> s/Chrome OS/ChromeOS/.
Fixed in v6.
next prev parent reply other threads:[~2022-08-16 21:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 6:34 [PATCH v5 0/7] platform/chrome: Type-C switch driver Prashant Malani
2022-08-15 6:34 ` [PATCH v5 1/7] platform/chrome: Add Type-C mux set command definitions Prashant Malani
2022-08-16 5:08 ` Tzung-Bi Shih
2022-08-15 6:34 ` [PATCH v5 2/7] platform/chrome: cros_typec_switch: Add switch driver Prashant Malani
2022-08-16 5:11 ` Tzung-Bi Shih
2022-08-16 21:44 ` Prashant Malani [this message]
2022-08-15 6:34 ` [PATCH v5 3/7] platform/chrome: cros_typec_switch: Set EC retimer Prashant Malani
2022-08-16 5:11 ` Tzung-Bi Shih
2022-08-16 21:45 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 4/7] platform/chrome: cros_typec_switch: Add event check Prashant Malani
2022-08-16 5:11 ` Tzung-Bi Shih
2022-08-16 21:45 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 5/7] platform/chrome: cros_typec_switch: Register mode switches Prashant Malani
2022-08-16 5:12 ` Tzung-Bi Shih
2022-08-16 21:45 ` Prashant Malani
2022-08-15 6:34 ` [PATCH v5 6/7] platform/chrome: cros_ec_typec: Cleanup switch handle return paths Prashant Malani
2022-08-16 5:12 ` Tzung-Bi Shih
2022-08-15 6:34 ` [PATCH v5 7/7] platform/chrome: cros_ec_typec: Get retimer handle Prashant Malani
2022-08-16 5:13 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACeCKadOK22FzOwyOEkmaqw+V4-Jna=QqetDmsqNhs27skzU7A@mail.gmail.com' \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dnojiri@chromium.org \
--cc=dustin@howett.net \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tinghan.shen@mediatek.com \
--cc=tzungbi@kernel.org \
--cc=wangxiang@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).