From: Prashant Malani <pmalani@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Lee Jones <lee.jones@linaro.org>,
Daisuke Nojiri <dnojiri@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH 1/3] platform/chrome: cros_ec_proto: Add peripheral charger count API
Date: Mon, 18 Apr 2022 23:21:52 +0000 [thread overview]
Message-ID: <Yl3ykMvfCaQlQ7t9@chromium.org> (raw)
In-Reply-To: <CAE-0n53N1k_b9vWJ84nBdm9sxpYV3o4-FLJQM1HGqEhQsdr19A@mail.gmail.com>
On Apr 18 16:16, Stephen Boyd wrote:
> Quoting Prashant Malani (2022-04-18 16:08:39)
> > On Apr 14 17:32, Stephen Boyd wrote:
> > > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
> > > index c4caf2e2de82..42269703ca6c 100644
> > > --- a/drivers/platform/chrome/cros_ec_proto.c
> > > +++ b/drivers/platform/chrome/cros_ec_proto.c
> > > @@ -832,6 +832,37 @@ bool cros_ec_check_features(struct cros_ec_dev *ec, int feature)
> > > }
> > > EXPORT_SYMBOL_GPL(cros_ec_check_features);
> > >
> > > +/**
> > > + * cros_ec_pchg_port_count() - Return the number of peripheral charger ports.
> > > + * @ec: EC device.
> > > + *
> > > + * Return: Number of peripheral charger ports, or 0 in case of error.
> > > + */
> > > +unsigned int cros_ec_pchg_port_count(struct cros_ec_dev *ec)
> > > +{
> > > + struct cros_ec_command *msg;
> > > + const struct ec_response_pchg_count *rsp;
> > > + struct cros_ec_device *ec_dev = ec->ec_dev;
> > > + int ret, count = 0;
> > > +
> > > + msg = kzalloc(sizeof(*msg) + sizeof(*rsp), GFP_KERNEL);
> > > + if (!msg)
> > > + return 0;
> > > +
> > > + msg->command = EC_CMD_PCHG_COUNT + ec->cmd_offset;
> > > + msg->insize = sizeof(*rsp);
> > > +
> > > + ret = cros_ec_cmd_xfer_status(ec_dev, msg);
> > > + if (ret >= 0) {
> > > + rsp = (const struct ec_response_pchg_count *)msg->data;
> > > + count = rsp->port_count;
> > > + }
> > > + kfree(msg);
> >
> > Can we use the wrapper function cros_ec_command() [1] here, which does
> > the kzalloc and msg construction?
> >
>
> Sure. I take it that I can drop this function entirely then?
Yeah, if it's a simple response, should be fine.
> BTW, why is
> that function name the same as a struct name? It confuses my ctags.
Yeahhh, didn't think about ctags... :/
Topic for another series: probably can be renamed to cros_ec_cmd() (just to keep ctags happy) ?
Best regards,
-Prashant
next prev parent reply other threads:[~2022-04-18 23:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 0:32 [PATCH 0/3] platform/chrome: Only register PCHG if present Stephen Boyd
2022-04-15 0:32 ` [PATCH 1/3] platform/chrome: cros_ec_proto: Add peripheral charger count API Stephen Boyd
2022-04-18 3:23 ` Tzung-Bi Shih
2022-04-18 19:43 ` Stephen Boyd
2022-04-18 23:08 ` Prashant Malani
2022-04-18 23:16 ` Stephen Boyd
2022-04-18 23:21 ` Prashant Malani [this message]
2022-04-18 23:29 ` Stephen Boyd
2022-04-18 23:31 ` Prashant Malani
2022-04-18 23:41 ` Stephen Boyd
2022-04-15 0:32 ` [PATCH 2/3] mfd: cros_ec_dev: Only register PCHG device if present Stephen Boyd
2022-04-18 3:25 ` Tzung-Bi Shih
2022-04-15 0:32 ` [PATCH 3/3] power: supply: PCHG: Use cros_ec_pchg_port_count() Stephen Boyd
2022-04-18 3:26 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl3ykMvfCaQlQ7t9@chromium.org \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dnojiri@chromium.org \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).