From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
Lee Jones <lee.jones@linaro.org>,
Daisuke Nojiri <dnojiri@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH 1/3] platform/chrome: cros_ec_proto: Add peripheral charger count API
Date: Mon, 18 Apr 2022 11:23:27 +0800 [thread overview]
Message-ID: <YlzZr/UElg690/ru@google.com> (raw)
In-Reply-To: <20220415003253.1973106-2-swboyd@chromium.org>
On Thu, Apr 14, 2022 at 05:32:51PM -0700, Stephen Boyd wrote:
> Add a peripheral charger count API similar to the one implemented in the
> ChromeOS PCHG driver so we can use it to decide whether or not to
> register the PCHG device in the cros_ec MFD driver.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Daisuke Nojiri <dnojiri@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: <chrome-platform@lists.linux.dev>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
With a minor comment about the naming,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
> diff --git a/include/linux/platform_data/cros_ec_proto.h b/include/linux/platform_data/cros_ec_proto.h
> index df3c78c92ca2..8f5781bc2d7a 100644
> --- a/include/linux/platform_data/cros_ec_proto.h
> +++ b/include/linux/platform_data/cros_ec_proto.h
> @@ -230,6 +230,7 @@ u32 cros_ec_get_host_event(struct cros_ec_device *ec_dev);
> bool cros_ec_check_features(struct cros_ec_dev *ec, int feature);
>
> int cros_ec_get_sensor_count(struct cros_ec_dev *ec);
> +unsigned int cros_ec_pchg_port_count(struct cros_ec_dev *ec);
I wonder if "cros_ec_get_pchg_port_count" would be a better name for the API.
next prev parent reply other threads:[~2022-04-18 3:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 0:32 [PATCH 0/3] platform/chrome: Only register PCHG if present Stephen Boyd
2022-04-15 0:32 ` [PATCH 1/3] platform/chrome: cros_ec_proto: Add peripheral charger count API Stephen Boyd
2022-04-18 3:23 ` Tzung-Bi Shih [this message]
2022-04-18 19:43 ` Stephen Boyd
2022-04-18 23:08 ` Prashant Malani
2022-04-18 23:16 ` Stephen Boyd
2022-04-18 23:21 ` Prashant Malani
2022-04-18 23:29 ` Stephen Boyd
2022-04-18 23:31 ` Prashant Malani
2022-04-18 23:41 ` Stephen Boyd
2022-04-15 0:32 ` [PATCH 2/3] mfd: cros_ec_dev: Only register PCHG device if present Stephen Boyd
2022-04-18 3:25 ` Tzung-Bi Shih
2022-04-15 0:32 ` [PATCH 3/3] power: supply: PCHG: Use cros_ec_pchg_port_count() Stephen Boyd
2022-04-18 3:26 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlzZr/UElg690/ru@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dnojiri@chromium.org \
--cc=groeck@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).