* [PATCH v4 35/35] acpi/bus: Remove notify callback and flags
@ 2023-06-01 13:21 Michal Wilczynski
2023-06-02 1:08 ` David E. Box
0 siblings, 1 reply; 3+ messages in thread
From: Michal Wilczynski @ 2023-06-01 13:21 UTC (permalink / raw)
To: rafael, lenb, dan.j.williams, vishal.l.verma, dave.jiang,
ira.weiny, rui.zhang, jdelvare, linux, jic23, lars, bleung,
yu.c.chen, hdegoede, markgross, luzmaximilian, corentin.chary,
jprvita, cascardo, don, pali, jwoithe, matan, kenneth.t.chan,
malattia, jeremy, productdev, herton, coproscefalo, tytso, Jason,
robert.moore
Cc: linux-acpi, nvdimm, linux-hwmon, linux-iio, chrome-platform,
platform-driver-x86, acpi4asus-user, Michal Wilczynski,
acpica-devel
As callback has been replaced by drivers installing their handlers in
.add it's presence is not useful anymore.
Remove .notify callback and flags variable from struct acpi_driver,
as they're not needed anymore.
Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
---
include/acpi/acpi_bus.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index 7fb411438b6f..3326794d5b70 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -151,12 +151,10 @@ struct acpi_hotplug_context {
typedef int (*acpi_op_add) (struct acpi_device * device);
typedef void (*acpi_op_remove) (struct acpi_device *device);
-typedef void (*acpi_op_notify) (struct acpi_device * device, u32 event);
struct acpi_device_ops {
acpi_op_add add;
acpi_op_remove remove;
- acpi_op_notify notify;
};
#define ACPI_DRIVER_ALL_NOTIFY_EVENTS 0x1 /* system AND device events */
@@ -165,7 +163,6 @@ struct acpi_driver {
char name[80];
char class[80];
const struct acpi_device_id *ids; /* Supported Hardware IDs */
- unsigned int flags;
struct acpi_device_ops ops;
struct device_driver drv;
struct module *owner;
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4 35/35] acpi/bus: Remove notify callback and flags
2023-06-01 13:21 [PATCH v4 35/35] acpi/bus: Remove notify callback and flags Michal Wilczynski
@ 2023-06-02 1:08 ` David E. Box
2023-06-02 9:26 ` Wilczynski, Michal
0 siblings, 1 reply; 3+ messages in thread
From: David E. Box @ 2023-06-02 1:08 UTC (permalink / raw)
To: Michal Wilczynski, rafael, lenb, dan.j.williams, vishal.l.verma,
dave.jiang, ira.weiny, rui.zhang, jdelvare, linux, jic23, lars,
bleung, yu.c.chen, hdegoede, markgross, luzmaximilian,
corentin.chary, jprvita, cascardo, don, pali, jwoithe, matan,
kenneth.t.chan, malattia, jeremy, productdev, herton,
coproscefalo, tytso, Jason, robert.moore
Cc: linux-acpi, nvdimm, linux-hwmon, linux-iio, chrome-platform,
platform-driver-x86, acpi4asus-user, acpica-devel
Hi Michal,
On Thu, 2023-06-01 at 15:21 +0200, Michal Wilczynski wrote:
> As callback has been replaced by drivers installing their handlers in
> .add it's presence is not useful anymore.
>
> Remove .notify callback and flags variable from struct acpi_driver,
> as they're not needed anymore.
>
> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
> ---
> include/acpi/acpi_bus.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
> index 7fb411438b6f..3326794d5b70 100644
> --- a/include/acpi/acpi_bus.h
> +++ b/include/acpi/acpi_bus.h
> @@ -151,12 +151,10 @@ struct acpi_hotplug_context {
>
> typedef int (*acpi_op_add) (struct acpi_device * device);
> typedef void (*acpi_op_remove) (struct acpi_device *device);
> -typedef void (*acpi_op_notify) (struct acpi_device * device, u32 event);
>
> struct acpi_device_ops {
> acpi_op_add add;
> acpi_op_remove remove;
> - acpi_op_notify notify;
> };
>
> #define ACPI_DRIVER_ALL_NOTIFY_EVENTS 0x1 /* system AND device events */
> @@ -165,7 +163,6 @@ struct acpi_driver {
> char name[80];
> char class[80];
> const struct acpi_device_id *ids; /* Supported Hardware IDs */
> - unsigned int flags;
Can ACPI_DRIVER_ALL_NOTIFY_EVENTS be removed as well?
> struct acpi_device_ops ops;
> struct device_driver drv;
> struct module *owner;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 35/35] acpi/bus: Remove notify callback and flags
2023-06-02 1:08 ` David E. Box
@ 2023-06-02 9:26 ` Wilczynski, Michal
0 siblings, 0 replies; 3+ messages in thread
From: Wilczynski, Michal @ 2023-06-02 9:26 UTC (permalink / raw)
To: david.e.box, rafael, lenb, dan.j.williams, vishal.l.verma,
dave.jiang, ira.weiny, rui.zhang, jdelvare, linux, jic23, lars,
bleung, yu.c.chen, hdegoede, markgross, luzmaximilian,
corentin.chary, jprvita, cascardo, don, pali, jwoithe, matan,
kenneth.t.chan, malattia, jeremy, productdev, herton,
coproscefalo, tytso, Jason, robert.moore
Cc: linux-acpi, nvdimm, linux-hwmon, linux-iio, chrome-platform,
platform-driver-x86, acpi4asus-user, acpica-devel
On 6/2/2023 3:08 AM, David E. Box wrote:
> Hi Michal,
>
> On Thu, 2023-06-01 at 15:21 +0200, Michal Wilczynski wrote:
>> As callback has been replaced by drivers installing their handlers in
>> .add it's presence is not useful anymore.
>>
>> Remove .notify callback and flags variable from struct acpi_driver,
>> as they're not needed anymore.
>>
>> Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
>> ---
>> include/acpi/acpi_bus.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
>> index 7fb411438b6f..3326794d5b70 100644
>> --- a/include/acpi/acpi_bus.h
>> +++ b/include/acpi/acpi_bus.h
>> @@ -151,12 +151,10 @@ struct acpi_hotplug_context {
>>
>> typedef int (*acpi_op_add) (struct acpi_device * device);
>> typedef void (*acpi_op_remove) (struct acpi_device *device);
>> -typedef void (*acpi_op_notify) (struct acpi_device * device, u32 event);
>>
>> struct acpi_device_ops {
>> acpi_op_add add;
>> acpi_op_remove remove;
>> - acpi_op_notify notify;
>> };
>>
>> #define ACPI_DRIVER_ALL_NOTIFY_EVENTS 0x1 /* system AND device events */
>> @@ -165,7 +163,6 @@ struct acpi_driver {
>> char name[80];
>> char class[80];
>> const struct acpi_device_id *ids; /* Supported Hardware IDs */
>> - unsigned int flags;
> Can ACPI_DRIVER_ALL_NOTIFY_EVENTS be removed as well?
Hi David,
Oh yeah, it should be removed as well,
Thanks !
>
>> struct acpi_device_ops ops;
>> struct device_driver drv;
>> struct module *owner;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-02 9:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 13:21 [PATCH v4 35/35] acpi/bus: Remove notify callback and flags Michal Wilczynski
2023-06-02 1:08 ` David E. Box
2023-06-02 9:26 ` Wilczynski, Michal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).