* [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well
@ 2021-01-11 15:48 Henning Schild
2021-01-13 10:46 ` Jan Kiszka
0 siblings, 1 reply; 8+ messages in thread
From: Henning Schild @ 2021-01-11 15:48 UTC (permalink / raw)
To: cip-dev; +Cc: Claudius Heine, Henning Schild
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
From: Claudius Heine <ch@denx.de>
Signed-off-by: Claudius Heine <ch@denx.de>
Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
classes/swupdate-img.bbclass | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/classes/swupdate-img.bbclass b/classes/swupdate-img.bbclass
index a21d6ec..a7a70f6 100644
--- a/classes/swupdate-img.bbclass
+++ b/classes/swupdate-img.bbclass
@@ -39,14 +39,14 @@ do_swupdate_image() {
image_do_mounts
cp -f '${SIGN_KEY}' '${WORKDIR}/dev.key'
test -e '${SIGN_CRT}' && cp -f '${SIGN_CRT}' '${WORKDIR}/dev.crt'
-
- # Fill in file check sums
- for file in ${SWU_ADDITIONAL_FILES}; do
- sed -i "s:$file-sha256:$(sha256sum '${WORKDIR}/swu/'$file | cut -f 1 -d ' '):g" \
- '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
- done
fi
+ # Fill in file check sums
+ for file in ${SWU_ADDITIONAL_FILES}; do
+ sed -i "s:$file-sha256:$(sha256sum '${WORKDIR}/swu/'$file | cut -f 1 -d ' '):g" \
+ '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
+ done
+
cd "${WORKDIR}/swu"
for file in '${SWU_DESCRIPTION_FILE}' ${SWU_ADDITIONAL_FILES}; do
echo "$file"
--
2.26.2
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6060): https://lists.cip-project.org/g/cip-dev/message/6060
Mute This Topic: https://lists.cip-project.org/mt/79598691/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well
2021-01-11 15:48 [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well Henning Schild
@ 2021-01-13 10:46 ` Jan Kiszka
2021-01-13 10:52 ` Claudius Heine
2021-01-13 11:09 ` Henning Schild
0 siblings, 2 replies; 8+ messages in thread
From: Jan Kiszka @ 2021-01-13 10:46 UTC (permalink / raw)
To: cip-dev, Henning Schild; +Cc: Claudius Heine
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
On 11.01.21 16:48, Henning Schild wrote:
> From: Claudius Heine <ch@denx.de>
>
Can you also provide a reasoning here?
> Signed-off-by: Claudius Heine <ch@denx.de>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
> classes/swupdate-img.bbclass | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/classes/swupdate-img.bbclass b/classes/swupdate-img.bbclass
> index a21d6ec..a7a70f6 100644
> --- a/classes/swupdate-img.bbclass
> +++ b/classes/swupdate-img.bbclass
> @@ -39,14 +39,14 @@ do_swupdate_image() {
> image_do_mounts
> cp -f '${SIGN_KEY}' '${WORKDIR}/dev.key'
> test -e '${SIGN_CRT}' && cp -f '${SIGN_CRT}' '${WORKDIR}/dev.crt'
> -
> - # Fill in file check sums
> - for file in ${SWU_ADDITIONAL_FILES}; do
> - sed -i "s:$file-sha256:$(sha256sum '${WORKDIR}/swu/'$file | cut -f 1 -d ' '):g" \
> - '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
> - done
> fi
>
> + # Fill in file check sums
> + for file in ${SWU_ADDITIONAL_FILES}; do
> + sed -i "s:$file-sha256:$(sha256sum '${WORKDIR}/swu/'$file | cut -f 1 -d ' '):g" \
> + '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
> + done
> +
> cd "${WORKDIR}/swu"
> for file in '${SWU_DESCRIPTION_FILE}' ${SWU_ADDITIONAL_FILES}; do
> echo "$file"
>
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6063): https://lists.cip-project.org/g/cip-dev/message/6063
Mute This Topic: https://lists.cip-project.org/mt/79598691/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well
2021-01-13 10:46 ` Jan Kiszka
@ 2021-01-13 10:52 ` Claudius Heine
2021-01-13 10:55 ` Jan Kiszka
2021-01-13 11:09 ` Henning Schild
1 sibling, 1 reply; 8+ messages in thread
From: Claudius Heine @ 2021-01-13 10:52 UTC (permalink / raw)
To: Jan Kiszka, cip-dev, Henning Schild
[-- Attachment #1: Type: text/plain, Size: 2164 bytes --]
Hi Jan,
On 2021-01-13 11:46, Jan Kiszka wrote:
> On 11.01.21 16:48, Henning Schild wrote:
>> From: Claudius Heine <ch@denx.de>
>>
>
> Can you also provide a reasoning here?
I can, but I guess you mean that a commit message should be added here.
Our swupdate has `DISABLE_CPIO_CRC=y` (because our images might be >2GB)
and we also currently support update via usb stick without any
signatures. So the only checksum that we have would be the sha256sum
inside the swdescription.
regards,
Claudius
>
>> Signed-off-by: Claudius Heine <ch@denx.de>
>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>> ---
>> classes/swupdate-img.bbclass | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/classes/swupdate-img.bbclass b/classes/swupdate-img.bbclass
>> index a21d6ec..a7a70f6 100644
>> --- a/classes/swupdate-img.bbclass
>> +++ b/classes/swupdate-img.bbclass
>> @@ -39,14 +39,14 @@ do_swupdate_image() {
>> image_do_mounts
>> cp -f '${SIGN_KEY}' '${WORKDIR}/dev.key'
>> test -e '${SIGN_CRT}' && cp -f '${SIGN_CRT}' '${WORKDIR}/dev.crt'
>> -
>> - # Fill in file check sums
>> - for file in ${SWU_ADDITIONAL_FILES}; do
>> - sed -i "s:$file-sha256:$(sha256sum '${WORKDIR}/swu/'$file | cut -f 1 -d ' '):g" \
>> - '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
>> - done
>> fi
>>
>> + # Fill in file check sums
>> + for file in ${SWU_ADDITIONAL_FILES}; do
>> + sed -i "s:$file-sha256:$(sha256sum '${WORKDIR}/swu/'$file | cut -f 1 -d ' '):g" \
>> + '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
>> + done
>> +
>> cd "${WORKDIR}/swu"
>> for file in '${SWU_DESCRIPTION_FILE}' ${SWU_ADDITIONAL_FILES}; do
>> echo "$file"
>>
>
> Jan
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
Keyserver: hkp://pool.sks-keyservers.net
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6066): https://lists.cip-project.org/g/cip-dev/message/6066
Mute This Topic: https://lists.cip-project.org/mt/79598691/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well
2021-01-13 10:52 ` Claudius Heine
@ 2021-01-13 10:55 ` Jan Kiszka
2021-01-13 11:02 ` Claudius Heine
0 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2021-01-13 10:55 UTC (permalink / raw)
To: Claudius Heine, cip-dev, Henning Schild
[-- Attachment #1: Type: text/plain, Size: 2251 bytes --]
On 13.01.21 11:52, Claudius Heine wrote:
> Hi Jan,
>
> On 2021-01-13 11:46, Jan Kiszka wrote:
>> On 11.01.21 16:48, Henning Schild wrote:
>>> From: Claudius Heine <ch@denx.de>
>>>
>>
>> Can you also provide a reasoning here?
>
> I can, but I guess you mean that a commit message should be added here.
>
...or that you provide me a text I can fill in on merge.
Jan
> Our swupdate has `DISABLE_CPIO_CRC=y` (because our images might be >2GB)
> and we also currently support update via usb stick without any
> signatures. So the only checksum that we have would be the sha256sum
> inside the swdescription.
>
> regards,
> Claudius
>
>>
>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>>> ---
>>> classes/swupdate-img.bbclass | 12 ++++++------
>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/classes/swupdate-img.bbclass b/classes/swupdate-img.bbclass
>>> index a21d6ec..a7a70f6 100644
>>> --- a/classes/swupdate-img.bbclass
>>> +++ b/classes/swupdate-img.bbclass
>>> @@ -39,14 +39,14 @@ do_swupdate_image() {
>>> image_do_mounts
>>> cp -f '${SIGN_KEY}' '${WORKDIR}/dev.key'
>>> test -e '${SIGN_CRT}' && cp -f '${SIGN_CRT}'
>>> '${WORKDIR}/dev.crt'
>>> -
>>> - # Fill in file check sums
>>> - for file in ${SWU_ADDITIONAL_FILES}; do
>>> - sed -i "s:$file-sha256:$(sha256sum
>>> '${WORKDIR}/swu/'$file | cut -f 1 -d ' '):g" \
>>> - '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
>>> - done
>>> fi
>>> + # Fill in file check sums
>>> + for file in ${SWU_ADDITIONAL_FILES}; do
>>> + sed -i "s:$file-sha256:$(sha256sum '${WORKDIR}/swu/'$file |
>>> cut -f 1 -d ' '):g" \
>>> + '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
>>> + done
>>> +
>>> cd "${WORKDIR}/swu"
>>> for file in '${SWU_DESCRIPTION_FILE}' ${SWU_ADDITIONAL_FILES}; do
>>> echo "$file"
>>>
>>
>> Jan
>>
>
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6064): https://lists.cip-project.org/g/cip-dev/message/6064
Mute This Topic: https://lists.cip-project.org/mt/79598691/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well
2021-01-13 10:55 ` Jan Kiszka
@ 2021-01-13 11:02 ` Claudius Heine
2021-01-13 11:33 ` Jan Kiszka
0 siblings, 1 reply; 8+ messages in thread
From: Claudius Heine @ 2021-01-13 11:02 UTC (permalink / raw)
To: Jan Kiszka, cip-dev, Henning Schild
[-- Attachment #1: Type: text/plain, Size: 2964 bytes --]
On 2021-01-13 11:55, Jan Kiszka wrote:
> On 13.01.21 11:52, Claudius Heine wrote:
>> Hi Jan,
>>
>> On 2021-01-13 11:46, Jan Kiszka wrote:
>>> On 11.01.21 16:48, Henning Schild wrote:
>>>> From: Claudius Heine <ch@denx.de>
>>>>
>>>
>>> Can you also provide a reasoning here?
>>
>> I can, but I guess you mean that a commit message should be added here.
>>
>
> ...or that you provide me a text I can fill in on merge.
Ok here is my take:
```
Also unsigned images should contain a checksum in the swdescription, for
instance in case `DISABLE_CPIO_CRC=y` is set in swupdate and a USB stick
is used for update delivery, only such a checksum would protect against
file corruption.
```
regards,
Claudius
>
> Jan
>
>> Our swupdate has `DISABLE_CPIO_CRC=y` (because our images might be >2GB)
>> and we also currently support update via usb stick without any
>> signatures. So the only checksum that we have would be the sha256sum
>> inside the swdescription.
>>
>> regards,
>> Claudius
>>
>>>
>>>> Signed-off-by: Claudius Heine <ch@denx.de>
>>>> Signed-off-by: Henning Schild <henning.schild@siemens.com>
>>>> ---
>>>> classes/swupdate-img.bbclass | 12 ++++++------
>>>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/classes/swupdate-img.bbclass b/classes/swupdate-img.bbclass
>>>> index a21d6ec..a7a70f6 100644
>>>> --- a/classes/swupdate-img.bbclass
>>>> +++ b/classes/swupdate-img.bbclass
>>>> @@ -39,14 +39,14 @@ do_swupdate_image() {
>>>> image_do_mounts
>>>> cp -f '${SIGN_KEY}' '${WORKDIR}/dev.key'
>>>> test -e '${SIGN_CRT}' && cp -f '${SIGN_CRT}'
>>>> '${WORKDIR}/dev.crt'
>>>> -
>>>> - # Fill in file check sums
>>>> - for file in ${SWU_ADDITIONAL_FILES}; do
>>>> - sed -i "s:$file-sha256:$(sha256sum
>>>> '${WORKDIR}/swu/'$file | cut -f 1 -d ' '):g" \
>>>> - '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
>>>> - done
>>>> fi
>>>> + # Fill in file check sums
>>>> + for file in ${SWU_ADDITIONAL_FILES}; do
>>>> + sed -i "s:$file-sha256:$(sha256sum '${WORKDIR}/swu/'$file |
>>>> cut -f 1 -d ' '):g" \
>>>> + '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
>>>> + done
>>>> +
>>>> cd "${WORKDIR}/swu"
>>>> for file in '${SWU_DESCRIPTION_FILE}' ${SWU_ADDITIONAL_FILES}; do
>>>> echo "$file"
>>>>
>>>
>>> Jan
>>>
>>
>
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
PGP key: 6FF2 E59F 00C6 BC28 31D8 64C1 1173 CB19 9808 B153
Keyserver: hkp://pool.sks-keyservers.net
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6067): https://lists.cip-project.org/g/cip-dev/message/6067
Mute This Topic: https://lists.cip-project.org/mt/79598691/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well
2021-01-13 10:46 ` Jan Kiszka
2021-01-13 10:52 ` Claudius Heine
@ 2021-01-13 11:09 ` Henning Schild
1 sibling, 0 replies; 8+ messages in thread
From: Henning Schild @ 2021-01-13 11:09 UTC (permalink / raw)
To: Jan Kiszka, Claudius Heine; +Cc: cip-dev
[-- Attachment #1: Type: text/plain, Size: 1963 bytes --]
Am Wed, 13 Jan 2021 11:46:03 +0100
schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> On 11.01.21 16:48, Henning Schild wrote:
> > From: Claudius Heine <ch@denx.de>
> >
>
> Can you also provide a reasoning here?
This is taken from a layer where we use a postupdate-script as part of
an swu. The whole swu is not signed, still we want basic integrity
checking based on checksums.
My guess is that whenever you have SWU_ADDITIONAL_FILES and do not
sign, you might get a problem because of missing checksums.
But i would wait for Claudius to provide the reasoning. I guess it
should become part of the commit message in a v2.
Henning
> > Signed-off-by: Claudius Heine <ch@denx.de>
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> > classes/swupdate-img.bbclass | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/classes/swupdate-img.bbclass
> > b/classes/swupdate-img.bbclass index a21d6ec..a7a70f6 100644
> > --- a/classes/swupdate-img.bbclass
> > +++ b/classes/swupdate-img.bbclass
> > @@ -39,14 +39,14 @@ do_swupdate_image() {
> > image_do_mounts
> > cp -f '${SIGN_KEY}' '${WORKDIR}/dev.key'
> > test -e '${SIGN_CRT}' && cp -f '${SIGN_CRT}'
> > '${WORKDIR}/dev.crt' -
> > - # Fill in file check sums
> > - for file in ${SWU_ADDITIONAL_FILES}; do
> > - sed -i "s:$file-sha256:$(sha256sum
> > '${WORKDIR}/swu/'$file | cut -f 1 -d ' '):g" \
> > - '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
> > - done
> > fi
> >
> > + # Fill in file check sums
> > + for file in ${SWU_ADDITIONAL_FILES}; do
> > + sed -i "s:$file-sha256:$(sha256sum '${WORKDIR}/swu/'$file
> > | cut -f 1 -d ' '):g" \
> > + '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
> > + done
> > +
> > cd "${WORKDIR}/swu"
> > for file in '${SWU_DESCRIPTION_FILE}' ${SWU_ADDITIONAL_FILES};
> > do echo "$file"
> >
>
> Jan
>
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6068): https://lists.cip-project.org/g/cip-dev/message/6068
Mute This Topic: https://lists.cip-project.org/mt/79598691/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well
2021-01-13 11:02 ` Claudius Heine
@ 2021-01-13 11:33 ` Jan Kiszka
2021-01-13 12:33 ` Henning Schild
0 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2021-01-13 11:33 UTC (permalink / raw)
To: Claudius Heine, cip-dev, Henning Schild
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On 13.01.21 12:02, Claudius Heine wrote:
> On 2021-01-13 11:55, Jan Kiszka wrote:
>> On 13.01.21 11:52, Claudius Heine wrote:
>>> Hi Jan,
>>>
>>> On 2021-01-13 11:46, Jan Kiszka wrote:
>>>> On 11.01.21 16:48, Henning Schild wrote:
>>>>> From: Claudius Heine <ch@denx.de>
>>>>>
>>>>
>>>> Can you also provide a reasoning here?
>>>
>>> I can, but I guess you mean that a commit message should be added here.
>>>
>>
>> ...or that you provide me a text I can fill in on merge.
>
> Ok here is my take:
>
> ```
> Also unsigned images should contain a checksum in the swdescription, for
> instance in case `DISABLE_CPIO_CRC=y` is set in swupdate and a USB stick
> is used for update delivery, only such a checksum would protect against
> file corruption.
> ```
>
Thanks, applied with this text.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6065): https://lists.cip-project.org/g/cip-dev/message/6065
Mute This Topic: https://lists.cip-project.org/mt/79598691/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well
2021-01-13 11:33 ` Jan Kiszka
@ 2021-01-13 12:33 ` Henning Schild
0 siblings, 0 replies; 8+ messages in thread
From: Henning Schild @ 2021-01-13 12:33 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Claudius Heine, cip-dev
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
Am Wed, 13 Jan 2021 12:33:12 +0100
schrieb Jan Kiszka <jan.kiszka@siemens.com>:
> On 13.01.21 12:02, Claudius Heine wrote:
> > On 2021-01-13 11:55, Jan Kiszka wrote:
> >> On 13.01.21 11:52, Claudius Heine wrote:
> >>> Hi Jan,
> >>>
> >>> On 2021-01-13 11:46, Jan Kiszka wrote:
> >>>> On 11.01.21 16:48, Henning Schild wrote:
> >>>>> From: Claudius Heine <ch@denx.de>
> >>>>>
> >>>>
> >>>> Can you also provide a reasoning here?
> >>>
> >>> I can, but I guess you mean that a commit message should be added
> >>> here.
> >>
> >> ...or that you provide me a text I can fill in on merge.
> >
> > Ok here is my take:
> >
> > ```
> > Also unsigned images should contain a checksum in the
> > swdescription, for instance in case `DISABLE_CPIO_CRC=y` is set in
> > swupdate and a USB stick is used for update delivery, only such a
> > checksum would protect against file corruption.
> > ```
> >
>
> Thanks, applied with this text.
Sweet, thanks!
@claudius this might be ready to pull into our layer anytime soon,
should be patch-free now
Henning
> Jan
>
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6069): https://lists.cip-project.org/g/cip-dev/message/6069
Mute This Topic: https://lists.cip-project.org/mt/79598691/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-01-13 12:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 15:48 [cip-dev] [isar-cip-core] [PATCH] swupdate-img.bbclass: add checksum in non signed case as well Henning Schild
2021-01-13 10:46 ` Jan Kiszka
2021-01-13 10:52 ` Claudius Heine
2021-01-13 10:55 ` Jan Kiszka
2021-01-13 11:02 ` Claudius Heine
2021-01-13 11:33 ` Jan Kiszka
2021-01-13 12:33 ` Henning Schild
2021-01-13 11:09 ` Henning Schild
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).