Re: [cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-snakeoil: drop space in remove override

Re: [cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-snakeoil: drop space in remove override

[Arjunan, Srinu]

Can you please merge this change?

-----Original Message-----
From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Srinuvasan A
Sent: 06 March 2023 16:54
To: cip-dev@lists.cip-project.org
Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>; Arjunan, Srinu (DI SW CAS ES LI PBU RSOL) <srinuvasan.a@siemens.com>
Subject: [cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-snakeoil: drop space in remove override

From: Srinuvasan A <srinuvasan.a@siemens.com>

remove does not need leading spaces in front of the package, hence drop this one.

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 doc/README.secureboot.md             | 2 +-
 kas/opt/ebg-secure-boot-snakeoil.yml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/README.secureboot.md b/doc/README.secureboot.md index 54d67c7..bc238fb 100644
--- a/doc/README.secureboot.md
+++ b/doc/README.secureboot.md
@@ -154,7 +154,7 @@ local_conf_header:
     WKS_FILE = "${MACHINE}-efibootguard-secureboot.wks.in"
     INITRAMFS_INSTALL:append = " initramfs-verity-hook"
     # abrootfs cannot be installed together with verity
-    INITRAMFS_INSTALL:remove = " initramfs-abrootfs-hook"
+    INITRAMFS_INSTALL:remove = "initramfs-abrootfs-hook"
 
 local_conf_header:
   secure-boot: |
diff --git a/kas/opt/ebg-secure-boot-snakeoil.yml b/kas/opt/ebg-secure-boot-snakeoil.yml
index 3d0e3c9..f787c82 100644
--- a/kas/opt/ebg-secure-boot-snakeoil.yml
+++ b/kas/opt/ebg-secure-boot-snakeoil.yml
@@ -22,7 +22,7 @@ local_conf_header:
     WKS_FILE = "${MACHINE}-efibootguard-secureboot.wks.in"
     INITRAMFS_INSTALL:append = " initramfs-verity-hook"
     # abrootfs cannot be installed together with verity
-    INITRAMFS_INSTALL:remove = " initramfs-abrootfs-hook"
+    INITRAMFS_INSTALL:remove = "initramfs-abrootfs-hook"
 
   secure-boot: |
     IMAGER_BUILD_DEPS += "ebg-secure-boot-signer"
--
2.34.1

Re: [cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-snakeoil: drop space in remove override

[Jan Kiszka]

On 10.03.23 10:26, Arjunan, Srinu (DI SW CAS ES LI PBU RSOL) wrote:
> Can you please merge this change?
> 

Looks like a reported this as merged but somehow lost that state. It was
still applying and is now truly in next.

Thanks,
Jan

> -----Original Message-----
> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf Of Srinuvasan A
> Sent: 06 March 2023 16:54
> To: cip-dev@lists.cip-project.org
> Cc: Kiszka, Jan (T CED) <jan.kiszka@siemens.com>; Arjunan, Srinu (DI SW CAS ES LI PBU RSOL) <srinuvasan.a@siemens.com>
> Subject: [cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-snakeoil: drop space in remove override
> 
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> remove does not need leading spaces in front of the package, hence drop this one.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  doc/README.secureboot.md             | 2 +-
>  kas/opt/ebg-secure-boot-snakeoil.yml | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/README.secureboot.md b/doc/README.secureboot.md index 54d67c7..bc238fb 100644
> --- a/doc/README.secureboot.md
> +++ b/doc/README.secureboot.md
> @@ -154,7 +154,7 @@ local_conf_header:
>      WKS_FILE = "${MACHINE}-efibootguard-secureboot.wks.in"
>      INITRAMFS_INSTALL:append = " initramfs-verity-hook"
>      # abrootfs cannot be installed together with verity
> -    INITRAMFS_INSTALL:remove = " initramfs-abrootfs-hook"
> +    INITRAMFS_INSTALL:remove = "initramfs-abrootfs-hook"
>  
>  local_conf_header:
>    secure-boot: |
> diff --git a/kas/opt/ebg-secure-boot-snakeoil.yml b/kas/opt/ebg-secure-boot-snakeoil.yml
> index 3d0e3c9..f787c82 100644
> --- a/kas/opt/ebg-secure-boot-snakeoil.yml
> +++ b/kas/opt/ebg-secure-boot-snakeoil.yml
> @@ -22,7 +22,7 @@ local_conf_header:
>      WKS_FILE = "${MACHINE}-efibootguard-secureboot.wks.in"
>      INITRAMFS_INSTALL:append = " initramfs-verity-hook"
>      # abrootfs cannot be installed together with verity
> -    INITRAMFS_INSTALL:remove = " initramfs-abrootfs-hook"
> +    INITRAMFS_INSTALL:remove = "initramfs-abrootfs-hook"
>  
>    secure-boot: |
>      IMAGER_BUILD_DEPS += "ebg-secure-boot-signer"
> --
> 2.34.1
> 

-- 
Siemens AG, Technology
Competence Center Embedded Linux