* [Cocci] [PATCH v4] provide rule for finding refcounters @ 2017-08-30 6:15 Elena Reshetova 2017-08-30 6:15 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova 2017-08-30 10:21 ` [Cocci] [PATCH v4] provide rule for finding refcounters SF Markus Elfring 0 siblings, 2 replies; 9+ messages in thread From: Elena Reshetova @ 2017-08-30 6:15 UTC (permalink / raw) To: cocci changes in v4: Removed unnessesary "()" around expression in rule 4. changes in v3: Removed unnessesary rule 4 conditions pointed by Julia. changes in v2: Following the suggestion from Julia the first rule is split into 2. The output does not differ that much between these two versions, but rule became more precise. Elena Reshetova (1): Coccinelle: add atomic_as_refcounter script scripts/coccinelle/api/atomic_as_refcounter.cocci | 131 ++++++++++++++++++++++ 1 file changed, 131 insertions(+) create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci -- 2.7.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script 2017-08-30 6:15 [Cocci] [PATCH v4] provide rule for finding refcounters Elena Reshetova @ 2017-08-30 6:15 ` Elena Reshetova 2017-08-30 10:36 ` [Cocci] [PATCH v4] " SF Markus Elfring 2017-08-30 12:26 ` [Cocci] [PATCH] " Julia Lawall 2017-08-30 10:21 ` [Cocci] [PATCH v4] provide rule for finding refcounters SF Markus Elfring 1 sibling, 2 replies; 9+ messages in thread From: Elena Reshetova @ 2017-08-30 6:15 UTC (permalink / raw) To: cocci atomic_as_refcounter.cocci script allows detecting cases when refcount_t type and API should be used instead of atomic_t. Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> --- scripts/coccinelle/api/atomic_as_refcounter.cocci | 131 ++++++++++++++++++++++ 1 file changed, 131 insertions(+) create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci b/scripts/coccinelle/api/atomic_as_refcounter.cocci new file mode 100644 index 0000000..f83771b --- /dev/null +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci @@ -0,0 +1,131 @@ +// Check if refcount_t type and API should be used +// instead of atomic_t type when dealing with refcounters +// +// Copyright (c) 2016-2017, Elena Reshetova, Intel Corporation +// +// Confidence: Moderate +// URL: http://coccinelle.lip6.fr/ +// Options: --include-headers --very-quiet + +virtual report + + at r1 exists@ +identifier a, x, y; +position p1, p2; +identifier fname =~ ".*free.*"; +identifier fname2 =~ ".*destroy.*"; +identifier fname3 =~ ".*del.*"; +identifier fname4 =~ ".*queue_work.*"; +identifier fname5 =~ ".*schedule_work.*"; +identifier fname6 =~ ".*call_rcu.*"; + +@@ + +( + atomic_dec_and_test at p1(&(a)->x) +| + atomic_dec_and_lock at p1(&(a)->x, ...) +| + atomic_long_dec_and_lock at p1(&(a)->x, ...) +| + atomic_long_dec_and_test at p1(&(a)->x) +| + atomic64_dec_and_test at p1(&(a)->x) +| + local_dec_and_test at p1(&(a)->x) +) +... +( + fname at p2(a, ...); +| + fname2 at p2(...); +| + fname3 at p2(...); +| + fname4 at p2(...); +| + fname5 at p2(...); +| + fname6 at p2(...); +) + + + at script:python depends on report@ +p1 << r1.p1; +p2 << r1.p2; +@@ +msg = "atomic_dec_and_test variation before object free at line %s." +coccilib.report.print_report(p1[0], msg % (p2[0].line)) + + at r4 exists@ +identifier a, x, y; +position p1, p2; +identifier fname =~ ".*free.*"; + +@@ + +( + atomic_dec_and_test@p1(&(a)->x) +| + atomic_dec_and_lock at p1(&(a)->x, ...) +| + atomic_long_dec_and_lock at p1(&(a)->x, ...) +| + atomic_long_dec_and_test at p1(&(a)->x) +| + atomic64_dec_and_test at p1(&(a)->x) +| + local_dec_and_test at p1(&(a)->x) +) +... +y=a +... +fname at p2(y, ...); + + + at script:python depends on report@ +p1 << r4.p1; +p2 << r4.p2; +@@ +msg = "atomic_dec_and_test variation before object free at line %s." +coccilib.report.print_report(p1[0], msg % (p2[0].line)) + +@r2 exists@ +identifier a, x; +position p1; +@@ + +( +atomic_add_unless(&(a)->x,-1,1)@p1 +| +atomic_long_add_unless(&(a)->x,-1,1)@p1 +| +atomic64_add_unless(&(a)->x,-1,1)@p1 +) + + at script:python depends on report@ +p1 << r2.p1; +@@ +msg = "atomic_add_unless" +coccilib.report.print_report(p1[0], msg) + + at r3 exists@ +identifier x; +position p1; +@@ + +( +x = atomic_add_return at p1(-1, ...); +| +x = atomic_long_add_return at p1(-1, ...); +| +x = atomic64_add_return at p1(-1, ...); +) + +@script:python depends on report@ +p1 << r3.p1; +@@ +msg = "x = atomic_add_return(-1, ...)" +coccilib.report.print_report(p1[0], msg) + + -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Cocci] [PATCH v4] Coccinelle: add atomic_as_refcounter script 2017-08-30 6:15 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova @ 2017-08-30 10:36 ` SF Markus Elfring 2017-08-30 12:26 ` [Cocci] [PATCH] " Julia Lawall 1 sibling, 0 replies; 9+ messages in thread From: SF Markus Elfring @ 2017-08-30 10:36 UTC (permalink / raw) To: cocci Dear Elena, I hoped on a more constructive feedback for remaining implementation details which should be reconsidered once more. https://systeme.lip6.fr/pipermail/cocci/2017-August/004341.html * Will any more revisions be needed for your evolving script until special development concerns will be taken into account appropriately? * How do you prefer to clarify unsafe search patterns finally? Regards, Markus ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script 2017-08-30 6:15 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova 2017-08-30 10:36 ` [Cocci] [PATCH v4] " SF Markus Elfring @ 2017-08-30 12:26 ` Julia Lawall 2017-08-30 12:44 ` Reshetova, Elena 1 sibling, 1 reply; 9+ messages in thread From: Julia Lawall @ 2017-08-30 12:26 UTC (permalink / raw) To: cocci On Wed, 30 Aug 2017, Elena Reshetova wrote: > atomic_as_refcounter.cocci script allows detecting > cases when refcount_t type and API should be used > instead of atomic_t. > > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> > --- > scripts/coccinelle/api/atomic_as_refcounter.cocci | 131 ++++++++++++++++++++++ > 1 file changed, 131 insertions(+) > create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci > > diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci b/scripts/coccinelle/api/atomic_as_refcounter.cocci > new file mode 100644 > index 0000000..f83771b > --- /dev/null > +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci > @@ -0,0 +1,131 @@ > +// Check if refcount_t type and API should be used > +// instead of atomic_t type when dealing with refcounters > +// > +// Copyright (c) 2016-2017, Elena Reshetova, Intel Corporation > +// > +// Confidence: Moderate > +// URL: http://coccinelle.lip6.fr/ > +// Options: --include-headers --very-quiet > + > +virtual report > + > + at r1 exists@ > +identifier a, x, y; > +position p1, p2; > +identifier fname =~ ".*free.*"; > +identifier fname2 =~ ".*destroy.*"; > +identifier fname3 =~ ".*del.*"; > +identifier fname4 =~ ".*queue_work.*"; > +identifier fname5 =~ ".*schedule_work.*"; > +identifier fname6 =~ ".*call_rcu.*"; > + > +@@ > + > +( > + atomic_dec_and_test at p1(&(a)->x) > +| > + atomic_dec_and_lock at p1(&(a)->x, ...) > +| > + atomic_long_dec_and_lock at p1(&(a)->x, ...) > +| > + atomic_long_dec_and_test at p1(&(a)->x) > +| > + atomic64_dec_and_test at p1(&(a)->x) > +| > + local_dec_and_test at p1(&(a)->x) > +) > +... > +( > + fname at p2(a, ...); > +| > + fname2 at p2(...); > +| > + fname3 at p2(...); > +| > + fname4 at p2(...); > +| > + fname5 at p2(...); > +| > + fname6 at p2(...); > +) > + > + > + at script:python depends on report@ > +p1 << r1.p1; > +p2 << r1.p2; > +@@ > +msg = "atomic_dec_and_test variation before object free at line %s." > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > + > + at r4 exists@ > +identifier a, x, y; > +position p1, p2; > +identifier fname =~ ".*free.*"; > + > +@@ > + > +( > + atomic_dec_and_test at p1(&(a)->x) > +| > + atomic_dec_and_lock at p1(&(a)->x, ...) > +| > + atomic_long_dec_and_lock at p1(&(a)->x, ...) > +| > + atomic_long_dec_and_test at p1(&(a)->x) > +| > + atomic64_dec_and_test at p1(&(a)->x) > +| > + local_dec_and_test at p1(&(a)->x) > +) > +... > +y=a > +... > +fname at p2(y, ...); > + > + > + at script:python depends on report@ > +p1 << r4.p1; > +p2 << r4.p2; > +@@ > +msg = "atomic_dec_and_test variation before object free at line %s." > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > + > + at r2 exists@ > +identifier a, x; > +position p1; > +@@ > + > +( > +atomic_add_unless(&(a)->x,-1,1)@p1 > +| > +atomic_long_add_unless(&(a)->x,-1,1)@p1 > +| > +atomic64_add_unless(&(a)->x,-1,1)@p1 > +) > + > + at script:python depends on report@ > +p1 << r2.p1; > +@@ > +msg = "atomic_add_unless" > +coccilib.report.print_report(p1[0], msg) > + > + at r3 exists@ > +identifier x; > +position p1; > +@@ > + > +( > +x = atomic_add_return at p1(-1, ...); > +| > +x = atomic_long_add_return at p1(-1, ...); > +| > +x = atomic64_add_return at p1(-1, ...); > +) > + > + at script:python depends on report@ > +p1 << r3.p1; > +@@ > +msg = "x = atomic_add_return(-1, ...)" > +coccilib.report.print_report(p1[0], msg) > + > + > -- > 2.7.4 > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script 2017-08-30 12:26 ` [Cocci] [PATCH] " Julia Lawall @ 2017-08-30 12:44 ` Reshetova, Elena 2017-08-30 13:06 ` Julia Lawall 2017-08-30 13:43 ` [Cocci] [PATCH v4] " SF Markus Elfring 0 siblings, 2 replies; 9+ messages in thread From: Reshetova, Elena @ 2017-08-30 12:44 UTC (permalink / raw) To: cocci > > On Wed, 30 Aug 2017, Elena Reshetova wrote: > > > atomic_as_refcounter.cocci script allows detecting > > cases when refcount_t type and API should be used > > instead of atomic_t. > > > > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> Thank you very much Julia! What is the correct path to merge this? I will resend with your acked-by, but what is the tree that should merge it? Best Regards, Elena. > > > --- > > scripts/coccinelle/api/atomic_as_refcounter.cocci | 131 > ++++++++++++++++++++++ > > 1 file changed, 131 insertions(+) > > create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci > > > > diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci > b/scripts/coccinelle/api/atomic_as_refcounter.cocci > > new file mode 100644 > > index 0000000..f83771b > > --- /dev/null > > +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci > > @@ -0,0 +1,131 @@ > > +// Check if refcount_t type and API should be used > > +// instead of atomic_t type when dealing with refcounters > > +// > > +// Copyright (c) 2016-2017, Elena Reshetova, Intel Corporation > > +// > > +// Confidence: Moderate > > +// URL: http://coccinelle.lip6.fr/ > > +// Options: --include-headers --very-quiet > > + > > +virtual report > > + > > + at r1 exists@ > > +identifier a, x, y; > > +position p1, p2; > > +identifier fname =~ ".*free.*"; > > +identifier fname2 =~ ".*destroy.*"; > > +identifier fname3 =~ ".*del.*"; > > +identifier fname4 =~ ".*queue_work.*"; > > +identifier fname5 =~ ".*schedule_work.*"; > > +identifier fname6 =~ ".*call_rcu.*"; > > + > > +@@ > > + > > +( > > + atomic_dec_and_test at p1(&(a)->x) > > +| > > + atomic_dec_and_lock at p1(&(a)->x, ...) > > +| > > + atomic_long_dec_and_lock at p1(&(a)->x, ...) > > +| > > + atomic_long_dec_and_test at p1(&(a)->x) > > +| > > + atomic64_dec_and_test at p1(&(a)->x) > > +| > > + local_dec_and_test at p1(&(a)->x) > > +) > > +... > > +( > > + fname at p2(a, ...); > > +| > > + fname2 at p2(...); > > +| > > + fname3 at p2(...); > > +| > > + fname4 at p2(...); > > +| > > + fname5 at p2(...); > > +| > > + fname6 at p2(...); > > +) > > + > > + > > + at script:python depends on report@ > > +p1 << r1.p1; > > +p2 << r1.p2; > > +@@ > > +msg = "atomic_dec_and_test variation before object free at line %s." > > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > > + > > + at r4 exists@ > > +identifier a, x, y; > > +position p1, p2; > > +identifier fname =~ ".*free.*"; > > + > > +@@ > > + > > +( > > + atomic_dec_and_test at p1(&(a)->x) > > +| > > + atomic_dec_and_lock at p1(&(a)->x, ...) > > +| > > + atomic_long_dec_and_lock at p1(&(a)->x, ...) > > +| > > + atomic_long_dec_and_test at p1(&(a)->x) > > +| > > + atomic64_dec_and_test at p1(&(a)->x) > > +| > > + local_dec_and_test at p1(&(a)->x) > > +) > > +... > > +y=a > > +... > > +fname at p2(y, ...); > > + > > + > > + at script:python depends on report@ > > +p1 << r4.p1; > > +p2 << r4.p2; > > +@@ > > +msg = "atomic_dec_and_test variation before object free at line %s." > > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > > + > > + at r2 exists@ > > +identifier a, x; > > +position p1; > > +@@ > > + > > +( > > +atomic_add_unless(&(a)->x,-1,1)@p1 > > +| > > +atomic_long_add_unless(&(a)->x,-1,1)@p1 > > +| > > +atomic64_add_unless(&(a)->x,-1,1)@p1 > > +) > > + > > + at script:python depends on report@ > > +p1 << r2.p1; > > +@@ > > +msg = "atomic_add_unless" > > +coccilib.report.print_report(p1[0], msg) > > + > > + at r3 exists@ > > +identifier x; > > +position p1; > > +@@ > > + > > +( > > +x = atomic_add_return at p1(-1, ...); > > +| > > +x = atomic_long_add_return at p1(-1, ...); > > +| > > +x = atomic64_add_return at p1(-1, ...); > > +) > > + > > + at script:python depends on report@ > > +p1 << r3.p1; > > +@@ > > +msg = "x = atomic_add_return(-1, ...)" > > +coccilib.report.print_report(p1[0], msg) > > + > > + > > -- > > 2.7.4 > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script 2017-08-30 12:44 ` Reshetova, Elena @ 2017-08-30 13:06 ` Julia Lawall 2017-08-31 9:46 ` Reshetova, Elena 2017-08-30 13:43 ` [Cocci] [PATCH v4] " SF Markus Elfring 1 sibling, 1 reply; 9+ messages in thread From: Julia Lawall @ 2017-08-30 13:06 UTC (permalink / raw) To: cocci On Wed, 30 Aug 2017, Reshetova, Elena wrote: > > > > > On Wed, 30 Aug 2017, Elena Reshetova wrote: > > > > > atomic_as_refcounter.cocci script allows detecting > > > cases when refcount_t type and API should be used > > > instead of atomic_t. > > > > > > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> > > > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > > Thank you very much Julia! What is the correct path to merge this? > I will resend with your acked-by, but what is the tree that should merge it? Marek will take it. If you want to resend, please get rid of the metavariable y in the rule r1. It causes an unused variable warning. julia > > Best Regards, > Elena. > > > > > --- > > > scripts/coccinelle/api/atomic_as_refcounter.cocci | 131 > > ++++++++++++++++++++++ > > > 1 file changed, 131 insertions(+) > > > create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci > > > > > > diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci > > b/scripts/coccinelle/api/atomic_as_refcounter.cocci > > > new file mode 100644 > > > index 0000000..f83771b > > > --- /dev/null > > > +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci > > > @@ -0,0 +1,131 @@ > > > +// Check if refcount_t type and API should be used > > > +// instead of atomic_t type when dealing with refcounters > > > +// > > > +// Copyright (c) 2016-2017, Elena Reshetova, Intel Corporation > > > +// > > > +// Confidence: Moderate > > > +// URL: http://coccinelle.lip6.fr/ > > > +// Options: --include-headers --very-quiet > > > + > > > +virtual report > > > + > > > + at r1 exists@ > > > +identifier a, x, y; > > > +position p1, p2; > > > +identifier fname =~ ".*free.*"; > > > +identifier fname2 =~ ".*destroy.*"; > > > +identifier fname3 =~ ".*del.*"; > > > +identifier fname4 =~ ".*queue_work.*"; > > > +identifier fname5 =~ ".*schedule_work.*"; > > > +identifier fname6 =~ ".*call_rcu.*"; > > > + > > > +@@ > > > + > > > +( > > > + atomic_dec_and_test at p1(&(a)->x) > > > +| > > > + atomic_dec_and_lock at p1(&(a)->x, ...) > > > +| > > > + atomic_long_dec_and_lock at p1(&(a)->x, ...) > > > +| > > > + atomic_long_dec_and_test at p1(&(a)->x) > > > +| > > > + atomic64_dec_and_test at p1(&(a)->x) > > > +| > > > + local_dec_and_test at p1(&(a)->x) > > > +) > > > +... > > > +( > > > + fname at p2(a, ...); > > > +| > > > + fname2 at p2(...); > > > +| > > > + fname3 at p2(...); > > > +| > > > + fname4 at p2(...); > > > +| > > > + fname5 at p2(...); > > > +| > > > + fname6 at p2(...); > > > +) > > > + > > > + > > > + at script:python depends on report@ > > > +p1 << r1.p1; > > > +p2 << r1.p2; > > > +@@ > > > +msg = "atomic_dec_and_test variation before object free at line %s." > > > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > > > + > > > + at r4 exists@ > > > +identifier a, x, y; > > > +position p1, p2; > > > +identifier fname =~ ".*free.*"; > > > + > > > +@@ > > > + > > > +( > > > + atomic_dec_and_test at p1(&(a)->x) > > > +| > > > + atomic_dec_and_lock at p1(&(a)->x, ...) > > > +| > > > + atomic_long_dec_and_lock at p1(&(a)->x, ...) > > > +| > > > + atomic_long_dec_and_test at p1(&(a)->x) > > > +| > > > + atomic64_dec_and_test at p1(&(a)->x) > > > +| > > > + local_dec_and_test at p1(&(a)->x) > > > +) > > > +... > > > +y=a > > > +... > > > +fname at p2(y, ...); > > > + > > > + > > > + at script:python depends on report@ > > > +p1 << r4.p1; > > > +p2 << r4.p2; > > > +@@ > > > +msg = "atomic_dec_and_test variation before object free at line %s." > > > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > > > + > > > + at r2 exists@ > > > +identifier a, x; > > > +position p1; > > > +@@ > > > + > > > +( > > > +atomic_add_unless(&(a)->x,-1,1)@p1 > > > +| > > > +atomic_long_add_unless(&(a)->x,-1,1)@p1 > > > +| > > > +atomic64_add_unless(&(a)->x,-1,1)@p1 > > > +) > > > + > > > + at script:python depends on report@ > > > +p1 << r2.p1; > > > +@@ > > > +msg = "atomic_add_unless" > > > +coccilib.report.print_report(p1[0], msg) > > > + > > > + at r3 exists@ > > > +identifier x; > > > +position p1; > > > +@@ > > > + > > > +( > > > +x = atomic_add_return at p1(-1, ...); > > > +| > > > +x = atomic_long_add_return at p1(-1, ...); > > > +| > > > +x = atomic64_add_return at p1(-1, ...); > > > +) > > > + > > > + at script:python depends on report@ > > > +p1 << r3.p1; > > > +@@ > > > +msg = "x = atomic_add_return(-1, ...)" > > > +coccilib.report.print_report(p1[0], msg) > > > + > > > + > > > -- > > > 2.7.4 > > > > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script 2017-08-30 13:06 ` Julia Lawall @ 2017-08-31 9:46 ` Reshetova, Elena 0 siblings, 0 replies; 9+ messages in thread From: Reshetova, Elena @ 2017-08-31 9:46 UTC (permalink / raw) To: cocci > On Wed, 30 Aug 2017, Reshetova, Elena wrote: > > > > > > > > > On Wed, 30 Aug 2017, Elena Reshetova wrote: > > > > > > > atomic_as_refcounter.cocci script allows detecting > > > > cases when refcount_t type and API should be used > > > > instead of atomic_t. > > > > > > > > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> > > > > > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > > > > Thank you very much Julia! What is the correct path to merge this? > > I will resend with your acked-by, but what is the tree that should merge it? > > Marek will take it. If you want to resend, please get rid of the > metavariable y in the rule r1. It causes an unused variable warning. Sure, will do. Thank you! Best Regards, Elena. > > julia > > > > > Best Regards, > > Elena. > > > > > > > --- > > > > scripts/coccinelle/api/atomic_as_refcounter.cocci | 131 > > > ++++++++++++++++++++++ > > > > 1 file changed, 131 insertions(+) > > > > create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci > > > > > > > > diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci > > > b/scripts/coccinelle/api/atomic_as_refcounter.cocci > > > > new file mode 100644 > > > > index 0000000..f83771b > > > > --- /dev/null > > > > +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci > > > > @@ -0,0 +1,131 @@ > > > > +// Check if refcount_t type and API should be used > > > > +// instead of atomic_t type when dealing with refcounters > > > > +// > > > > +// Copyright (c) 2016-2017, Elena Reshetova, Intel Corporation > > > > +// > > > > +// Confidence: Moderate > > > > +// URL: http://coccinelle.lip6.fr/ > > > > +// Options: --include-headers --very-quiet > > > > + > > > > +virtual report > > > > + > > > > + at r1 exists@ > > > > +identifier a, x, y; > > > > +position p1, p2; > > > > +identifier fname =~ ".*free.*"; > > > > +identifier fname2 =~ ".*destroy.*"; > > > > +identifier fname3 =~ ".*del.*"; > > > > +identifier fname4 =~ ".*queue_work.*"; > > > > +identifier fname5 =~ ".*schedule_work.*"; > > > > +identifier fname6 =~ ".*call_rcu.*"; > > > > + > > > > +@@ > > > > + > > > > +( > > > > + atomic_dec_and_test at p1(&(a)->x) > > > > +| > > > > + atomic_dec_and_lock at p1(&(a)->x, ...) > > > > +| > > > > + atomic_long_dec_and_lock at p1(&(a)->x, ...) > > > > +| > > > > + atomic_long_dec_and_test at p1(&(a)->x) > > > > +| > > > > + atomic64_dec_and_test at p1(&(a)->x) > > > > +| > > > > + local_dec_and_test at p1(&(a)->x) > > > > +) > > > > +... > > > > +( > > > > + fname at p2(a, ...); > > > > +| > > > > + fname2 at p2(...); > > > > +| > > > > + fname3 at p2(...); > > > > +| > > > > + fname4 at p2(...); > > > > +| > > > > + fname5 at p2(...); > > > > +| > > > > + fname6 at p2(...); > > > > +) > > > > + > > > > + > > > > + at script:python depends on report@ > > > > +p1 << r1.p1; > > > > +p2 << r1.p2; > > > > +@@ > > > > +msg = "atomic_dec_and_test variation before object free at line %s." > > > > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > > > > + > > > > + at r4 exists@ > > > > +identifier a, x, y; > > > > +position p1, p2; > > > > +identifier fname =~ ".*free.*"; > > > > + > > > > +@@ > > > > + > > > > +( > > > > + atomic_dec_and_test at p1(&(a)->x) > > > > +| > > > > + atomic_dec_and_lock at p1(&(a)->x, ...) > > > > +| > > > > + atomic_long_dec_and_lock at p1(&(a)->x, ...) > > > > +| > > > > + atomic_long_dec_and_test at p1(&(a)->x) > > > > +| > > > > + atomic64_dec_and_test at p1(&(a)->x) > > > > +| > > > > + local_dec_and_test at p1(&(a)->x) > > > > +) > > > > +... > > > > +y=a > > > > +... > > > > +fname at p2(y, ...); > > > > + > > > > + > > > > + at script:python depends on report@ > > > > +p1 << r4.p1; > > > > +p2 << r4.p2; > > > > +@@ > > > > +msg = "atomic_dec_and_test variation before object free at line %s." > > > > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > > > > + > > > > + at r2 exists@ > > > > +identifier a, x; > > > > +position p1; > > > > +@@ > > > > + > > > > +( > > > > +atomic_add_unless(&(a)->x,-1,1)@p1 > > > > +| > > > > +atomic_long_add_unless(&(a)->x,-1,1)@p1 > > > > +| > > > > +atomic64_add_unless(&(a)->x,-1,1)@p1 > > > > +) > > > > + > > > > + at script:python depends on report@ > > > > +p1 << r2.p1; > > > > +@@ > > > > +msg = "atomic_add_unless" > > > > +coccilib.report.print_report(p1[0], msg) > > > > + > > > > + at r3 exists@ > > > > +identifier x; > > > > +position p1; > > > > +@@ > > > > + > > > > +( > > > > +x = atomic_add_return at p1(-1, ...); > > > > +| > > > > +x = atomic_long_add_return at p1(-1, ...); > > > > +| > > > > +x = atomic64_add_return at p1(-1, ...); > > > > +) > > > > + > > > > + at script:python depends on report@ > > > > +p1 << r3.p1; > > > > +@@ > > > > +msg = "x = atomic_add_return(-1, ...)" > > > > +coccilib.report.print_report(p1[0], msg) > > > > + > > > > + > > > > -- > > > > 2.7.4 > > > > > > > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cocci] [PATCH v4] Coccinelle: add atomic_as_refcounter script 2017-08-30 12:44 ` Reshetova, Elena 2017-08-30 13:06 ` Julia Lawall @ 2017-08-30 13:43 ` SF Markus Elfring 1 sibling, 0 replies; 9+ messages in thread From: SF Markus Elfring @ 2017-08-30 13:43 UTC (permalink / raw) To: cocci > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > Thank you very much Julia! I find that this acknowledgement could be presented a bit too early. > What is the correct path to merge this? It seems that you prefer to ignore some of my technical arguments (or concerns?). I hope that a safer source code search approach can still be achieved here. Regards, Markus ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Cocci] [PATCH v4] provide rule for finding refcounters 2017-08-30 6:15 [Cocci] [PATCH v4] provide rule for finding refcounters Elena Reshetova 2017-08-30 6:15 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova @ 2017-08-30 10:21 ` SF Markus Elfring 1 sibling, 0 replies; 9+ messages in thread From: SF Markus Elfring @ 2017-08-30 10:21 UTC (permalink / raw) To: cocci > changes in v4: > ? Do you find this cover letter still relevant for the clarification of remaining open issues in a single SmPL script? Regards, Markus ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-08-31 9:46 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-08-30 6:15 [Cocci] [PATCH v4] provide rule for finding refcounters Elena Reshetova 2017-08-30 6:15 ` [Cocci] [PATCH] Coccinelle: add atomic_as_refcounter script Elena Reshetova 2017-08-30 10:36 ` [Cocci] [PATCH v4] " SF Markus Elfring 2017-08-30 12:26 ` [Cocci] [PATCH] " Julia Lawall 2017-08-30 12:44 ` Reshetova, Elena 2017-08-30 13:06 ` Julia Lawall 2017-08-31 9:46 ` Reshetova, Elena 2017-08-30 13:43 ` [Cocci] [PATCH v4] " SF Markus Elfring 2017-08-30 10:21 ` [Cocci] [PATCH v4] provide rule for finding refcounters SF Markus Elfring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).