From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Michal Marek <michal.lkml@markovi.net>,
kernel-janitors@vger.kernel.org,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org,
Gilles Muller <Gilles.Muller@inria.fr>,
cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH 4/4] coccinelle: platform_get_irq: drop unneeded metavariable
Date: Tue, 19 Nov 2019 18:28:20 +0100 [thread overview]
Message-ID: <1574184500-29870-5-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1574184500-29870-1-git-send-email-Julia.Lawall@lip6.fr>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Having E as a metavariable adds the requirement to verify its type.
This seems like an unnecessary constraint, so drop it.
There is currently no impact on the set of results.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
scripts/coccinelle/api/platform_get_irq.cocci | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/scripts/coccinelle/api/platform_get_irq.cocci b/scripts/coccinelle/api/platform_get_irq.cocci
index e5d04fb..17e5895 100644
--- a/scripts/coccinelle/api/platform_get_irq.cocci
+++ b/scripts/coccinelle/api/platform_get_irq.cocci
@@ -11,7 +11,6 @@ virtual report
@depends on context@
expression ret;
-struct platform_device *E;
@@
ret =
@@ -19,7 +18,7 @@ ret =
platform_get_irq
|
platform_get_irq_byname
-)(E, ...);
+)(...);
if ( \( ret < 0 \| ret <= 0 \) )
{
@@ -30,7 +29,6 @@ if ( \( ret < 0 \| ret <= 0 \) )
@depends on patch@
expression ret;
-struct platform_device *E;
statement S;
@@
@@ -39,7 +37,7 @@ ret =
platform_get_irq
|
platform_get_irq_byname
-)(E, ...);
+)(...);
if ( \( ret < 0 \| ret <= 0 \) )
-{
@@ -49,7 +47,6 @@ S
@depends on patch@
expression ret;
-struct platform_device *E;
@@
ret =
@@ -57,7 +54,7 @@ ret =
platform_get_irq
|
platform_get_irq_byname
-)(E, ...);
+)(...);
if ( \( ret < 0 \| ret <= 0 \) )
{
@@ -76,7 +73,6 @@ if ( \( ret < 0 \| ret <= 0 \) )
@r depends on org || report@
position p1;
expression ret;
-struct platform_device *E;
@@
ret =
@@ -84,7 +80,7 @@ ret =
platform_get_irq
|
platform_get_irq_byname
-)(E, ...);
+)(...);
if ( \( ret < 0 \| ret <= 0 \) )
{
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
prev parent reply other threads:[~2019-11-19 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 17:28 [Cocci] [PATCH 0/4] improve platform_get_irq.cocci Julia Lawall
2019-11-19 17:28 ` [Cocci] [PATCH 1/4] coccinelle: platform_get_irq: simplify context case Julia Lawall
2019-11-19 17:28 ` [Cocci] [PATCH 2/4] coccinelle: platform_get_irq: handle 2-statement branches Julia Lawall
2019-11-19 21:33 ` Markus Elfring
2019-11-19 21:36 ` Julia Lawall
2019-11-20 9:38 ` [Cocci] [2/4] " Markus Elfring
2019-11-19 21:33 ` [Cocci] [PATCH 2/4] " Markus Elfring
2019-11-19 17:28 ` [Cocci] [PATCH 3/4] coccinelle: platform_get_irq: allow multiple dev_errs Julia Lawall
2019-11-19 17:28 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574184500-29870-5-git-send-email-Julia.Lawall@lip6.fr \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).