cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, cocci@systeme.lip6.fr
Cc: Michal Marek <michal.lkml@markovi.net>,
	kernel-janitors@vger.kernel.org,
	Nicolas Palix <nicolas.palix@imag.fr>,
	linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [2/4] coccinelle: platform_get_irq: handle 2-statement branches
Date: Wed, 20 Nov 2019 10:38:33 +0100	[thread overview]
Message-ID: <5de8c4b9-2537-283d-4ef0-49fb22c18fe6@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1911192235010.2592@hadrien>

> Sorry, I seem to have done something quite wrong on this patch.

Interesting …


> I will fix it.

Thanks.

Development will be continued:
https://lkml.org/lkml/2019/11/19/1681
https://lore.kernel.org/patchwork/patch/1156089/
https://lore.kernel.org/cocci/1574197705-31132-3-git-send-email-Julia.Lawall@lip6.fr/


>> How do you think about to use the following SmPL code variant?
>
> And the benefit is what?
…
>> + ret =
>> +(platform_get_irq
>> +|platform_get_irq_byname
>> +)(E, ...);
>> +
>> + if ( \( ret < 0 \| ret <= 0 \) )
>> +-{
>> +-dev_err(...);
>> + S
>> +-}

* I suggest to use a different coding style for the specification of
  two function names in the SmPL disjunction.

* Would you like to avoid the mixing of code items in the first text column?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2019-11-20  9:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 17:28 [Cocci] [PATCH 0/4] improve platform_get_irq.cocci Julia Lawall
2019-11-19 17:28 ` [Cocci] [PATCH 1/4] coccinelle: platform_get_irq: simplify context case Julia Lawall
2019-11-19 17:28 ` [Cocci] [PATCH 2/4] coccinelle: platform_get_irq: handle 2-statement branches Julia Lawall
2019-11-19 21:33   ` Markus Elfring
2019-11-19 21:36     ` Julia Lawall
2019-11-20  9:38       ` Markus Elfring [this message]
2019-11-19 21:33   ` Markus Elfring
2019-11-19 17:28 ` [Cocci] [PATCH 3/4] coccinelle: platform_get_irq: allow multiple dev_errs Julia Lawall
2019-11-19 17:28 ` [Cocci] [PATCH 4/4] coccinelle: platform_get_irq: drop unneeded metavariable Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5de8c4b9-2537-283d-4ef0-49fb22c18fe6@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).