From: joel@joelfernandes.org (Joel Fernandes)
To: cocci@systeme.lip6.fr
Subject: [Cocci] Searching for parameter usages of pte_alloc()
Date: Thu, 11 Oct 2018 16:54:08 -0700 [thread overview]
Message-ID: <20181011235408.GA146384@joelaf.mtv.corp.google.com> (raw)
In-Reply-To: <cd2eb29e-775f-9c48-b839-b2ebdc3e3c56@users.sourceforge.net>
On Thu, Oct 11, 2018 at 09:55:46PM +0200, SF Markus Elfring wrote:
> > The thing is I know the exact parameter to match,
>
> This is nice.
>
>
> > and they are fixed in number so I don't really care about that.
>
> I got the impression that you care only for the last function argument
> so far, don't you?
>
>
> > But I am struggling a little with other things and would like help from you and Julia. There are 3 things (and
> > sorry if some of this is like, wishful stuff, but I thought its better to ask
> > than not and may be let you know what features would be useful):
> >
> > 1. How do I match function names partially?
>
> You can use regular expressions for constraints of metavariables
> in the semantic patch language.
> http://coccinelle.lip6.fr/docs/main_grammar016.html#sec28
>
Ok, it is working.
> > 2. How do I write a rule that renames function names using the "(" and "|" syntax?
>
> You can specify replacement variants by SmPL disjunctions.
>
>
> > (
> > - pte_alloc(T1 E1, T2 E2)
> > + pte_alloc(T1 E1)
> > |
> > - pte_alloc_kernel(T1 E1, T2 E2)
> > + pte_alloc_kernel(T1 E1)
> > )
> > { ... }
>
> If you would like to delete a parameter from the function signature,
> I guess that the following SmPL code should work.
The thing is now its getting really hard to abstract, sometimes I need remove
3rd arg, sometimes 2nd. So I'm doing some manual work too. I'll CC you on my
patch to give you an idea.
> > 3. How do I match macro definitions of pte_alloc defined using #define,
> > and apply rules on those?
>
> There are open issues remaining in the support for preprocessor directives.
> https://github.com/coccinelle/coccinelle/issues/139
>
> How do you think about to pick any related software development
> challenges up?
At the moment I can commit to anything, I am trying to focus on documenting
RCU when I get spare time. Sorry. But I may in the future as I use Coccinelle
more, right now I am just a beginner.
thanks for your help,
- Joel
prev parent reply other threads:[~2018-10-11 23:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 19:38 [Cocci] First coccinelle script, need some help Joel Fernandes
2018-10-10 20:23 ` Julia Lawall
2018-10-10 20:45 ` Joel Fernandes
2018-10-10 20:51 ` Julia Lawall
2018-10-10 21:11 ` Joel Fernandes
2018-10-10 21:12 ` Julia Lawall
[not found] ` <93da55ff-c807-6587-7ef3-3d2af820117d@users.sourceforge.net>
2018-10-11 15:43 ` [Cocci] Searching for parameter usages of pte_alloc() Joel Fernandes
2018-10-11 15:51 ` Julia Lawall
2018-10-11 16:28 ` Joel Fernandes
2018-10-11 16:40 ` Julia Lawall
2018-10-11 16:49 ` Joel Fernandes
2018-10-11 16:57 ` Julia Lawall
2018-10-11 17:06 ` Joel Fernandes
2018-10-11 18:06 ` Joel Fernandes
2018-10-11 18:07 ` Joel Fernandes
[not found] ` <cd2eb29e-775f-9c48-b839-b2ebdc3e3c56@users.sourceforge.net>
2018-10-11 23:54 ` Joel Fernandes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011235408.GA146384@joelaf.mtv.corp.google.com \
--to=joel@joelfernandes.org \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).