From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Yi Wang <wang.yi59@zte.com.cn>,
Michal Marek <michal.lkml@markovi.net>,
kernel-janitors@vger.kernel.org,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr,
Markus Elfring <Markus.Elfring@web.de>,
Wen Yang <wen.yang99@zte.com.cn>
Subject: Re: [Cocci] [PATCH] coccinelle: put_device: reduce false positives
Date: Tue, 26 Mar 2019 13:11:04 +0300 [thread overview]
Message-ID: <20190326101103.GH32613@kadam> (raw)
In-Reply-To: <alpine.DEB.2.20.1903261037320.5021@hadrien>
On Tue, Mar 26, 2019 at 10:38:43AM +0100, Julia Lawall wrote:
>
>
> On Tue, 26 Mar 2019, Dan Carpenter wrote:
>
> > On Sat, Mar 23, 2019 at 09:06:54PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Sat, 23 Mar 2019, Markus Elfring wrote:
> > >
> > > > > Don't complain about a return when this function returns "&pdev->dev".
> > > >
> > > > Would this information qualify to add the tag “Fixes” to the commit message?
> > >
> > > Fixes tags relate to stable kernels, so that one can see which stable
> > > kernels a particular patch should be propagated to. There is no need to
> > > propagate patches on semantic patches to stable kernels. People who run
> > > stable kernels are interested in their behavior, not the bug finding
> > > rules that they contain.
> >
> > The Fixes tag is not just about stable... For example, we use them for
> > statistics to see how quickly bugs get fixed etc.
>
> OK. But still do we need fixes tags for bug finding rules? Perhaps if
> the previous version was really broken, and it would be really undesirable
> to use it.
It's not worth resending a patch for that, but I probably would use the
fixes tag. It depends on your definition of "bug" really... I tell
people not to use Fixes for spelling mistakes and unused variables. But
I do use the Fixes tag for things like "an off by one in a sanity check
which doesn't affect run time because the index is always correct".
regards,
dan carpenter
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-03-26 10:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 6:14 [Cocci] [PATCH] coccinelle: put_device: reduce false positives Wen Yang
2019-03-23 13:41 ` Julia Lawall
2019-03-23 19:44 ` Markus Elfring
2019-03-23 20:06 ` Julia Lawall
2019-03-26 8:45 ` Dan Carpenter
2019-03-26 9:38 ` Julia Lawall
2019-03-26 10:11 ` Dan Carpenter [this message]
2019-03-26 10:15 ` Julia Lawall
2019-03-28 13:08 ` Masahiro Yamada
2019-03-28 14:19 ` Julia Lawall
2019-04-01 6:44 ` [Cocci] Coccinelle: " Markus Elfring
2019-04-01 20:04 ` Julia Lawall
2019-05-13 8:55 ` [Cocci] [PATCH 0/5] Coccinelle: put_device: Adjustments for a SmPL script Markus Elfring
2019-05-13 8:59 ` [Cocci] [PATCH 1/5] Coccinelle: put_device: Adjust a message construction Markus Elfring
2019-05-13 9:35 ` Julia Lawall
2019-05-13 11:33 ` [Cocci] [1/5] " Markus Elfring
2019-05-13 11:36 ` Julia Lawall
2019-05-13 12:48 ` Markus Elfring
2019-07-06 13:13 ` [Cocci] [PATCH 1/5] " Masahiro Yamada
2019-05-13 9:01 ` [Cocci] [PATCH 2/5] Coccinelle: put_device: Add a cast to an expression for an assignment Markus Elfring
2019-05-13 9:33 ` Julia Lawall
2019-07-06 13:13 ` Masahiro Yamada
2019-05-13 9:05 ` [Cocci] [PATCH 3/5] Coccinelle: put_device: Merge four SmPL when constraints into one Markus Elfring
2019-05-13 9:32 ` Julia Lawall
2019-05-13 11:48 ` [Cocci] [3/5] " Markus Elfring
2019-05-13 11:48 ` Markus Elfring
2019-05-13 11:51 ` Julia Lawall
2019-05-13 12:52 ` Markus Elfring
2019-05-13 9:07 ` [Cocci] [PATCH 4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses Markus Elfring
2019-05-13 9:31 ` Julia Lawall
2019-05-13 12:22 ` [Cocci] [4/5] " Markus Elfring
2019-05-14 5:55 ` Markus Elfring
2019-05-14 6:52 ` Julia Lawall
2019-05-14 7:49 ` Markus Elfring
2019-05-14 9:18 ` [Cocci] [4/5] Coccinelle: put_device: Extend when constraints for twoSmPL ellipses wen.yang99
2019-05-14 9:51 ` Markus Elfring
2019-05-14 7:49 ` [Cocci] [4/5] Coccinelle: put_device: Extend when constraints for two SmPL ellipses Markus Elfring
2019-05-13 9:07 ` [Cocci] [PATCH 4/5] " Markus Elfring
2019-05-13 9:10 ` [Cocci] [PATCH 5/5] Coccinelle: put_device: Merge two SmPL when constraints into one Markus Elfring
2019-05-13 9:30 ` Julia Lawall
2019-05-13 12:35 ` [Cocci] [5/5] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326101103.GH32613@kadam \
--to=dan.carpenter@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).