cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
* [cocci] [PATCH] Silence Emacs warning on loading cocci.el
@ 2023-04-02  7:40 Matti Niemenmaa
  2023-04-02  8:03 ` Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Matti Niemenmaa @ 2023-04-02  7:40 UTC (permalink / raw)
  To: cocci; +Cc: Matti Niemenmaa

Unescaped quote character literals (?") have produced an "unescaped
character literals" warning on load ever since Emacs 26 (Emacs commit
c2bbdc3316487 and bug#20852). As far as I can tell the escaped syntax
has been supported since at least the early 90s, so there are no
backwards compat issues with this change.

Signed-off-by: Matti Niemenmaa <git-matti@maon.fi>
---
 editors/emacs/cocci.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git editors/emacs/cocci.el editors/emacs/cocci.el
index 072e4a9d..12e384f3 100644
--- editors/emacs/cocci.el
+++ editors/emacs/cocci.el
@@ -394,7 +394,7 @@ Turning on cocci-mode runs the hook `cocci-mode-hook'."
 ; put cursor before a parse error coccinelle message and it will
 ; open the corresponding file and go to corresponding line.
 (fset 'cocci-goto-next-error
-   [?\C-s ?F ?i ?l ?e right right ?\C-  ?\C-s ?" left ?\M-w ?\C-x ?\C-f S-insert return ?\C-\M-l C-right right C-S-right C-insert ?\C-\M-l ?\M-g S-insert return])
+   [?\C-s ?F ?i ?l ?e right right ?\C-  ?\C-s ?\" left ?\M-w ?\C-x ?\C-f S-insert return ?\C-\M-l C-right right C-S-right C-insert ?\C-\M-l ?\M-g S-insert return])
 ;"
 
 ;; Provide
-- 
2.40.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [cocci] [PATCH] Silence Emacs warning on loading cocci.el
  2023-04-02  7:40 [cocci] [PATCH] Silence Emacs warning on loading cocci.el Matti Niemenmaa
@ 2023-04-02  8:03 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2023-04-02  8:03 UTC (permalink / raw)
  To: Matti Niemenmaa; +Cc: cocci



On Sun, 2 Apr 2023, Matti Niemenmaa wrote:

> Unescaped quote character literals (?") have produced an "unescaped
> character literals" warning on load ever since Emacs 26 (Emacs commit
> c2bbdc3316487 and bug#20852). As far as I can tell the escaped syntax
> has been supported since at least the early 90s, so there are no
> backwards compat issues with this change.

Thanks!  Applied.

julia

>
> Signed-off-by: Matti Niemenmaa <git-matti@maon.fi>
> ---
>  editors/emacs/cocci.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git editors/emacs/cocci.el editors/emacs/cocci.el
> index 072e4a9d..12e384f3 100644
> --- editors/emacs/cocci.el
> +++ editors/emacs/cocci.el
> @@ -394,7 +394,7 @@ Turning on cocci-mode runs the hook `cocci-mode-hook'."
>  ; put cursor before a parse error coccinelle message and it will
>  ; open the corresponding file and go to corresponding line.
>  (fset 'cocci-goto-next-error
> -   [?\C-s ?F ?i ?l ?e right right ?\C-  ?\C-s ?" left ?\M-w ?\C-x ?\C-f S-insert return ?\C-\M-l C-right right C-S-right C-insert ?\C-\M-l ?\M-g S-insert return])
> +   [?\C-s ?F ?i ?l ?e right right ?\C-  ?\C-s ?\" left ?\M-w ?\C-x ?\C-f S-insert return ?\C-\M-l C-right right C-S-right C-insert ?\C-\M-l ?\M-g S-insert return])
>  ;"
>
>  ;; Provide
> --
> 2.40.0
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-02  8:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-02  7:40 [cocci] [PATCH] Silence Emacs warning on loading cocci.el Matti Niemenmaa
2023-04-02  8:03 ` Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).