From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: "Jürgen Groß" <jgross@suse.com>, Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] macro parameters and expressions?
Date: Tue, 15 Oct 2019 10:34:40 +0200 [thread overview]
Message-ID: <41f111b4-657d-3897-c2c0-c43c9e1d2395@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1910151004110.3774@hadrien>
>> BAD:!!!!! #define MACRO(name) snprintf(pg, PAGE_SIZE, %u\n", ptr->name)
>
> If a " is missing then the code can't be parsed and Coccinelle won't do anything.
I would appreciate if the error reporting will become nicer.
> But I don't know if this was a bug in the original code
You should probably know also this detail from the initial clarification request.
https://systeme.lip6.fr/pipermail/cocci/2019-October/006413.html
> or something you have modified;
I copied a bit of questionable source code also for my test approaches.
> you sent another message that did not have this problem.
I needed also further moments to notice related glitches.
> What software situation?
There are various open issues to consider around safe transformations
also around preprocessor code (replacement lists), aren't there?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-10-15 8:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 7:42 [Cocci] macro parameters and expressions? Jürgen Groß
2019-10-11 20:00 ` Julia Lawall
2019-10-13 13:37 ` Markus Elfring
[not found] ` <alpine.DEB.2.21.1910131806400.2565@hadrien>
2019-10-13 16:33 ` [Cocci] Adjusting macros with SmPL? Markus Elfring
2019-10-13 16:37 ` Julia Lawall
2019-10-13 16:50 ` Markus Elfring
2019-10-14 9:08 ` Markus Elfring
2019-10-14 10:24 ` Julia Lawall
2019-10-14 11:00 ` Markus Elfring
2019-10-15 8:20 ` Markus Elfring
2019-10-16 14:16 ` [Cocci] Adjustments with SmPL after macros? Markus Elfring
2019-10-16 15:23 ` Julia Lawall
2019-10-16 16:48 ` Markus Elfring
[not found] ` <alpine.DEB.2.21.1910161850250.3539@hadrien>
2019-10-16 16:55 ` Markus Elfring
2019-10-17 9:33 ` Markus Elfring
[not found] ` <fb924870-4bc2-1ca0-4fa4-0ddbf7ebb9d2@suse.com>
2019-10-14 11:14 ` [Cocci] macro parameters and expressions? Julia Lawall
2019-10-14 11:50 ` Markus Elfring
2019-10-14 13:33 ` Jürgen Groß
2019-10-14 14:03 ` Julia Lawall
2019-10-13 13:28 ` Markus Elfring
2019-10-13 13:36 ` Julia Lawall
2019-10-13 14:22 ` [Cocci] Checking the influence of “virtual” SmPL variables Markus Elfring
2019-10-13 16:09 ` Julia Lawall
2019-10-13 16:39 ` Markus Elfring
2019-10-14 15:33 ` [Cocci] macro parameters and expressions? Markus Elfring
[not found] ` <alpine.DEB.2.21.1910141740580.2330@hadrien>
2019-10-14 16:05 ` Markus Elfring
2019-10-15 6:44 ` Markus Elfring
2019-10-15 6:54 ` Markus Elfring
2019-10-15 7:40 ` Markus Elfring
2019-10-15 8:05 ` Julia Lawall
2019-10-15 8:34 ` Markus Elfring [this message]
2019-10-15 9:07 ` Markus Elfring
2019-10-15 9:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41f111b4-657d-3897-c2c0-c43c9e1d2395@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=jgross@suse.com \
--cc=julia.lawall@lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).