* [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy
@ 2019-10-26 7:50 zhongshiqi
2019-10-26 14:12 ` Markus Elfring
0 siblings, 1 reply; 9+ messages in thread
From: zhongshiqi @ 2019-10-26 7:50 UTC (permalink / raw)
To: Julia.Lawall
Cc: wang.yi59, michal.lkml, nicolas.palix, linux-kernel, xue.zhihong,
cheng.shengyu, zhongshiqi, cocci
Allow defining the environment variable “COCCI” as a directory
to search SmPL scripts. Start a corresponding file determination
if it contains an acceptable path.
Signed-off-by: zhongshiqi <zhong.shiqi@zte.com.cn>
---
Changes in v4:
1:rewrite change description in another wording
Changes in v3:
1:rewrite change description
2:fix patch subject
3:modify commit log
Changes in v2:
1.fix patch subject according to the reply by Markus
<Markus.Elfring@web.de>
2.change description in “imperative mood”
scripts/coccicheck | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index e04d328..a1c4197 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -257,6 +257,10 @@ if [ "$COCCI" = "" ] ; then
for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
coccinelle $f
done
+elif [ -d "$COCCI" ] ; then
+ for f in `find $COCCI/ -name '*.cocci' -type f | sort`; do
+ coccinelle $f
+ done
else
coccinelle $COCCI
fi
--
2.9.5
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy
2019-10-26 7:50 [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy zhongshiqi
@ 2019-10-26 14:12 ` Markus Elfring
2019-10-26 14:19 ` Markus Elfring
2019-10-30 2:43 ` [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
0 siblings, 2 replies; 9+ messages in thread
From: Markus Elfring @ 2019-10-26 14:12 UTC (permalink / raw)
To: Zhong Shiqi, cocci
Cc: Yi Wang, Michal Marek, Nicolas Palix, kernel-janitors,
linux-kernel, Xue Zhihong, Cheng Shengyu
> Allow defining the environment variable “COCCI” as a directory
> to search SmPL scripts. Start a corresponding file determination
> if it contains an acceptable path.
Would the paragraph formatting be nicer as an enumeration
as I suggested it previously?
Would you like to update the provided software documentation together with
the small extension of this bash script?
Update candidates:
*
* https://bottest.wiki.kernel.org/coccicheck#controlling_which_files_are_processed_by_coccinelle
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy
2019-10-26 14:12 ` Markus Elfring
@ 2019-10-26 14:19 ` Markus Elfring
2019-10-30 2:59 ` [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
2019-10-30 2:43 ` [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
1 sibling, 1 reply; 9+ messages in thread
From: Markus Elfring @ 2019-10-26 14:19 UTC (permalink / raw)
To: Zhong Shiqi, cocci
Cc: Yi Wang, Michal Marek, Nicolas Palix, kernel-janitors,
linux-kernel, Xue Zhihong, Cheng Shengyu
> Would you like to update the provided software documentation together with
> the small extension of this bash script?
>
> Update candidates:
Please reconsider also the section “Using Coccinelle with a single semantic patch”:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=f877bee5ea0b56c39cd0a243e113a577b5a4ef92#n151
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts withinselected directory hierarchy
2019-10-26 14:12 ` Markus Elfring
2019-10-26 14:19 ` Markus Elfring
@ 2019-10-30 2:43 ` zhong.shiqi
2019-10-30 8:13 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected " Markus Elfring
1 sibling, 1 reply; 9+ messages in thread
From: zhong.shiqi @ 2019-10-30 2:43 UTC (permalink / raw)
To: Markus.Elfring
Cc: wang.yi59, michal.lkml, nicolas.palix, kernel-janitors,
linux-kernel, xue.zhihong, cheng.shengyu, cocci
[-- Attachment #1.1: Type: text/plain, Size: 662 bytes --]
> > Allow defining the environment variable “COCCI” as a directory
> > to search SmPL scripts. Start a corresponding file determination
> > if it contains an acceptable path.
>
> Would the paragraph formatting be nicer as an enumeration
> as I suggested it previously?
Sorry for the late reply!
I would say yes.
> Would you like to update the provided software documentation together with
> the small extension of this bash script?
I'd like to but i don't have rights to update.
Thansk,
zhong.shiqi
> Update candidates:
> *
>
> * https://bottest.wiki.kernel.org/coccicheck#controlling_which_files_are_processed_by_coccinelle
>
> Regards,
> Markus
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts withinselected directory hierarchy
2019-10-26 14:19 ` Markus Elfring
@ 2019-10-30 2:59 ` zhong.shiqi
2019-10-30 8:40 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected " Markus Elfring
0 siblings, 1 reply; 9+ messages in thread
From: zhong.shiqi @ 2019-10-30 2:59 UTC (permalink / raw)
To: Markus.Elfring
Cc: wang.yi59, michal.lkml, nicolas.palix, kernel-janitors,
linux-kernel, xue.zhihong, cheng.shengyu, cocci
[-- Attachment #1.1: Type: text/plain, Size: 793 bytes --]
> > Would you like to update the provided software documentation together with
> > the small extension of this bash script?
> >
> > Update candidates:
>
> Please reconsider also the section “Using Coccinelle with a single semantic patch”:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=f877bee5ea0b56c39cd0a243e113a577b5a4ef92#n151
>
> Regards,
> Markus
Could we add new lines?
How about the following?
The optional make variable COCCI can be used to search SmPL scripts in a
directory. In that case, the variable must be initialized with the name of
directory contains SmPL scripts.
For instance::
make coccicheck COCCI=<my_SPDIR> MODE=patch
or::
make coccicheck COCCI=<my_SPDIR> MODE=report
Thanks,
Zhong.shiqi
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy
2019-10-30 2:43 ` [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
@ 2019-10-30 8:13 ` Markus Elfring
0 siblings, 0 replies; 9+ messages in thread
From: Markus Elfring @ 2019-10-30 8:13 UTC (permalink / raw)
To: Zhong Shiqi, cocci, kernel-janitors
Cc: Yi Wang, Michal Marek, Nicolas Palix, linux-kernel, Xue Zhihong,
Cheng Shengyu
>> Would you like to update the provided software documentation together with
>> the small extension of this bash script?
>
> I'd like to but i don't have rights to update.
I suggest to take another look at change possibilities for affected documents.
>> Update candidates:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=23fdb198ae81f47a574296dab5167c5e136a02ba#n189
This file can be directly edited in a corresponding development branch
for your contribution, can't it?
>> * https://bottest.wiki.kernel.org/coccicheck#controlling_which_files_are_processed_by_coccinelle
Are going to try any of the supported login options out for this wiki?
Would you like to choose any other data synchronisation method?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy
2019-10-30 2:59 ` [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
@ 2019-10-30 8:40 ` Markus Elfring
2019-11-01 2:49 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selecteddirectory hierarchy zhong.shiqi
0 siblings, 1 reply; 9+ messages in thread
From: Markus Elfring @ 2019-10-30 8:40 UTC (permalink / raw)
To: Zhong Shiqi, cocci, kernel-janitors
Cc: Yi Wang, Michal Marek, Nicolas Palix, linux-kernel, Xue Zhihong,
Cheng Shengyu
>> Please reconsider also the section “Using Coccinelle with a single semantic patch”:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=f877bee5ea0b56c39cd0a243e113a577b5a4ef92#n151
>
> Could we add new lines?
Yes, of course.
> How about the following?
I suggest to improve the case distinction for the make (and environment)
variable “COCCI” also by adjusting the document outline.
* Empty string
* Directory selection
* File name specification
See also:
https://docutils.readthedocs.io/en/sphinx-docs/user/rst/quickstart.html#sections
> The optional make variable COCCI can be used to search SmPL scripts in a
> directory. In that case, the variable must be initialized with the name of
… it should be set to …
> directory contains SmPL scripts.
a directory which contains scripts for the semantic patch language.
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Cocci] [v4] coccicheck: Support search for SmPL scripts within selecteddirectory hierarchy
2019-10-30 8:40 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected " Markus Elfring
@ 2019-11-01 2:49 ` zhong.shiqi
2019-11-01 8:20 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy Markus Elfring
0 siblings, 1 reply; 9+ messages in thread
From: zhong.shiqi @ 2019-11-01 2:49 UTC (permalink / raw)
To: Markus.Elfring
Cc: wang.yi59, michal.lkml, nicolas.palix, kernel-janitors,
linux-kernel, xue.zhihong, cheng.shengyu, cocci
[-- Attachment #1.1: Type: text/plain, Size: 409 bytes --]
> I suggest to improve the case distinction for the make (and environment)
> variable “COCCI” also by adjusting the document outline.
> * Empty string
> * Directory selection
> * File name specification
>
> See also:
> https://docutils.readthedocs.io/en/sphinx-docs/user/rst/quickstart.html#sections
* Defalut value
* Directory selection
* Single file selection
Would it be better?
thanks,
Zhong.shiqi
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy
2019-11-01 2:49 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selecteddirectory hierarchy zhong.shiqi
@ 2019-11-01 8:20 ` Markus Elfring
0 siblings, 0 replies; 9+ messages in thread
From: Markus Elfring @ 2019-11-01 8:20 UTC (permalink / raw)
To: Zhong Shiqi, cocci
Cc: Yi Wang, Michal Marek, Nicolas Palix, kernel-janitors,
linux-kernel, Xue Zhihong, Cheng Shengyu
> * Defalut value
* Default value
> * Directory selection
> * Single file selection
>
> Would it be better?
Partly, yes.
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-11-01 8:21 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-26 7:50 [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy zhongshiqi
2019-10-26 14:12 ` Markus Elfring
2019-10-26 14:19 ` Markus Elfring
2019-10-30 2:59 ` [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
2019-10-30 8:40 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected " Markus Elfring
2019-11-01 2:49 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selecteddirectory hierarchy zhong.shiqi
2019-11-01 8:20 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected directory hierarchy Markus Elfring
2019-10-30 2:43 ` [Cocci] [PATCH v4] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
2019-10-30 8:13 ` [Cocci] [v4] coccicheck: Support search for SmPL scripts within selected " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).