Coccinelle archive on lore.kernel.org
 help / color / Atom feed
* [Cocci] Checking parsing difficulties around SmPL when constraints
@ 2019-09-11  7:42 Markus Elfring
  2019-09-11  8:19 ` Julia Lawall
  0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2019-09-11  7:42 UTC (permalink / raw)
  To: Coccinelle

Hello,

A specific test case is available for the semantic patch language.
https://github.com/coccinelle/coccinelle/blob/560c3d02e2085e83e9bcd40842eec7e774140131/tests/nest3.cocci

Can the following code variant work also under other circumstances?

@extra@
expression x;
position p;
@@
(sizeof(*(x@p))
|__alignof__(*(x@p))
)

@display@
expression action, x, y, z;
position p != extra.p;
statement es;
@@
*if (!x)
 {
    (<+... when != (x) = y
(
*   *(x@p)
|   action(z,
*          x@p
           , ...)
)
    ...+>);
 }
 else
    es


elfring@Sonne:~/Projekte/Coccinelle/janitor> spatch --parse-cocci show_null_pointer_usage13.cocci
…
minus: parse error:
  File "show_null_pointer_usage13.cocci", line 16, column 11, charpos = 178
  around = 'when',
  whole content =     (<+... when != (x) = y


Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Cocci] Checking parsing difficulties around SmPL when constraints
  2019-09-11  7:42 [Cocci] Checking parsing difficulties around SmPL when constraints Markus Elfring
@ 2019-09-11  8:19 ` Julia Lawall
  2019-09-11  9:09   ` Markus Elfring
  0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2019-09-11  8:19 UTC (permalink / raw)
  To: Markus Elfring; +Cc: Coccinelle

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]



On Wed, 11 Sep 2019, Markus Elfring wrote:

> Hello,
>
> A specific test case is available for the semantic patch language.
> https://github.com/coccinelle/coccinelle/blob/560c3d02e2085e83e9bcd40842eec7e774140131/tests/nest3.cocci
>
> Can the following code variant work also under other circumstances?

No, I don't think so.  I don't think that when is supported on
expressions.

julia

>
> @extra@
> expression x;
> position p;
> @@
> (sizeof(*(x@p))
> |__alignof__(*(x@p))
> )
>
> @display@
> expression action, x, y, z;
> position p != extra.p;
> statement es;
> @@
> *if (!x)
>  {
>     (<+... when != (x) = y
> (
> *   *(x@p)
> |   action(z,
> *          x@p
>            , ...)
> )
>     ...+>);
>  }
>  else
>     es
>
>
> elfring@Sonne:~/Projekte/Coccinelle/janitor> spatch --parse-cocci show_null_pointer_usage13.cocci
> …
> minus: parse error:
>   File "show_null_pointer_usage13.cocci", line 16, column 11, charpos = 178
>   around = 'when',
>   whole content =     (<+... when != (x) = y
>
>
> Regards,
> Markus
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Cocci] Checking parsing difficulties around SmPL when constraints
  2019-09-11  8:19 ` Julia Lawall
@ 2019-09-11  9:09   ` Markus Elfring
  0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2019-09-11  9:09 UTC (permalink / raw)
  To: Julia Lawall; +Cc: Coccinelle

>> A specific test case is available for the semantic patch language.
>> https://github.com/coccinelle/coccinelle/blob/560c3d02e2085e83e9bcd40842eec7e774140131/tests/nest3.cocci
>>
>> Can the following code variant work also under other circumstances?
>
> No, I don't think so.  I don't think that when is supported on expressions.

I find this feedback surprising.

I have checked that a SmPL specification like “<+... when != i … ...+>”
can work with the other test case.
May I expect that the handling of assignment exclusions should also work
(in the future) here?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11  7:42 [Cocci] Checking parsing difficulties around SmPL when constraints Markus Elfring
2019-09-11  8:19 ` Julia Lawall
2019-09-11  9:09   ` Markus Elfring

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr cocci@archiver.kernel.org
	public-inbox-index cocci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox