From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: cocci@systeme.lip6.fr
Subject: [Cocci] how to replace obsolete #ifdef's
Date: Wed, 5 Jun 2019 16:25:43 +0000 [thread overview]
Message-ID: <5c138195-ac1a-4ad6-c6e6-720acd4ea34f@metux.net> (raw)
Hi folks,
is there a way to replace obsolete #ifdef's via spatch ?
Here's my scenario:
In the linux kernel we have many places where drivers statically assign
pointers to match tables (eg. for oftree or acpi) into a global driver
struct - sometimes this is enclosed into some #ifdef CONFIG_..., when
things like oftree or acpi are optional.
Example patch for illustrating what I'd like to do:
--- a/sound/soc/codecs/pcm3060-i2c.c
+++ b/sound/soc/codecs/pcm3060-i2c.c
@@ -45,9 +45,7 @@ static int pcm3060_i2c_probe(struct i2c_client *i2c,
static struct i2c_driver pcm3060_i2c_driver = {
.driver = {
.name = "pcm3060",
-#ifdef CONFIG_OF
- .of_match_table = pcm3060_of_match,
-#endif /* CONFIG_OF */
+ .of_match_table = of_match_ptr(pcm3060_of_match),
},
.id_table = pcm3060_i2c_id,
.probe = pcm3060_i2c_probe,
Just wrapping the assignment into the macro call turned out to be easy.
But I haven't found a way to remove the now #ifdef :(
Any idea how I could solve this ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next reply other threads:[~2019-06-05 16:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 16:25 Enrico Weigelt, metux IT consult [this message]
2019-06-05 19:51 ` [Cocci] How to replace obsolete #ifdef's? Markus Elfring
2019-06-05 20:52 ` [Cocci] how to replace obsolete #ifdef's Julia Lawall
2019-06-05 21:42 ` Enrico Weigelt, metux IT consult
2019-06-06 5:46 ` Julia Lawall
2019-06-06 9:30 ` [Cocci] How to replace obsolete #ifdef's? Markus Elfring
2019-06-06 10:34 ` Julia Lawall
2019-06-06 14:20 ` Markus Elfring
2019-06-06 15:34 ` David Young
2019-06-07 12:01 ` Enrico Weigelt, metux IT consult
2019-06-07 12:30 ` Julia Lawall
2019-06-06 9:15 ` Markus Elfring
2019-06-06 9:39 ` Julia Lawall
2019-06-07 12:05 ` Enrico Weigelt, metux IT consult
2019-06-07 12:32 ` Julia Lawall
2019-06-07 13:40 ` Markus Elfring
2019-06-07 16:33 ` Julia Lawall
2019-06-07 17:26 ` Markus Elfring
2019-06-07 17:36 ` Markus Elfring
2019-06-07 18:48 ` Markus Elfring
2019-06-07 18:59 ` Julia Lawall
2019-06-08 7:49 ` [Cocci] Handling of designated initialisers by SmPL? Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c138195-ac1a-4ad6-c6e6-720acd4ea34f@metux.net \
--to=lkml@metux.net \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).