cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>,
	Coccinelle <cocci@systeme.lip6.fr>,
	linux-doc@vger.kernel.org
Cc: Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	linux-kernel@vger.kernel.org
Subject: Re: [Cocci] Coccinelle: semantic patch for missing of_node_put
Date: Sat, 18 May 2019 16:43:18 +0200	[thread overview]
Message-ID: <6790f1f5-284e-74b2-8b32-6245ba8e5fc2@web.de> (raw)
In-Reply-To: <201905171432571474636@zte.com.cn>

> $ spatch --tokens-c drivers/of/base.c  2>&1  | grep "Tag3 " | grep "of_node_put() on it when done." | awk -F " - " '{print $1}' | grep  -o "of_[[:print:]]*"

This command example points some details out for further software development considerations.

1. I find it questionable that relevant data are provided by the output channel
   “stderr” so far.
   https://github.com/coccinelle/coccinelle/blob/66a1118e04a6aaf1acdae89623313c8e05158a8d/docs/manual/spatch_options.tex#L165

2. The OCaml code “"Tag" ^ string_of_int t ^” occurs in three source files.
   * It is commented out in one file.
     https://github.com/coccinelle/coccinelle/blob/761cf6a1fbbf3173896ff61f0ea7e4a83a5b2a57/commons/common.ml#L305

   * These places refer to the source file “dumper.ml 1.2” by Richard W. M. Jones.
     Thus it seems that this code is relevant at the moment.
     https://github.com/coccinelle/coccinelle/blob/175de16bc7e535b6a89a62b81a673b0d0cd7075c/commons/ocamlextra/dumper.ml#L1

3. How will the software documentation evolve here?

4. Safe data processing can be performed only if the involved structures
   will remain clear for a while.
   Is the situation partly unclear?

   Should the information after which function calls the function “of_node_put”
   should be called be determined from any other documentation format?

5. A programming language like “awk” has got the potential to extract useful data
   (also without calling the tool “grep” additionally).

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2019-05-20 12:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201905171432571474636@zte.com.cn>
2019-05-17  8:10 ` [Cocci] Coccinelle: semantic patch for missing of_node_put Markus Elfring
     [not found] ` <alpine.DEB.2.20.1905170912590.4014@hadrien>
2019-05-17  8:22   ` Markus Elfring
     [not found]   ` <20190520093303.GA9320@atrey.karlin.mff.cuni.cz>
2019-05-20  9:52     ` Julia Lawall
2019-05-20 17:20       ` Sasha Levin
2019-05-20 19:53         ` Julia Lawall
2019-05-20 20:11           ` Markus Elfring
2019-05-18 14:43 ` Markus Elfring [this message]
2019-06-04  5:08 ` Markus Elfring
2019-06-04  5:50   ` wen.yang99
2019-06-04  6:36     ` Markus Elfring
2019-06-04  8:55       ` wen.yang99
2019-06-04  9:08         ` Markus Elfring
2019-06-04 11:28     ` Markus Elfring
2019-06-05 18:23   ` [Cocci] Coccinelle: Searching for “when done” in function comments Markus Elfring
2019-05-09  1:47 [Cocci] [PATCH] coccinelle: semantic patch for missing of_node_put wen.yang99
2019-05-09  8:10 ` [Cocci] Coccinelle: " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6790f1f5-284e-74b2-8b32-6245ba8e5fc2@web.de \
    --to=markus.elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=wen.yang99@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).