Re: [Cocci] [PATCH 0/4] parsing_c: parser: Add end_attributes_opt rule

Re: [Cocci] [PATCH 0/4] parsing_c: parser: Add end_attributes_opt rule

[Markus Elfring]

> Patches for improving the C parsing of attributes[1] introduced a lot
> redundant code in the C parser. This patch series resolves this by adding
> a rule for optional end attributes and merging the redundant code
> together.
>
> [1]
> [PATCH v2 00/25] cocci: Improve C parsing of attributes
> https://lore.kernel.org/cocci/20200528122428.4212-1-jaskaransingh7654321@gmail.com/

Could questionable source code have been avoided before?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] [Linux-kernel-mentees] [PATCH 0/4] parsing_c: parser: Add end_attributes_opt rule

[Greg KH]

On Mon, Jun 08, 2020 at 02:47:41PM +0200, Markus Elfring wrote:
> > Patches for improving the C parsing of attributes[1] introduced a lot
> > redundant code in the C parser. This patch series resolves this by adding
> > a rule for optional end attributes and merging the redundant code
> > together.
> >
> > [1]
> > [PATCH v2 00/25] cocci: Improve C parsing of attributes
> > https://lore.kernel.org/cocci/20200528122428.4212-1-jaskaransingh7654321@gmail.com/
> 
> Could questionable source code have been avoided before?

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless review
comment to a patch submission on a Linux kernel developer mailing list.
I strongly suggest that you not do this anymore.  Please do not bother
developers who are actively working to produce patches and features with
comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not needed
to follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and inability
to adapt to feedback.  Please feel free to also ignore emails from them.

thanks,

greg k-h's patch email bot
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] [PATCH 0/4] parsing_c: parser: Add end_attributes_opt rule

[Julia Lawall]

On Mon, 8 Jun 2020, Jaskaran Singh wrote:

> Patches for improving the C parsing of attributes[1] introduced a lot
> redundant code in the C parser. This patch series resolves this by adding
> a rule for optional end attributes and merging the redundant code
> together.

All are applied, thanks.

julia

>
> [1]
> [PATCH v2 00/25] cocci: Improve C parsing of attributes
> https://lore.kernel.org/cocci/20200528122428.4212-1-jaskaransingh7654321@gmail.com/
>
> Jaskaran Singh (4):
>       parsing_c: parser: Add end_attributes_opt rule
>       parsing_c: parser: Use end_attributes_opt in decl2
>       parsing_c: parser: Use end_attributes_opt in field_declaration
>       parsing_c: parser: Use end_attributes_opt in cpp_other
>
>  parser_c.mly |   96 +++++------------------------------------------------------
>  1 file changed, 9 insertions(+), 87 deletions(-)
>
>
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

[Cocci] [PATCH 0/4] parsing_c: parser: Add end_attributes_opt rule

[Jaskaran Singh]

Patches for improving the C parsing of attributes[1] introduced a lot
redundant code in the C parser. This patch series resolves this by adding
a rule for optional end attributes and merging the redundant code
together.

[1]
[PATCH v2 00/25] cocci: Improve C parsing of attributes
https://lore.kernel.org/cocci/20200528122428.4212-1-jaskaransingh7654321@gmail.com/

Jaskaran Singh (4):
      parsing_c: parser: Add end_attributes_opt rule
      parsing_c: parser: Use end_attributes_opt in decl2
      parsing_c: parser: Use end_attributes_opt in field_declaration
      parsing_c: parser: Use end_attributes_opt in cpp_other

 parser_c.mly |   96 +++++------------------------------------------------------
 1 file changed, 9 insertions(+), 87 deletions(-)



_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci