[Cocci] Checking size determinations with SmPL

[Cocci] Checking size determinations with SmPL

[Markus Elfring]

Hello,

The following code example gets accepted by the Coccinelle software.

@display1@
expression* e;
type t;
@@
*\( sizeof(t) \| sizeof(*e) \)


Would it be nice if another script variant can work together with
such a SmPL disjunction also in this way?

@display2@
expression* e;
type t;
@@
*sizeof( \( t \| *e \) )


elfring@Sonne:~/Projekte/Coccinelle/Probe> spatch --parse-cocci check_sizeof2.cocci
…
minus: parse error:
  File "check_sizeof2.cocci", line 5, column 17, charpos = 54
  around = '*',
  whole content = *sizeof( \( t \| *e \) )


Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Checking size determinations with SmPL

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]



On Sun, 17 Nov 2019, Markus Elfring wrote:

> Hello,
>
> The following code example gets accepted by the Coccinelle software.
>
> @display1@
> expression* e;
> type t;
> @@
> *\( sizeof(t) \| sizeof(*e) \)
>
>
> Would it be nice if another script variant can work together with
> such a SmPL disjunction also in this way?

No.  They are quite different because the () is required on a type but
optional on an expression.

julia

>
> @display2@
> expression* e;
> type t;
> @@
> *sizeof( \( t \| *e \) )
>
>
> elfring@Sonne:~/Projekte/Coccinelle/Probe> spatch --parse-cocci check_sizeof2.cocci
> …
> minus: parse error:
>   File "check_sizeof2.cocci", line 5, column 17, charpos = 54
>   around = '*',
>   whole content = *sizeof( \( t \| *e \) )
>
>
> Regards,
> Markus
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Checking size determinations with SmPL

[Markus Elfring]

>> *\( sizeof(t) \| sizeof(*e) \)
>>
>>
>> Would it be nice if another script variant can work together with
>> such a SmPL disjunction also in this way?
>
> No.  They are quite different because the () is required on a type but
> optional on an expression.
…
>> @display2@
>> expression* e;
>> type t;
>> @@
>> *sizeof( \( t \| *e \) )

Would such a search pattern be acceptable if both items would be handled
as non-optional selections in this case?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci