* [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts within selected directory hierarchy
@ 2019-10-25 1:19 zhongshiqi
2019-10-25 7:42 ` Markus Elfring
0 siblings, 1 reply; 5+ messages in thread
From: zhongshiqi @ 2019-10-25 1:19 UTC (permalink / raw)
To: Julia.Lawall
Cc: wang.yi59, michal.lkml, nicolas.palix, linux-kernel, xue.zhihong,
cheng.shengyu, zhongshiqi, cocci
Allow defining COCCI as a directory to search SmPL scripts. Start a
corresponding file determination if the environment variable “COCCI”
contains an acceptable path.
Signed-off-by: zhongshiqi <zhong.shiqi@zte.com.cn>
---
Changes in v3:
1:rewrite change description
2:fix patch subject
3:modify commit log
Changes in v2:
1.fix patch subject according to the reply by Markus
<Markus.Elfring@web.de>
2.change description in “imperative mood”
scripts/coccicheck | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index e04d328..a1c4197 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -257,6 +257,10 @@ if [ "$COCCI" = "" ] ; then
for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
coccinelle $f
done
+elif [ -d "$COCCI" ] ; then
+ for f in `find $COCCI/ -name '*.cocci' -type f | sort`; do
+ coccinelle $f
+ done
else
coccinelle $COCCI
fi
--
2.9.5
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts within selected directory hierarchy
2019-10-25 1:19 [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts within selected directory hierarchy zhongshiqi
@ 2019-10-25 7:42 ` Markus Elfring
2019-10-25 9:38 ` [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
2019-10-26 2:31 ` [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
0 siblings, 2 replies; 5+ messages in thread
From: Markus Elfring @ 2019-10-25 7:42 UTC (permalink / raw)
To: Zhong Shiqi, cocci
Cc: Yi Wang, Michal Marek, Nicolas Palix, kernel-janitors,
linux-kernel, Xue Zhihong, Cheng Shengyu
> Allow defining COCCI as a directory to search SmPL scripts. Start a
> corresponding file determination if the environment variable “COCCI”
> contains an acceptable path.
Can another wording fine-tuning matter for such a change description?
* Allow defining the environment variable “COCCI” as a directory
to search SmPL scripts.
* Start a corresponding file determination if it contains an acceptable path.
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts withinselected directory hierarchy
2019-10-25 7:42 ` Markus Elfring
@ 2019-10-25 9:38 ` zhong.shiqi
2019-10-25 11:06 ` [Cocci] [v3] coccicheck: Support search for SmPL scripts within selected " Markus Elfring
2019-10-26 2:31 ` [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
1 sibling, 1 reply; 5+ messages in thread
From: zhong.shiqi @ 2019-10-25 9:38 UTC (permalink / raw)
To: Markus.Elfring
Cc: wang.yi59, michal.lkml, nicolas.palix, kernel-janitors,
linux-kernel, xue.zhihong, cheng.shengyu, cocci
[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]
> > Allow defining COCCI as a directory to search SmPL scripts. Start a
> > corresponding file determination if the environment variable “COCCI”
> > contains an acceptable path.
>
> Can another wording fine-tuning matter for such a change description?
>
> * Allow defining the environment variable “COCCI” as a directory
> to search SmPL scripts.
>
> * Start a corresponding file determination if it contains an acceptable path.
Thanks,i think it would be better!
Best Regards,
zhong.shiqi
> Regards,
> Markus
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [v3] coccicheck: Support search for SmPL scripts within selected directory hierarchy
2019-10-25 9:38 ` [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
@ 2019-10-25 11:06 ` Markus Elfring
0 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2019-10-25 11:06 UTC (permalink / raw)
To: Zhong Shiqi, cocci
Cc: Yi Wang, Michal Marek, Nicolas Palix, kernel-janitors,
linux-kernel, Xue Zhihong, Cheng Shengyu
> Thanks,i think it would be better!
Will this clarification trigger any further collateral evolution
for related information sources?
Example:
https://bottest.wiki.kernel.org/coccicheck
By the way:
Would you like to take another look at the preservation of delimiters
(like space characters) in presented messages?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts withinselected directory hierarchy
2019-10-25 7:42 ` Markus Elfring
2019-10-25 9:38 ` [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
@ 2019-10-26 2:31 ` zhong.shiqi
1 sibling, 0 replies; 5+ messages in thread
From: zhong.shiqi @ 2019-10-26 2:31 UTC (permalink / raw)
To: Markus.Elfring
Cc: wang.yi59, michal.lkml, nicolas.palix, kernel-janitors,
linux-kernel, xue.zhihong, cheng.shengyu, cocci
[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]
> > Allow defining COCCI as a directory to search SmPL scripts. Start a
> > corresponding file determination if the environment variable “COCCI”
> > contains an acceptable path.
>
> Can another wording fine-tuning matter for such a change description?
>
> * Allow defining the environment variable “COCCI” as a directory
> to search SmPL scripts.
>
> * Start a corresponding file determination if it contains an acceptable path.
Thanks,i think it would be better!
Best Regards,
zhong.shiqi
> Regards,
> Markus
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-26 2:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 1:19 [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts within selected directory hierarchy zhongshiqi
2019-10-25 7:42 ` Markus Elfring
2019-10-25 9:38 ` [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
2019-10-25 11:06 ` [Cocci] [v3] coccicheck: Support search for SmPL scripts within selected " Markus Elfring
2019-10-26 2:31 ` [Cocci] [PATCH v3] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).