Coccinelle archive on lore.kernel.org
 help / color / Atom feed
From: Strace Labs <stracelabs@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] Replacing printf() parameters according to used data types
Date: Fri, 29 Nov 2019 15:19:20 -0200
Message-ID: <CABvP5W1HPdE8=h2LGDo4etG2oWzi7DnycJczu=zVr+AKOamVdA@mail.gmail.com> (raw)
In-Reply-To: <9e9f6596-1b8d-dc4f-86cf-21094200809d@web.de>

[-- Attachment #1.1: Type: text/plain, Size: 2022 bytes --]

On Fri, Nov 29, 2019 at 2:09 PM Markus Elfring <Markus.Elfring@web.de>
wrote:

> > so, that suggestion works the same as my previous shared statement.
>
> I suggest to take another look at presented implementation details.
>
>
I did it, even digging the grammar and ALL samples and didn't find anything
similar to handle format strings with multiple parameters as mentioned.


>
> > but, only for calls like: *my_printf("%s", h1.name);*,
>
> I limited my suggestion intentionally.
>
>
> > not for *my_printf("%d here also, tt=%s | %s and %m\n", id, h2->name,
> h2->name, s2);*
>
> Such a function call is using more parameters. Would you get into
> the mood then to specify additional metavariables in SmPL script variants?
>
>

I can't because the calls around the code have different uses with
different variants.



> > so, I am not sure if Coccinelle is able to do that.
>
> I hope that more useful data processing for format strings will become
> supported by the semantic patch language.
> Yesterday an information was given that another functionality is also
> work in progress.
>



Interesting.



>
> > I've read all samples available in the Kernel and Coccinelle repo's
>
> I find such information interesting and promising.
>
>
> > and I didn't see any similar case.
>
> This observation can be fine.
> How often do you fiddle with source code transformations around
> format strings?
>
>


Well, I've used it before but for me, it is the first "complex" case that I
am working on. even I still digging trying to figure out how to do that but
I still not sure if the Coccelinne is capable to do that yes or no.




>
> > I think that if Julia Lawall don't know, No one in the world knows.
>
> Such an impression can occur. - But I would like to point further
> possibilities out for desired knowledge distribution.
>
> * Would you like to contact any more related developers?

* How do you think about to improve your own expertise
>   (around the discussed free software) in any ways?
>
> Regards,
> Markus
>

[-- Attachment #1.2: Type: text/html, Size: 3526 bytes --]

<div dir="ltr"><div dir="ltr">On Fri, Nov 29, 2019 at 2:09 PM Markus Elfring &lt;<a href="mailto:Markus.Elfring@web.de">Markus.Elfring@web.de</a>&gt; wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">&gt; so, that suggestion works the same as my previous shared statement.<br>
<br>
I suggest to take another look at presented implementation details.<br>
<br></blockquote><div><br></div><div>I did it, even digging the grammar and ALL samples and didn&#39;t find anything similar to handle format strings with multiple parameters as mentioned.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
&gt; but, only for calls like: *my_printf(&quot;%s&quot;, <a href="http://h1.name" rel="noreferrer" target="_blank">h1.name</a>);*,<br>
<br>
I limited my suggestion intentionally.<br>
<br>
<br>
&gt; not for *my_printf(&quot;%d here also, tt=%s | %s and %m\n&quot;, id, h2-&gt;name, h2-&gt;name, s2);*<br>
<br>
Such a function call is using more parameters. Would you get into<br>
the mood then to specify additional metavariables in SmPL script variants?<br>
<br></blockquote><div><br></div><div><br></div><div>I can&#39;t because the calls around the code have different uses with different variants. </div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
&gt; so, I am not sure if Coccinelle is able to do that.<br>
<br>
I hope that more useful data processing for format strings will become<br>
supported by the semantic patch language.<br>
Yesterday an information was given that another functionality is also<br>
work in progress.<br></blockquote><div><br></div><div><br></div><div><br></div><div>Interesting.</div><div> </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
&gt; I&#39;ve read all samples available in the Kernel and Coccinelle repo&#39;s<br>
<br>
I find such information interesting and promising.<br>
<br>
<br>
&gt; and I didn&#39;t see any similar case.<br>
<br>
This observation can be fine.<br>
How often do you fiddle with source code transformations around<br>
format strings?<br>
<br></blockquote><div><br></div><div><br></div><div><br></div><div>Well, I&#39;ve used it before but for me, it is the first &quot;complex&quot; case that I am working on. even I still digging trying to figure out how to do that but I still not sure if the Coccelinne is capable to do that yes or no.</div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
&gt; I think that if Julia Lawall don&#39;t know, No one in the world knows.<br>
<br>
Such an impression can occur. - But I would like to point further<br>
possibilities out for desired knowledge distribution.<br>
<br>
* Would you like to contact any more related developers?</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
* How do you think about to improve your own expertise<br>
  (around the discussed free software) in any ways?<br>
<br>
Regards,<br>
Markus<br>
</blockquote></div></div>

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply index

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28  2:11 [Cocci] Replacing printf/format calls based on the data-type Strace Labs
2019-11-28  7:07 ` Julia Lawall
2019-11-28 17:45   ` Strace Labs
2019-11-29 14:48   ` [Cocci] Replacing printf() parameters according to used data types Markus Elfring
2019-11-28  7:50 ` Markus Elfring
2019-11-29  0:35   ` Jorge Pereira
2019-11-29  8:29     ` Markus Elfring
2019-11-29 10:57       ` Strace Labs
2019-11-29 12:33         ` Markus Elfring
2019-11-29 14:47           ` Strace Labs
2019-11-29 16:08             ` Markus Elfring
2019-11-29 17:19               ` Strace Labs [this message]
2019-11-29 17:45                 ` Markus Elfring
2019-11-29 20:55             ` Julia Lawall
2019-11-30  2:25               ` Strace Labs
2019-11-30  6:35                 ` Julia Lawall
2019-11-30  8:46                 ` Markus Elfring
2019-12-01  8:00                 ` [Cocci] Changing format string usage with SmPL? Markus Elfring
2019-12-03  3:30                   ` Strace Labs
2019-12-03  5:18                     ` Julia Lawall
2019-12-03 13:28                       ` Markus Elfring
2019-12-03 15:43                       ` [Cocci] Generation of expression lists by SmPL script rules? Markus Elfring
2019-12-03 17:28                       ` [Cocci] Changing format string usage with SmPL? Strace Labs
2019-12-04  0:21                         ` Strace Labs
2019-12-06 19:36                           ` Markus Elfring
2019-12-07  7:49                           ` Markus Elfring
2019-12-04  6:47                         ` Julia Lawall
2019-12-06 19:44                           ` Markus Elfring
2019-12-06 19:20                         ` Markus Elfring
2019-12-03 10:01                     ` Markus Elfring
2019-11-30 15:11               ` [Cocci] Replacing printf() parameters according to used data types Markus Elfring

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABvP5W1HPdE8=h2LGDo4etG2oWzi7DnycJczu=zVr+AKOamVdA@mail.gmail.com' \
    --to=stracelabs@gmail.com \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git