From: Julia Lawall <julia.lawall@inria.fr>
To: Strace Labs <stracelabs@gmail.com>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] Replacing printf/format calls based on the data-type
Date: Thu, 28 Nov 2019 08:07:57 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911280807030.3704@hadrien> (raw)
In-Reply-To: <CABvP5W1W=p1-n_831VaiJyNsHrepFS0CNJSDQqmfPkrC1rx=Ww@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1824 bytes --]
--- Please note the new email address ---
On Thu, 28 Nov 2019, Strace Labs wrote:
> Hi,
> I am working on a semantic patch for replacing specific format string token based on the used data-type.
> so, I have several calls of my_printf() and some special macros pointing to them around my code.
>
> e.g: part of my code.
> .....
> struct mydata *m;
> struct mydata h;
> .....
> my_printf("%s", m->name);
> .....
> my_printf("%s", h.name);
> .....
> my_printf("whatever id %d following the string %s\n", id, m->name);
> ....
> Macro_to_my_printf("Hey id %d, let's see %s\n", id, h.name);
> .....
> Macro2_to_my_printf(fd, "Hey id %d, let's see %s\n", id, m->name);
> .....
>
> My current humble *.cocci
>
> $ cat fix-my_printf.cocci
> @r1_heap@
> struct mydata *SMD;
> format F =~ "s";
> @@
> -my_printf("%@F@", SMD->name);
> +my_printf("%m", SMD);
>
> @r1_stack@
> struct mydata SMD;
> format F =~ "s";
> @@
> -my_printf("%@F@", SMD.name);
> +my_printf("%m", &SMD);
> $
>
> But, I can match only with partial content as can be seen below.
>
> $ spatch --partial-match --sp-file fix-my_printf.cocci sample-format-string.c | egrep "^(\+|-)"
> HANDLING: sample-format-string.c
> diff =
> HANDLING: /Volumes/Users/jpereira/Devel/Sandbox/sample-format-string.c
> diff =
> --- /Volumes/Users/jpereira/Devel/Sandbox/sample-format-string.c
> +++ /var/folders/ld/6tg9c6qj4fx4c85q26mcqrsh0000gn/T/cocci-output-24659-130f86-sample-format-string.c
> - my_printf("%s", m->name);
> + my_printf("%m", m);
> - my_printf("%s", h.name);
> + my_printf("%m", &h);
> $
>
> Anyone could give me a light about how to proceed to match the entire ".....string format..." ?
I think that what you are asking is why you can't write a pattern like:
foo("...
-%@d@
+%x
...")
At the moment, there seems to be a bug. I will check on that.
julia
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-11-28 7:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 2:11 [Cocci] Replacing printf/format calls based on the data-type Strace Labs
2019-11-28 7:07 ` Julia Lawall [this message]
2019-11-28 17:45 ` Strace Labs
2019-11-29 14:48 ` [Cocci] Replacing printf() parameters according to used data types Markus Elfring
2019-11-28 7:50 ` Markus Elfring
2019-11-29 0:35 ` Jorge Pereira
2019-11-29 8:29 ` Markus Elfring
2019-11-29 10:57 ` Strace Labs
2019-11-29 12:33 ` Markus Elfring
2019-11-29 14:47 ` Strace Labs
2019-11-29 16:08 ` Markus Elfring
2019-11-29 17:19 ` Strace Labs
2019-11-29 17:45 ` Markus Elfring
2019-11-29 20:55 ` Julia Lawall
2019-11-30 2:25 ` Strace Labs
2019-11-30 6:35 ` Julia Lawall
2019-11-30 8:46 ` Markus Elfring
2019-12-01 8:00 ` [Cocci] Changing format string usage with SmPL? Markus Elfring
2019-12-03 3:30 ` Strace Labs
2019-12-03 5:18 ` Julia Lawall
2019-12-03 13:28 ` Markus Elfring
2019-12-03 15:43 ` [Cocci] Generation of expression lists by SmPL script rules? Markus Elfring
2019-12-03 17:28 ` [Cocci] Changing format string usage with SmPL? Strace Labs
2019-12-04 0:21 ` Strace Labs
2019-12-06 19:36 ` Markus Elfring
2019-12-07 7:49 ` Markus Elfring
2019-12-04 6:47 ` Julia Lawall
2019-12-06 19:44 ` Markus Elfring
2019-12-06 19:20 ` Markus Elfring
2019-12-03 10:01 ` Markus Elfring
2019-11-30 15:11 ` [Cocci] Replacing printf() parameters according to used data types Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911280807030.3704@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=stracelabs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).