Re: [cocci] [PATCH v2] Exit with non-zero status when spatch on a directory fails

[Jan Tojnar <jtojnar@gmail.com>]

On Mon, 5 Sept 2022 at 21:51, Julia Lawall <julia.lawall@inria.fr> wrote:
>
> The patch has been applied, followed by another one that dropped th e
> --keep-trying option and that addresses the parmap issue.

Thanks, that will work for us, except that you probably accidentally
made it so that patching only happens when a failure occurs – there
should be `not` before `patching_failed` on this line:
https://github.com/coccinelle/coccinelle/blob/5448bb2bd03491ffec356bf7bd6ddcdbf4d36bc9/enter.ml#L1419

Additionally, it looks like you keep introducing more tab characters
into the indentation, resulting in mixed tabs and spaces. This makes
diffs more noisy than necessary and the code can end up displayed
misaligned in some text editors.

May I suggest adding the following .editorconfig file to the root of
the repository? Hopefully, your editor has support for that standard
and will use consistent formatting:
https://editorconfig.org/#pre-installed

root = true

[*]
end_of_line = lf
insert_final_newline = true

[*.{ml,mli}]
indent_style = space
indent_size = 2
tab_width = 8